DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
	dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org
Subject: Re: [PATCH v2 2/9] test/bbdev: fix MLD output size computation
Date: Tue, 25 Jun 2024 10:39:38 +0200	[thread overview]
Message-ID: <659fd2d8-fb82-43e7-8524-7eebc6387c7b@redhat.com> (raw)
In-Reply-To: <20240624150237.47169-3-hernan.vargas@intel.com>



On 6/24/24 17:02, Hernan Vargas wrote:
> For perf tests, the operation size for the MLD-TS was incorrect.
> Fixed so that the performance numbers are correct.
> Largely cosmetic only.
> 
> Fixes: 95f192a40e35 ("test/bbdev: add MLD cases")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   app/test-bbdev/test_bbdev_perf.c | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index 6d9bf3a233ec..9841464922ac 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -94,6 +94,8 @@
>   #define K0_2_2 25 /* K0 fraction numerator for rv 2 and BG 2 */
>   #define K0_3_1 56 /* K0 fraction numerator for rv 3 and BG 1 */
>   #define K0_3_2 43 /* K0 fraction numerator for rv 3 and BG 2 */
> +#define NUM_SC_PER_RB (12) /* Number of subcarriers in a RB in 3GPP. */
> +#define BITS_PER_LLR  (8)  /* Number of bits in a LLR. */
>   
>   #define HARQ_MEM_TOLERANCE 256
>   static struct test_bbdev_vector test_vector;
> @@ -2896,8 +2898,14 @@ calc_fft_size(struct rte_bbdev_fft_op *op)
>   static uint32_t
>   calc_mldts_size(struct rte_bbdev_mldts_op *op)
>   {
> -	uint32_t output_size;
> -	output_size = op->mldts.num_layers * op->mldts.num_rbs * op->mldts.c_rep;
> +	uint32_t output_size = 0;
> +	uint16_t i;
> +
> +	for (i = 0; i < op->mldts.num_layers; i++)
> +		output_size += op->mldts.q_m[i];
> +
> +	output_size *= NUM_SC_PER_RB * BITS_PER_LLR * op->mldts.num_rbs * (op->mldts.c_rep + 1);
> +
>   	return output_size;
>   }
>   

Thanks for the change, much clearer now!

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Maxime


  reply	other threads:[~2024-06-25  8:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 15:02 [PATCH v2 0/9] test-bbdev fixes and improvements for 24.07 Hernan Vargas
2024-06-24 15:02 ` [PATCH v2 1/9] test/bbdev: fix TB logic Hernan Vargas
2024-06-24 15:02 ` [PATCH v2 2/9] test/bbdev: fix MLD output size computation Hernan Vargas
2024-06-25  8:39   ` Maxime Coquelin [this message]
2024-06-24 15:02 ` [PATCH v2 3/9] test/bbdev: fix interrupt tests Hernan Vargas
2024-06-24 15:02 ` [PATCH v2 4/9] test/bbdev: change iter-max argument Hernan Vargas
2024-06-24 15:02 ` [PATCH v2 5/9] test/bbdev: improve timeout message format Hernan Vargas
2024-06-24 15:02 ` [PATCH v2 6/9] test/bbdev: add soft output parsing capability Hernan Vargas
2024-06-24 15:02 ` [PATCH v2 7/9] test/bbdev: check assumptions on fft window Hernan Vargas
2024-06-25  8:40   ` Maxime Coquelin
2024-06-24 15:02 ` [PATCH v2 8/9] test/bbdev: update fft measurement output Hernan Vargas
2024-06-24 15:02 ` [PATCH v2 9/9] test/bbdev: remove unnecessary line Hernan Vargas
2024-06-25 11:42 ` [PATCH v2 0/9] test-bbdev fixes and improvements for 24.07 Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=659fd2d8-fb82-43e7-8524-7eebc6387c7b@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=hernan.vargas@intel.com \
    --cc=nicolas.chautru@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).