From: "Su, Simei" <simei.su@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types
Date: Wed, 31 Jul 2019 02:57:57 +0000 [thread overview]
Message-ID: <65F28F834D25B54B9EC1999B623071B30C4291FA@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190730085007.23775125@hermes.lan>
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, July 30, 2019 11:50 PM
> To: Su, Simei <simei.su@intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> adrien.mazarguil@6wind.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types
>
> On Fri, 26 Jul 2019 08:35:50 +0800
> simei <simei.su@intel.com> wrote:
>
> > From: Simei Su <simei.su@intel.com>
> >
> > This RFC reserves several bits as input set selection from bottom of
> > the 64 bits. The flow type is combined with input set to represent rss
> > types.
> >
> > Correct the input set mask to align with the definition in rte_ethdev.h.
> > for example:
> > ETH_RSS_IPV4 | ETH_RSS_INSET_L3_SRC: hash on src ip address only
> > ETH_RSS_IPV4_UDP | ETH_RSS_INSET_L4_DST: hash on src/dst IP and
> > dst UDP port
> > ETH_RSS_L2_PAYLOAD | ETH_RSS_INSET_L2_DST: hash on dst mac
> address
> >
> > Signed-off-by: Simei Su <simei.su@intel.com>
>
> NAK to any patch that "reserves" bits for future use.
>
> Please include the patch as part of a set of patches that actually implements the
> functionality on a device.
Ok. Later, I will add the implementation functionality as a set of patches.
prev parent reply other threads:[~2019-07-31 2:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 11:37 [dpdk-dev] [RFC] " simei
2019-07-26 0:35 ` [dpdk-dev] [RFC,v2] " simei
2019-07-26 10:21 ` Ferruh Yigit
2019-07-29 2:44 ` [dpdk-dev] [RFC,v3] " simei
2019-07-30 6:06 ` Ori Kam
2019-07-30 7:42 ` Adrien Mazarguil
2019-08-01 4:54 ` [dpdk-dev] [RFC,v4] " simei
2019-07-29 15:30 ` [dpdk-dev] [RFC,v2] " Stephen Hemminger
2019-07-30 15:50 ` Stephen Hemminger
2019-07-31 2:57 ` Su, Simei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65F28F834D25B54B9EC1999B623071B30C4291FA@SHSMSX104.ccr.corp.intel.com \
--to=simei.su@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).