From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0088.outbound.protection.outlook.com [104.47.37.88]) by dpdk.org (Postfix) with ESMTP id 84F3AE5D for ; Mon, 11 Dec 2017 13:30:03 +0100 (CET) Received: from BN3PR03CA0111.namprd03.prod.outlook.com (10.174.66.29) by CY1PR03MB2361.namprd03.prod.outlook.com (10.166.207.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Mon, 11 Dec 2017 12:30:02 +0000 Received: from BN1AFFO11FD019.protection.gbl (2a01:111:f400:7c10::132) by BN3PR03CA0111.outlook.office365.com (2603:10b6:400:4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Mon, 11 Dec 2017 12:30:01 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD019.mail.protection.outlook.com (10.58.52.79) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.282.5 via Frontend Transport; Mon, 11 Dec 2017 12:29:56 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBBCTx1b012874; Mon, 11 Dec 2017 05:29:59 -0700 From: Shreyansh Jain To: Gaetan Rivet CC: References: <3f96d5f0-30d0-3e71-98f6-283d8bd05238@nxp.com> Message-ID: <65a762b8-5d9b-d5a8-c066-17a334e232a0@nxp.com> Date: Mon, 11 Dec 2017 18:13:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <3f96d5f0-30d0-3e71-98f6-283d8bd05238@nxp.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131574689962416734; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(336005)(376002)(346002)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(189003)(199004)(24454002)(58126008)(229853002)(67846002)(305945005)(316002)(65826007)(2486003)(5660300001)(2950100002)(6666003)(23676004)(6916009)(85426001)(356003)(77096006)(31686004)(47776003)(65806001)(65956001)(83506002)(86362001)(76176011)(31696002)(53936002)(104016004)(105606002)(106466001)(2870700001)(81156014)(4326008)(81166006)(8936002)(33646002)(8676002)(68736007)(2906002)(50466002)(64126003)(6246003)(36756003)(97736004)(498600001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2361; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD019; 1:FQH0JGHZDOAt2pWrhvRsE0toL2y0H+wzTtT3+ikWplcceqwkY+QWjSXH3ZG2MNdrBdL5mTz5ay10rpdpZMa4hGEyuJLKwEGTIQpheX5httGiAfOrR0L6Foc2XBfZI8qW X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8189d805-4616-431e-5a5e-08d54092e31b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603307); SRVR:CY1PR03MB2361; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 3:r43gAGq5yGwYYQK+xyurxhur3ZJrSqfZ7X0vge1f2OF0QXZ5rlJAsfsSF4Ar8kPm099JxakIIJTa4y8p+QYoyGr/lrH+PxmQu58n0BJBORV4aHAlHA/Ok3KcWWcdciT6F9IniBcoMKJ9CDqDdAx446Cby+c0MmCxJaNFm7/OkIB0DzkfA5jIoSu9aXXm000TwmyplPxAVgNSC7hJTfUw15sVoFGas6d1m1lfhB8uA+cCkV/arOx0U79XprZsbwfqtQ3pNlep8uW27tzVyzJuWUMS1vW/nR/nrjtmCrKRYHjvKehPjR+eyoxlMkagCjI8qHup9gfCMxXIrmFfL2tmqcn1XwUNy1yOb3gvHeHWzPE=; 25:EB5/AeX6Oae3jrph6yQcNA1hA/sjlYMQ2xExDu+JOIpMAtTz16qF9obgFqjJMHfr0qO+uUB06SMpiabiBhdMtmuE8b0WUbRz17y8i+a1tCMqW8SWitkSHkR/G9zD05VjSgG0LOXLAsmOVrAXX+jqNPeDVR/rDCyYTPQ1gWQKHmBf0eh+zZdBjNKpUAW/Oq/yvxo9wTjoRr321URR7pt2BjNk25F3SQP36IEsrqg2BGO2i6NvKO9An2q7yo6tcagQy5EJIXnlatsI4+aYbEhcM8CQFm3ORDZjyOg3DVgOxr6T+saQOcv4EuRMKVE78hmk/RrxhgO1dEmburyshpbptA== X-MS-TrafficTypeDiagnostic: CY1PR03MB2361: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 31:jisjKErbhESrqqhdl9Qa25fuHohLmGcIxkSQWD9T9OdQC+TSV/pbHz4I2R7fXMRElz8OqebFQa0FOjxQqaCBie5Fwch2CFUbZ/knoorRQJKXFfOx+Ivs+9GfLGDNOoMfYobGmVNHJD7piHx2un/TPgLUsNjzeF6yUWA7vs8R1tcpQLe40+GM3Sgs21827rbGWxfZ1d9tfIyoqRqgc6tMCCfyv7o4uqMbjIMDRv3vXCA=; 4:1rEOYentYEsLpdx/aNxhHcPJnNJ2g1TnuPpE8vCVT3K5zZii2LuKWJ86YApAZ0VqVD5lZbtmFHFMlyTwkLSqOR0kE24M5NM4g5FbSfhOy6dzu1gKG8o4GWwLIHL2xoFs5IMS/9xC2pSTMdw5jOzGJsBMbz6uVkHx/v7YaqhuJA6T6qjEsCsjXJ4q+d/NQOBdFOCE/lVL3eoHgL/FuBJ1S7fM92o/gXPZmJd4/YtHElj8Ge7JVd8uX8Zo1M0+hAxASB83JXsOSENMYpq3vNBy6Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231022)(3002001)(6055026)(6096035)(20161123561025)(20161123556025)(20161123565025)(20161123563025)(20161123559100)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(201708071742011); SRVR:CY1PR03MB2361; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CY1PR03MB2361; X-Forefront-PRVS: 0518EEFB48 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIyMzYxOzIzOkxET2pRb3NBeG9FamxOcmtiaG5wbVFYQ2NJ?= =?utf-8?B?Y09hdVRycEl1TWVMVXZyNlRkZ1F1NFFrRXhkUEI1QmtvWnZTRmxwQlpoRXd1?= =?utf-8?B?azZkeGRHQk5YZWtLRkM2OGowRUxqUXNFQ1FScUtoQXd5dGk1UVJaampxZmg0?= =?utf-8?B?K2FpZmhnZ3FOZzdQL2hmM0diYmRHZmZQSFJsUW1DT1M5UmZGT0xQME1pcUNR?= =?utf-8?B?eWhvMDI3T2w1SGY2eittQkVWb2ZhK1k2ZGs4ZDZ0NUJScVpxTlJWZ0FRUWJx?= =?utf-8?B?dnp1MEdOaDl2RTVvcnZPV2x0Mm9VUWdCZlZ6UEp6UUVTaUZsVnM3SG8vcUJp?= =?utf-8?B?Znd0R1lGeUI0bGN5dUwraG5Nb3l6ZGQxMEZEaW5mMmF3OEJLMjhoRjRpb0tz?= =?utf-8?B?aVdhL1VxM0REL0tERXpmQ1lady96TWpXSElxb1VZZFduV1UzUTVhOTB0S2Uw?= =?utf-8?B?NUp2R2tZQjJ1dDNjZ2p6bnJWeVViL3dnOGlySFEwZ1RvNlVlTjlwdDNPQkcw?= =?utf-8?B?STN0a0VkK0NiZjh5Ly9uVENIV3p1S0FlN0ZVWk0xQS8xZ1hIb0pnNlcwU1Ex?= =?utf-8?B?QlNhcjJYUytDdGdIbUFsVWEzSDdBbGZuM3J3RGNESkg0UUcxeENyeWRSMXBT?= =?utf-8?B?ZlZQY21OdHVYTFh0ZWVoK1ZxSkpVVUhnNTE3MVZrajUzUzJTemF0d0l0SFpr?= =?utf-8?B?eDNrdDNxU3o1VE4wS0dPbXdCdUh6M2FlS0NCMDZvK1ZFRzhBVSszM242a3Fm?= =?utf-8?B?QVo2dXBUYnVFT1IwclYzQ3daZjh6UW40Q0trS1lOUFhaUlBreXdhVkFPZjBu?= =?utf-8?B?c2xza0N3MSszK1JRdE92WXpqbUdwMUtsZnlsNVRxUmlxTEtEV3JQSzFVTHpQ?= =?utf-8?B?SzFOZWdLa3VoSUVmMzhrMGZJa3BqQUpDOGtteURTVWJkeHlqZWRQdlZ1aEhv?= =?utf-8?B?azArSmY1V3hqTkI4RUlhVGhoR3M3TFdTMlZnb2pzVVpwMlFjQXNLYVQzNmcw?= =?utf-8?B?bS93dHNOZTZKOTU0ajhjM0FwNndDTHh0Yko5NWZiVVJtcFdBRGdSeWdTaFRm?= =?utf-8?B?WmdZNW5LS0kvcXB2UDJyUmloN0NTMW50dnRScE5TSUNoTUpsZ1EwVFppQ1pZ?= =?utf-8?B?VVNZT2x6UjF1WjZnaUs1SlN6RGhmcVk4eEwzc0NGeGNKRVN0L2YySWFTczBj?= =?utf-8?B?RWkvR1QyWUlFajVyR0VaL0Y3V1JjVUtJN0tzM1dENTlTS09xMmRTbXhXRklm?= =?utf-8?B?ZGxyWXREZDZjQ2hRa2k3UXZpSWdNRXMwR1k3ZC8yRXlhOWk0TmN6ZDhHV2Rt?= =?utf-8?B?NXdlYVdpTTZTeldUSzYrSXI1bDcwcFFMRUNsREZnYVpsb3M3Snp2dXdndWZI?= =?utf-8?B?ZFRiZExpajAzdnAwWEp3WkxMR2JrN2tKNUt5MkIwWFlpNnR3TDVUb1BkZ3Uv?= =?utf-8?B?VytrYlQyUUtqUHByTjNmY1RuYWw5V2tTYVcvZ1AwYTNCUE02VjhxRERqeG9h?= =?utf-8?B?ei80ZFpKZHM5TnpET3VWVHZ1TXJ3V1VsVkdYd29hUEpEaWl6Wllub3cvOHhI?= =?utf-8?B?WmM3RlZ1VFp1RUdHa0pnMTFHSm5iRkR3NHkwUmc5YTlYWVNWVkpETFB1azZV?= =?utf-8?B?MUg4MmlRbVY0WGYvaVE3VjljVXVjUHFNNTF0bnJBQ0JoSkgxdXdZRklLZ3lw?= =?utf-8?Q?xQYxdeor8EUo1SFQu3MNNU5VIcE1I0H3Wi0OQIx?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2361; 6:s+FRirCD/Sfr5cW4YHqiuQD++9ObqjEg+AWjciwBnAecrGFhnnKB7FHAP5sYkF0iqmLOwgek3SLusiN1/YTyumg+3cjy2i+t4vh8RYyR4IncNakKvOAXm5xGqniTjGCF8tYpR2NMDmUvGfhQleAx5HjDD1vHNhywL1ruYWaXToxgDMky0dTnf01N/X07r8T9Bp003uzab5YcQH6o3OVrJIRK7JzgKpLLZbd86P7yHgRARASa0k3P+biZlQP3HZhnVJ+wlRCzL2icGhs8K27gtg6b1WcSAPktYO0yiXNde7bHPpFz68hELmlXGAuUI8B2yHkKAf1CGnKbvu6O4fnH/SgxQVirRlNuPcFsCrMnk8Q=; 5:7rsJ7evjtiwq5UIn9mdwE4MTLmFUSd8ybni8TyEMoB9dqOPK+y75xTT83w3kiRUyUXtOnDYoQ1J89ayXYFuvA+oocWfKNGkocEZ6i6MmuXL+9yZj0JdW/1d4tuH5kH13XTdaHXQgDykrSMUqv+7+Gaf+D/GWegIrBoPmvRJx7GI=; 24:3CvmxLxOO5jW4fjGbQJcGzVplP24bkM5ZarMZHzxBc2+ROs9H37aNyeYzF9Z43bSRPW0WOAAaJonfII8jzN19ZvKAGgvz/57PGcD5RzvHAI=; 7:Pv9gxXeQTprA6g3D/AB4i0QNO7ckAlRnx1EiO2/940fSFiDRWqRQ+fJRn9WEuQ69+A5QHfu4jLttN6x/ep0rl6GFJeR+4/rtTgpgIcKi9x+CClj2xdmbHYwk8R2jmUUR4u0QrTpJ3+0RHpAbW4QYakwBGg5o1Leu0glvbWe8VSo8fVlwtFp76HL09V94J8bvdH9VDMmvCCT10t3o4NVqGPpcXYPFimYiLREp35tbhJB/mOnIjr/A0kTX5Oy/HVzc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2017 12:29:56.0700 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8189d805-4616-431e-5a5e-08d54092e31b X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2361 Subject: Re: [dpdk-dev] [PATCH v1 4/8] bus: add probe mode setter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 12:30:04 -0000 On Monday 11 December 2017 06:09 PM, Shreyansh Jain wrote: > On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: >> Introduce new rte_bus operation to configure the probe policy. >> >> Implementation is required from buses interested in supporting >> this configuration element. >> > > [...] > >> diff --git a/lib/librte_eal/common/eal_common_options.c >> b/lib/librte_eal/common/eal_common_options.c >> index e40c049..630c9d2 100644 >> --- a/lib/librte_eal/common/eal_common_options.c >> +++ b/lib/librte_eal/common/eal_common_options.c >> @@ -997,29 +997,24 @@ int >>   eal_parse_common_option(int opt, const char *optarg, >>               struct internal_config *conf) >>   { >> -    static int b_used; >> -    static int w_used; >> - >>       switch (opt) { >>       /* blacklist */ >>       case 'b': >> -        if (w_used) >> -            goto bw_used; >> +        if (rte_bus_probe_mode_set("pci", RTE_BUS_PROBE_BLACKLIST) < 0) >> +            return -1; > > Generic layer shouldn't be concerned about "pci" or other bus. > Problem would be to find which bus this option needs to be set. > > What I can think of as options is: > 1. Storing this configuration until we can parse the argument for which > the argument has been created. That would mean changing the way > the "-b" and "-w" are passed and to allow non-PCI device identifier to > be passed. > 2. Call each bus bus->ctrl and let it decide what to do based on the args. >  - so, have a wrapper over rte_bus_probe_mode_set for all buses rather > than taking any one bus as option. > > (2) sounds most plausible for now as the application will not send the > bus name as argument. > And if brute force is not required, we need to split the argument to > know the bus - after making the device naming standardized (:<...>) > > Even before that, we need to agree that "-w' and "-b" are not more valid > only for PCIs. > > Above is more of loud thinging - I don't have concrete thought on this > for now. I'll revisit this after reviewing the patches in this series. Apologies. I see that some work has been done for this in devargs series - I was too quick to reply on this. Let me come back to you on this after reading through that series. > >>           if (eal_option_device_add(RTE_DEVTYPE_BLACKLISTED_PCI, >>                   optarg) < 0) { >>               return -1; >>           } >> -        b_used = 1; >>           break; >>       /* whitelist */ >>       case 'w': >> -        if (b_used) >> -            goto bw_used; >> +        if (rte_bus_probe_mode_set("pci", RTE_BUS_PROBE_WHITELIST) < 0) >> +            return -1; >>           if (eal_option_device_add(RTE_DEVTYPE_WHITELISTED_PCI, >>                   optarg) < 0) { >>               return -1; >>           } >> -        w_used = 1; >>           break; >>       /* coremask */ >>       case 'c': >> @@ -1165,10 +1160,6 @@ eal_parse_common_option(int opt, const char >> *optarg, > > [...] >