From: Panu Matilainen <pmatilai@redhat.com>
To: "Kerlin, MarcinX" <marcinx.kerlin@intel.com>,
"Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"david.marchand@6wind.com" <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] eal: fix resource leak of mapped memory
Date: Wed, 15 Jun 2016 13:05:34 +0300 [thread overview]
Message-ID: <65c6a8a7-ade6-e77a-1c1a-42c6e37f4682@redhat.com> (raw)
In-Reply-To: <68D830D942438745AD09BAFA99E33E8125EB2F@IRSMSX102.ger.corp.intel.com>
On 06/15/2016 12:35 PM, Kerlin, MarcinX wrote:
> Hi Sergio,
>
> Thanks for tips, I removed double casting and I leave (void *) casting because pointer hp is const and compiler returns warnings.
If hp is something that needs freeing then it shouldn't be const in the
first place. Please fix that instead.
- Panu -
next prev parent reply other threads:[~2016-06-15 10:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 16:27 [dpdk-dev] [PATCH 1/1] lib/librte_eal: fix resource leak Marcin Kerlin
2016-04-20 9:15 ` David Marchand
2016-04-21 11:19 ` Sergio Gonzalez Monroy
2016-04-21 11:49 ` Kerlin, MarcinX
2016-04-22 10:42 ` Panu Matilainen
2016-06-14 15:33 ` [dpdk-dev] [PATCH v2 1/1] eal: fix resource leak of mapped memory Marcin Kerlin
2016-06-15 8:49 ` Sergio Gonzalez Monroy
2016-06-15 9:35 ` Kerlin, MarcinX
2016-06-15 10:05 ` Panu Matilainen [this message]
2016-06-15 11:13 ` Kerlin, MarcinX
2016-06-15 10:45 ` [dpdk-dev] [PATCH v3 " Marcin Kerlin
2016-06-15 12:25 ` [dpdk-dev] [PATCH v4 " Marcin Kerlin
2016-06-16 12:57 ` Sergio Gonzalez Monroy
2016-06-16 15:14 ` [dpdk-dev] [PATCH v5 " Marcin Kerlin
2016-06-20 9:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65c6a8a7-ade6-e77a-1c1a-42c6e37f4682@redhat.com \
--to=pmatilai@redhat.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=marcinx.kerlin@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).