From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CF699ADC3 for ; Wed, 15 Jun 2016 12:05:36 +0200 (CEST) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3A7FFC049D5A; Wed, 15 Jun 2016 10:05:36 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-7-108.ams2.redhat.com [10.36.7.108]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5FA5YWi022887; Wed, 15 Jun 2016 06:05:35 -0400 To: "Kerlin, MarcinX" , "Gonzalez Monroy, Sergio" , "david.marchand@6wind.com" References: <1461083251-31140-1-git-send-email-marcinx.kerlin@intel.com> <1465918435-30973-1-git-send-email-marcinx.kerlin@intel.com> <68D830D942438745AD09BAFA99E33E8125EB2F@IRSMSX102.ger.corp.intel.com> Cc: "dev@dpdk.org" From: Panu Matilainen Message-ID: <65c6a8a7-ade6-e77a-1c1a-42c6e37f4682@redhat.com> Date: Wed, 15 Jun 2016 13:05:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <68D830D942438745AD09BAFA99E33E8125EB2F@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 15 Jun 2016 10:05:36 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 1/1] eal: fix resource leak of mapped memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 10:05:37 -0000 On 06/15/2016 12:35 PM, Kerlin, MarcinX wrote: > Hi Sergio, > > Thanks for tips, I removed double casting and I leave (void *) casting because pointer hp is const and compiler returns warnings. If hp is something that needs freeing then it shouldn't be const in the first place. Please fix that instead. - Panu -