From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49C56A0548; Wed, 21 Apr 2021 09:14:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D5524195D; Wed, 21 Apr 2021 09:14:10 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 7B97441932 for ; Wed, 21 Apr 2021 09:14:08 +0200 (CEST) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FQBY45dt0zpZW6 for ; Wed, 21 Apr 2021 15:11:04 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Wed, 21 Apr 2021 15:14:04 +0800 To: "Wang, Haiyue" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Guo, Jia" References: <1618986145-15414-1-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: <65cf86c7-949b-2f42-3fd0-660dc8d20506@huawei.com> Date: Wed, 21 Apr 2021 15:14:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/4/21 14:56, Wang, Haiyue дµÀ: >> -----Original Message----- >> From: Min Hu (Connor) >> Sent: Wednesday, April 21, 2021 14:22 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Guo, Jia ; Wang, Haiyue >> >> Subject: [PATCH] net/e1000: fix write NVM srwr alwayes return success >> >> From: Chengwen Feng >> >> This patch fixes e1000_write_nvm_srwr() alwayes return success. > > This commit message seems not so correct, it should be like: > > This fixes the timed out for shadow RAM write EEWR can't be detected. > >> >> Fixes: 5a32a257f957 ("e1000: more NICs in base driver") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Min Hu (Connor) >> --- >> drivers/net/e1000/base/e1000_i210.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c >> index 3c349d3..615e7c9 100644 >> --- a/drivers/net/e1000/base/e1000_i210.c >> +++ b/drivers/net/e1000/base/e1000_i210.c >> @@ -310,6 +310,8 @@ STATIC s32 e1000_write_nvm_srwr(struct e1000_hw *hw, u16 offset, u16 words, >> } >> >> for (i = 0; i < words; i++) { >> + ret_val = E1000_ERR_NVM; > > Should be "-E1000_ERR_NVM" as the below used: > Hi, fixed in v2, thanks. > if ((offset >= nvm->word_size) || (words > (nvm->word_size - offset)) || > (words == 0)) { > DEBUGOUT("nvm parameter(s) out of bounds\n"); > ret_val = -E1000_ERR_NVM; <--- > goto out; > } > >> + >> eewr = ((offset + i) << E1000_NVM_RW_ADDR_SHIFT) | >> (data[i] << E1000_NVM_RW_REG_DATA) | >> E1000_NVM_RW_REG_START; >> -- >> 2.7.4 > > . >