From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BDE8A0524; Tue, 13 Apr 2021 18:55:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51D371611C6; Tue, 13 Apr 2021 18:55:45 +0200 (CEST) Received: from mail-109-mta28.mxroute.com (mail-109-mta28.mxroute.com [136.175.109.28]) by mails.dpdk.org (Postfix) with ESMTP id D9AEC1611C4 for ; Tue, 13 Apr 2021 18:55:42 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-109-mta28.mxroute.com (ZoneMTA) with ESMTPSA id 178cc28fd390004964.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 13 Apr 2021 16:55:41 +0000 X-Zone-Loop: 20bfeba4c11bb8fc0eff2c74ce7a0bcbe04a8c7a6629 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0h7ispaYQHw4ejmtJegGsw2EB+zBYcCjLCA90XeKW18=; b=QZxfkBThk4p4PkMu+cILS/JUG/ rNm096JpkOfM0OGMwYS97GRumpD82iv+LiHF2MFl/Cne3U63jbajEvO4ULuw0KB6G6fA6OAseKhdH EotSS2jz0EMnP5a95HXR/ySqac3p6tfjM2YvDsHt+AF1T9fCHHFJWSQcwp3m8QJoN6w643JthqzBz /NpY7SBZGmFcO1u5sq9Av36VZFEdi4lWg+1HO0S4naar+SvtWF+oz4CSg6Ork9utQDnEtc5pRinF9 0Yg2Q71/gMIZHm5tSsVesEcUXKUXHCF2fjOm1PImFQ6FhrY1a/qJJDY6yZJUrQcjTnzSueQk+9AIw /bxtsp6Q==; To: Thomas Monjalon , dev@dpdk.org Cc: david.marchand@redhat.com, Bruce Richardson , Andrew Rybchenko , Neil Horman References: <20210405193000.1113542-1-thomas@monjalon.net> <20210408164713.3455145-1-thomas@monjalon.net> <20210408164713.3455145-5-thomas@monjalon.net> From: "Kinsella, Ray" Message-ID: <65e1b6ec-4d56-df31-2272-fabed1c5dfb9@ashroe.eu> Date: Tue, 13 Apr 2021 17:55:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210408164713.3455145-5-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v7 4/4] log: add option argument help X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/04/2021 17:47, Thomas Monjalon wrote: > The option --log-level was not completely described in the usage text, > and it was difficult to guess the names of the log types and levels. > > A new value "help" is accepted after --log-level to give more details > about the syntax and listing the log types and levels. > > The array "levels" used for level name parsing is replaced with > a (modified) existing function which was used in rte_log_dump(). > > The new function rte_log_list_types() is exported in the API > for allowing an application to give this info to the user > if not exposing the EAL option --log-level. > The list of log types cannot include all drivers if not linked in the > application (shared object plugin case). > > Signed-off-by: Thomas Monjalon > Acked-by: Bruce Richardson > Acked-by: Andrew Rybchenko > --- > lib/librte_eal/common/eal_common_log.c | 54 ++++++++++++++++++++-- > lib/librte_eal/common/eal_common_options.c | 44 ++++++++++++------ > lib/librte_eal/common/eal_log.h | 5 ++ > lib/librte_eal/include/rte_log.h | 11 +++++ > lib/librte_eal/version.map | 1 + > 5 files changed, 97 insertions(+), 18 deletions(-) Acked-by: Ray Kinsella