From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0050.outbound.protection.outlook.com [104.47.41.50]) by dpdk.org (Postfix) with ESMTP id 884631B209 for ; Tue, 10 Oct 2017 11:07:12 +0200 (CEST) Received: from BN6PR03CA0085.namprd03.prod.outlook.com (10.164.122.151) by CY4PR03MB2694.namprd03.prod.outlook.com (10.173.43.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 10 Oct 2017 09:07:11 +0000 Received: from BN1AFFO11OLC002.protection.gbl (2a01:111:f400:7c10::188) by BN6PR03CA0085.outlook.office365.com (2603:10b6:405:6f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.56.11 via Frontend Transport; Tue, 10 Oct 2017 09:07:11 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11OLC002.mail.protection.outlook.com (10.58.53.73) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Tue, 10 Oct 2017 09:07:10 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9A977r4026832; Tue, 10 Oct 2017 02:07:08 -0700 To: Thomas Monjalon CC: , , References: <20171010070155.17412-1-shreyansh.jain@nxp.com> <2102754.igz1rhL23C@xps> From: Shreyansh Jain Message-ID: <65f378cb-2229-36d5-418a-1fedf9435cb0@nxp.com> Date: Tue, 10 Oct 2017 14:49:21 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <2102754.igz1rhL23C@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131521000311316846; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(376002)(346002)(39380400002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(377454003)(199003)(189002)(24454002)(64126003)(53936002)(58126008)(8936002)(50466002)(76176999)(106466001)(105606002)(305945005)(8676002)(316002)(81156014)(81166006)(54356999)(31686004)(83506001)(230700001)(65956001)(68736007)(356003)(54906003)(498600001)(77096006)(2906002)(104016004)(69596002)(229853002)(5660300001)(2950100002)(6916009)(65826007)(6666003)(85426001)(6246003)(189998001)(33646002)(23676002)(65806001)(86362001)(31696002)(47776003)(8656003)(97736004)(4326008)(50986999)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2694; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11OLC002; 1:SapOWAR8JJin3+Um4eCDFbWPbSrYzno2VqT03O/3wsa0a+OVFaLEr2QHbsPd+tJ6mATGyd7tkOd4UHHAqSE5a14cbloevQ7pzL5CDNiNNDqCv949OmBjoRqv05YiwFgE X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 868c80dd-5a91-4780-000f-08d50fbe4a84 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY4PR03MB2694; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694; 3:B1SXIRpKK1oihze+J8YaTxUWMPYD3Evc9CsF7SFu0pf8BFcm+/nb2hNq6qHqKqyd/1JdqN9zr2wQEmGM1PC8Rl8m0yz2DHgAwqTbjtKuh49sb1Am1qTjbNMm0rOxBfFQCW7xKbB69vq0OzbGQ4jW7Y7U5+Sqt1lGBJ+sgWXkLiP3cZk89i3+P8s71PdA3wsNzymD+T9XYuO2kZ0/QahGVgZCDp60Z2GtE57NSUuOboe9qSr8VZO+lZmQa4zrpJl3/cepYitT9ZmyTdeGOtEowoqL9DKHiiqEKNPaxkoBZYRZ0ah5ZGa+71Mje2WfUVyuVODHXNRsn6VetYjdewWFXajWPBCBJj0sONEmjMojYdw=; 25:9iYQN0bSxUXctrqQA51AkTLHgargdCt/jUl/aTGuQwsKqomHSCf3mJNvJ+uF8JkF6qM8iM5dZufLaLrGVxYFgzbUwC6vW3QDr0Bp/H/oy6HK9w3sFLrgbTCXQ0mXixidQUOCVDS2IAEb8N/tuyy6Z2S5n751yk4ukXzy5aEWmlusqYxKvCKeYzlMXjIwvCtL7AwmkoCZQ23GKFb759MW6683qTRFlZvpGZdDYmR5nmtj3p4eOqxz/17IY3f12KMM6WPVaazJRLKsbhhTslR2IprvNBRxfJzej/UZMW7J52HsLgq/76aVB9BbfectZpb3Dtx7aXhTBjjBmVaauQC+Cw== X-MS-TrafficTypeDiagnostic: CY4PR03MB2694: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694; 31:CosJAP23tkr8ykY9nI7wzZdWaV2kk7KvGR9uGNQonNTvj5hOgr7jOwFVA13uN+WeLnIcQcnxnv7vK65U9j33fWaJ5lgpaMxZVYxq/lHR3F+r+aaR+cHJ7RF6BP7DtjnyxB4YU/REHJncv1Zrg8L3qHL/NqGlgyMLsoZnxNwenHKuad9p88GlOU5U6hVjc014zehXgok4RLoLjsQA/Rfti4Gb60+Hg4KLih3rg7ZI4pQ=; 4:G2H5L6WlSqwr7Oo+ruGRvyX1GDqlvxxEU5AgusLrzuF6Ca2KPvMK1Z+Y9FuVUKdMJ+iHNPHdCzMYJP1T3eiqrmvOMuFp2+zLD75BvxPE5s2EltJMzDCGWT55y8KuwUt2X2t091eLttb1fOVUT5Zv5PIuFtOCAJgY7U4cY2vWZEt5dCmodkyDBvFR+geifXblviNt4OeapRr/XEpnrIntw0dW9JRN80Js+L/h3hUSXhIA08F+Md5aBEAiQUxIZmM9UbzXD/qGJ2n4IRT/RCloOZ58Pms/N4beBxTtr1lZvII= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6096035)(20161123559100)(20161123561025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123556025)(20161123565025)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR03MB2694; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR03MB2694; X-Forefront-PRVS: 04569283F9 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIyNjk0OzIzOmYrUjlpbk1ldGd0SWtWQkliaDUvZ3Q1UFlG?= =?utf-8?B?YmdJZzBxcmNUQWxRV0JNS2FqREs1TzkwOGREUEtsV003Q3pZY0V5cC9pTGMx?= =?utf-8?B?OU1oR2Y3S0V3MzJ0WGJsc2lRUWlNZlR6dEZMYzU1a2lMb0FHUVJycUV6QXN4?= =?utf-8?B?OXMzMmEyLzFDbG5rZkljaXcydGJkMHM3Y2pLQ09NWWxDS3NWL0RwZTcxdnlw?= =?utf-8?B?YjBSZ0E3MEVtVngxdjAzRStOeVllQmtpSGZGbWIvWTZYbTNacnlhTTVSYkdQ?= =?utf-8?B?SzlwQ0M3MHJydlU1RVFoTGVJQXpjVk96T1hrajJmazE3TTB5MjJYZWZhZFdl?= =?utf-8?B?cWh2SDcwbFJXTFZXOTluVy83REg4QXo0UnVLU21tUEpZZEJ6VFprKzU0c3p1?= =?utf-8?B?UTVyZ2Fnd1F2bUlyUWtOL2F5NXh3WDNxTU82MWVITGF6Y1gvbk5heDJZakpH?= =?utf-8?B?WkMrOWNDalYxTGJ4U1pZazlQTUtwN1RCSXNvUmFmUGVYNTlhdWthQXhGdGQz?= =?utf-8?B?ak9JU0xsU1RENWhlVUdSNElWbzM1ZlE4cFZ3QXZEWkMvTGswcGtxd2ZJMnB6?= =?utf-8?B?RVBISG1SdHpkVk11bVRYOGd4VmRxMnp0REJmRWZlQlRqTkpUdk9vMkw4Wk4x?= =?utf-8?B?RTIxNHJ3Tk9hK0NSSXFCQS94ZVVJR1ZCdk9qWllxZjhZVCtOTlNJLzVmcC82?= =?utf-8?B?U0RwY0NGNXFiN0JHWm1VUExuNk9YTnRCSUdieW9obzIxajJacnFMakgwOSsz?= =?utf-8?B?ZitNYVF0WVBMNHB4K0dGMExZTHhhTVJLVjBqdzFxREI4TGk2RUUvdGpCcEI2?= =?utf-8?B?RHZXdTFzMEpyNFFoVlNvOHBVTUZxY0NGMm15c3JUZUlLYk1VeEdhQUswcE5u?= =?utf-8?B?UTNwZWhpTlhBSGdwNzRWeUU4LzdKU1lPNUdjZTdMM0laaEwxWjJzWkhMenNS?= =?utf-8?B?NHo0SFlmUnh3L1ltZzN6ODJRQm5Vcnd2MW5lOXRVaGxxbVdXTEg3SXZ3Sm56?= =?utf-8?B?cExvald2ZmdlQW5MMC82K0FkS253SGJSOXZTdTczUityeS9LVDRkbGVvL2Rn?= =?utf-8?B?c3B6N3RMVjBUUjB1K3NSMXdFUk1EL2FiMHhaKzNyMHJlNW9vVFJ5b3lKWmxU?= =?utf-8?B?SWQ0dFd2YmZZSmg1VzJaTFhtTlRUUTdVdDFWdVlrL2ZnbnRGTUpHUlZBeTRt?= =?utf-8?B?RGVGcFNWUm00andRck55SEdpQWVoNmhndFlhRmNod2RRKzVyZ3l2ZHBYN0RX?= =?utf-8?B?N2tCcXdFSU1JaTNaRlUvQ2FOcEYvb0ZpQ0lzdkRIaVZjYXgwQXovck1KRE1i?= =?utf-8?B?UDk0N25NVjZiU0ViazdhODI5TWg5Z1V0UWw2eDd5ZWdDMGR3MHpVd0lqQ2Na?= =?utf-8?B?MTVRS0lTaWM3NW9ldmVxM0JHeWNQQjl3cUZyUnVaanhpN3dMRDBhbEF6ZkRt?= =?utf-8?B?aFdZQTY0bkdnT0FrK0RKWFBFaXBadFh5NjZVMUs3WGNKaGNRY3FOSjM0ZEh6?= =?utf-8?B?eU4yeURtRzJSY3J5WTRCdkVKRWZxMWdTbVdYeGVlQzlnR2IzcWlVRnRzSWxR?= =?utf-8?B?QTduM2UvT2lqRUdlNjU3SWE4TUc5Zk02V1M0S2l0VDdkam9teHRwYUlnd1Bi?= =?utf-8?B?anFyVG44YnZpMDB0aTRrdHNyYzlQMHc4dXNjWU43VWRHNW90aWZVTzNOT3Az?= =?utf-8?B?UGNPek50ekVrTTBaSDJySVJmN3Z4YVBObWFWWkNpNlBoMk04TGxlUmpvQ09D?= =?utf-8?B?ZjQ0NnpSa2Z4V1pvMUwyeEJ4a0ptMmthdmhTNklZemVYWVhnelN3UnlJemxQ?= =?utf-8?B?cXhDMWpSMXk1L0JJYjU3em9pNk5scnFiQnZqMHgzaWtmSzgvcHlCVUl5Qy9F?= =?utf-8?B?RURGZjZxMXZDTTJsMGRyaVdoMEZpY3I0d2MrbDRHeWhhMEdLM1QyMjVNSitY?= =?utf-8?B?QkwycTVqemV3PT0=?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694; 6:bF6miIvJZeg88DK7NphyLnXg87c0KItXOvUkTPJ2ThbBWFcPMpERdtl3VjtHY0MJBhjOUC+HrsDyyBhCRxCetkx+pY2UnQRQY2flJZbmTb/B3DilV9GPxExUXyG8I2WTLwy4cSL5zlmr6eTP1sBQWJX0zbe0W7t+mrNqff81uc5uaKJB1hm308TrLaAlY9LNBMQopyjCzqpCfWObaZHy95yNfF83HAtZIRiPmFkEUGtnxd0tgOUV6Sgb+8+RmPHuLvRsChgyWPAxIXPvJ/c29TqiuIN9t8x0yzSm22lSYIH+lPrlUfEK0fERuPL+lIBnpEmnChoqdd+YSrpZbqPBng==; 5:Mx7ky5/r2G2nPNGIgwqsdrj2VzjCVYlhTVGuS6mn2WZ1t+OA4shC3kYyRZDs6IhztnmvgKc7o9f+TMHxzmFlSv5/CCI96vC3nsrL6mgR/Wg4NYwntNBjz6RSJzVyvHFfyr1xSjoEGnbI28NUXUA7mQ==; 24:2C6cJDfSWzDvq6S50TED6hMk+GNKodi+g5FOXus6j66YCIVHR/NHTKmKo0hCZMVvl2Ytnr078L7xBOt+2TG2/xUEkXsVu3HHaH3RQJzg6F8=; 7:2kYEaHmssgVlnL+3VbBynnfpTWozvAvMVAnFEXFFIa/jm0ugCy0JXWs/FjdxSGvQOZV35nHcDfokjLsQIyb53TSI4sUCtyE3/gwgNaHZ/sl39OdCP0kySHFnd6uiRDQWM5uvG6hDsabyrzkXsR3m1kTeogIYbfsWPUMZjBZiw2XmTxkCXjKET+2lhnF7W6TulZC32T8DIXYZqzS9UEyesGkErDiEv8RpK2r2kCeFvfw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2017 09:07:10.8664 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2694 Subject: Re: [dpdk-dev] [PATCH] bus/dpaa: fix memory allocation during bus scan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 09:07:13 -0000 On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote: > 10/10/2017 09:01, Shreyansh Jain: >> Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") >> Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") > > These lines should appear after the explanation. Ok. That I missed - I will fix and send updated patch. > >> Cc: shreyansh.jain@nxp.com >> >> With the IOVA auto detection changes, bus scan is performed before >> memory initialization. DPAA bus scan must not use rte_malloc in >> its path. > > If the scan has been broken by IOVA detection, you should reference > IOVA in Fixes line, not DPAA. I was of two minds before sending this patch with above Fixes lines: This change is because of IOVA but at the time IOVA patch was introduced, this bus was not part of master. So, ideally, in the net-next itself the integration should have been with fixed code - but, I ended up verifying base patches without IOVA patches (some earlier snapshot of net-next). Anyways, I will send another patch with IOVA as fix line.