* [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error
@ 2020-11-23 7:05 Murphy Yang
2020-11-23 8:30 ` Xie, WeiX
2024-03-29 8:26 ` David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: Murphy Yang @ 2020-11-23 7:05 UTC (permalink / raw)
To: dev; +Cc: qiming.yang, qi.z.zhang, stevex.yang, Murphy Yang
If enable hardware outer UDP TX offload checksum, it doesn't take effect
when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum.
In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT'
equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware
can calculate the outer tunneling UDP checksum.
Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel")
Signed-off-by: Murphy Yang <murphyx.yang@intel.com>
---
drivers/net/ice/ice_rxtx.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 5fbd68eafc..9769e216bf 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags,
*cd_tunneling |= (tx_offload.l2_len >> 1) <<
ICE_TXD_CTX_QW0_NATLEN_S;
- if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) &&
- (ol_flags & PKT_TX_OUTER_IP_CKSUM) &&
+ /**
+ * Calculate the tunneling UDP checksum.
+ * Shall be set only if L4TUNT = 01b and EIPT is not zero
+ */
+ if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&
(*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING))
*cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error 2020-11-23 7:05 [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error Murphy Yang @ 2020-11-23 8:30 ` Xie, WeiX 2020-12-11 2:08 ` Zhang, Qi Z 2024-03-29 8:26 ` David Marchand 1 sibling, 1 reply; 4+ messages in thread From: Xie, WeiX @ 2020-11-23 8:30 UTC (permalink / raw) To: Yang, MurphyX, dev; +Cc: Yang, Qiming, Zhang, Qi Z, Yang, SteveX, Yang, MurphyX Tested-by: Xie,WeiX < weix.xie@intel.com> Regards, Xie Wei > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Murphy Yang > Sent: Monday, November 23, 2020 3:05 PM > To: dev@dpdk.org > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yang, > MurphyX <murphyx.yang@intel.com> > Subject: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum > error > > If enable hardware outer UDP TX offload checksum, it doesn't take effect > when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum. > > In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' > equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware can > calculate the outer tunneling UDP checksum. > > Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel") > > Signed-off-by: Murphy Yang <murphyx.yang@intel.com> > --- > drivers/net/ice/ice_rxtx.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index > 5fbd68eafc..9769e216bf 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags, > *cd_tunneling |= (tx_offload.l2_len >> 1) << > ICE_TXD_CTX_QW0_NATLEN_S; > > - if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) && > - (ol_flags & PKT_TX_OUTER_IP_CKSUM) && > + /** > + * Calculate the tunneling UDP checksum. > + * Shall be set only if L4TUNT = 01b and EIPT is not zero > + */ > + if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) && > (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING)) > *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M; } > -- > 2.17.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error 2020-11-23 8:30 ` Xie, WeiX @ 2020-12-11 2:08 ` Zhang, Qi Z 0 siblings, 0 replies; 4+ messages in thread From: Zhang, Qi Z @ 2020-12-11 2:08 UTC (permalink / raw) To: Xie, WeiX, Yang, MurphyX, dev; +Cc: Yang, Qiming, Yang, SteveX, Yang, MurphyX > -----Original Message----- > From: Xie, WeiX <weix.xie@intel.com> > Sent: Monday, November 23, 2020 4:31 PM > To: Yang, MurphyX <murphyx.yang@intel.com>; dev@dpdk.org > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; > Yang, SteveX <stevex.yang@intel.com>; Yang, MurphyX > <murphyx.yang@intel.com> > Subject: RE: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum > error > > Tested-by: Xie,WeiX < weix.xie@intel.com> > > Regards, > Xie Wei > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Murphy Yang > > Sent: Monday, November 23, 2020 3:05 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z > > <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yang, > > MurphyX <murphyx.yang@intel.com> > > Subject: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum > > error > > > > If enable hardware outer UDP TX offload checksum, it doesn't take > > effect when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum. > > > > In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' > > equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the > > hardware can calculate the outer tunneling UDP checksum. > > > > Fixes: bd70c451532c ("net/ice: support Tx checksum offload for > > tunnel") > > > > Signed-off-by: Murphy Yang <murphyx.yang@intel.com> Acked-by: Qi Zhang <qi.z.zhang@intel.com> Applied to dpdk-next-net-intel. Thanks Qi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error 2020-11-23 7:05 [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error Murphy Yang 2020-11-23 8:30 ` Xie, WeiX @ 2024-03-29 8:26 ` David Marchand 1 sibling, 0 replies; 4+ messages in thread From: David Marchand @ 2024-03-29 8:26 UTC (permalink / raw) To: Bruce Richardson Cc: dev, qiming.yang, qi.z.zhang, stevex.yang, Murphy Yang, Vladimir Medvedkin, Mcnamara, John Hello, On Mon, Nov 23, 2020 at 8:08 AM Murphy Yang <murphyx.yang@intel.com> wrote: > > If enable hardware outer UDP TX offload checksum, it doesn't take effect > when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum. > > In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' > equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware > can calculate the outer tunneling UDP checksum. > > Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel") > > Signed-off-by: Murphy Yang <murphyx.yang@intel.com> > --- > drivers/net/ice/ice_rxtx.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c > index 5fbd68eafc..9769e216bf 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags, > *cd_tunneling |= (tx_offload.l2_len >> 1) << > ICE_TXD_CTX_QW0_NATLEN_S; > > - if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) && > - (ol_flags & PKT_TX_OUTER_IP_CKSUM) && > + /** > + * Calculate the tunneling UDP checksum. > + * Shall be set only if L4TUNT = 01b and EIPT is not zero > + */ > + if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) && drivers/net/ice/base/ice_lan_tx_rx.h: ICE_TX_CTX_EIPT_NONE = 0x0, So this check above is always true... I suspect the intent was: if ((*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) != ICE_TX_CTX_EIPT_NONE) > (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING)) > *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M; > } > -- > 2.17.1 > -- David Marchand ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-29 8:26 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-23 7:05 [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error Murphy Yang 2020-11-23 8:30 ` Xie, WeiX 2020-12-11 2:08 ` Zhang, Qi Z 2024-03-29 8:26 ` David Marchand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).