From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id EFA034550C;
Thu, 27 Jun 2024 17:08:56 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id DE68D42D89;
Thu, 27 Jun 2024 17:08:56 +0200 (CEST)
Received: from fhigh4-smtp.messagingengine.com
(fhigh4-smtp.messagingengine.com [103.168.172.155])
by mails.dpdk.org (Postfix) with ESMTP id 3E72042DA7
for <dev@dpdk.org>; Thu, 27 Jun 2024 17:08:55 +0200 (CEST)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
by mailfhigh.nyi.internal (Postfix) with ESMTP id C5AFE114010D;
Thu, 27 Jun 2024 11:08:54 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute6.internal (MEProxy); Thu, 27 Jun 2024 11:08:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to; s=fm2; t=1719500934;
x=1719587334; bh=s7Sv6DsBx6aOIy5h8BwxSr5TwSnVXiUd+MsjQRmhNas=; b=
im9lq35jVMExwL9oj/KeKHT78sGQ8Lub7vZ3aEq/oKSRhgWOSIGD397i3qKOlCIL
0w+Zk+EcixVvPXw2RUZWmQHk7jnGw4LQUWw5VVGZEUgjJzfBHIfU6qelFiXJ+hRs
vBsYDOuMzT+j6StIxLAhUlVBGuUOVi60yqogO581WC25Q5FR+v7QDdBrPWQGQeWB
fTVZZgBN0VXKsrm/1L1hPRN83yQV0r4qiIFshOpqNPL4XsLe7yVWr2QagP6Sh7cn
2kU82dRBlH/kFgaLa2W+WadBvRpuF+09D3/eLEKLFBkjs+C5ZWdOpybLOVHPsfsA
vhugsgXmISbaoVbJd9zoTA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1719500934; x=
1719587334; bh=s7Sv6DsBx6aOIy5h8BwxSr5TwSnVXiUd+MsjQRmhNas=; b=G
kza2MoDD7JrSzvG6so7U34Q+ouMBp9w7B/ZMwspOi5iRPxw9sCzJeAPAl1NWI5QM
PprLGyK4b82uGaTv8bFJpRN6Rz2xp6d/w6xUNmAWNWkHG8MSCUnSgW+9S2NEbAMn
RkBbn4GGRGyjCRNzyZQysGsh+6LacuH8IwK6yVIO+A+HOEIEthSDyk99rlOYiu6u
FMT0cmkBP4LJ8DZ7rCimGwMVfDnGyl/Oe7NQQW55XFb2vwI2FrF7e5XiH2hebx7g
87ZfIj+UlZ+cYxXq/UoE3yJDSFoRh+CgOeYM1lyDJSQ/x2UtJVe8ibAJhgsDadcp
K/Ep7bt0blRBFQObK/+kg==
X-ME-Sender: <xms:hoB9Zg5K5jGSOs7DwG7V0uXDmFs17huz_3GJoLKvq_AYjFHORY89GQ>
<xme:hoB9Zh44dNah3eTE34yR21WuAMsVI284PPcBInLMV0oIJF8vG7_1M-NOdoCxEpZp_
Y4_WNfVp1O8dnWNbg>
X-ME-Received: <xmr:hoB9Zvcw73Cq3s6fl3ZbBc86_c-8HTZgxKn9K21i8m_lMS-j0PhhJSM24e-dKiVKBZP38y96W7onyyEOB9rJ1xkuqg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdeggdekhecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu
vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:hoB9ZlIvbZZeUJXdiVzmzD_-j2JGNI1sBSeh3CTFu9cSBsd8Q4Q3lQ>
<xmx:hoB9ZkKW3BxgDO1jruWlkkbC5PLXm2kh94R530fNyaXW86-LJXJKDw>
<xmx:hoB9ZmziqbqFzvCWwMvREV1iCEzXS9I7fD9kEDcJ8QvwK_8Az74WBw>
<xmx:hoB9ZoIB8PEXeANTpHCF3dcYtYhSsiFwTbCLMEez7ehGOffuzzPiOg>
<xmx:hoB9Zj9FuJI7DIPisDZtMOo1nmFkCrvvdsPsiyOcX8oN_XpPHh7HzuPL>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
27 Jun 2024 11:08:52 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Daniel Gregory <daniel.gregory@bytedance.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>, dev@dpdk.org,
Punit Agrawal <punit.agrawal@bytedance.com>,
Liang Ma <liangma@bytedance.com>, feifei.wang2@arm.com,
Stephen Hemminger <stephen@networkplumber.org>, david.marchand@redhat.com
Subject: Re: [PATCH v2] eal/arm: replace RTE_BUILD_BUG on non-constant
Date: Thu, 27 Jun 2024 17:08:51 +0200
Message-ID: <6615976.zIJbB62Pao@thomas>
In-Reply-To: <20240503175905.28c590cf@hermes.local>
References: <20240502142116.63760-1-daniel.gregory@bytedance.com>
<20240503182730.31693-1-daniel.gregory@bytedance.com>
<20240503175905.28c590cf@hermes.local>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
04/05/2024 02:59, Stephen Hemminger:
> On Fri, 3 May 2024 19:27:30 +0100
> Daniel Gregory <daniel.gregory@bytedance.com> wrote:
>=20
> > The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check
> > memorder, which is not constant. This causes compile errors when it is
> > enabled with RTE_ARM_USE_WFE. eg.
> >=20
> > ../lib/eal/arm/include/rte_pause_64.h: In function =E2=80=98rte_wait_un=
til_equal_16=E2=80=99:
> > ../lib/eal/include/rte_common.h:530:56: error: expression in static ass=
ertion is not constant
> > 530 | #define RTE_BUILD_BUG_ON(condition) do { static_assert(!(condit=
ion), #condition); } while (0)
> > | ^~~~~~~~=
~~~~
> > ../lib/eal/arm/include/rte_pause_64.h:156:9: note: in expansion of macr=
o =E2=80=98RTE_BUILD_BUG_ON=E2=80=99
> > 156 | RTE_BUILD_BUG_ON(memorder !=3D rte_memory_order_acquire=
&&
> > | ^~~~~~~~~~~~~~~~
> >=20
> > Fix the compile errors by replacing the check with an assert, like in
> > the generic implementation (lib/eal/include/generic/rte_pause.h).
>=20
> No, don't hide the problem.
>=20
> What code is calling these. Looks like a real bug. Could be behind layers=
of wrappers.
I support Stephen's opinion.
Please look for the real issue.