From: Yongseok Koh <yskoh@mellanox.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: fix permissions when using make install
Date: Thu, 9 Aug 2018 17:38:08 +0000 [thread overview]
Message-ID: <661CFF7D-1DA5-48E0-B18F-6A5B8EDE04C1@mellanox.com> (raw)
In-Reply-To: <20180809152235.45376-1-bruce.richardson@intel.com>
> On Aug 9, 2018, at 8:22 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> When using make install, the permissions of the resulting file should be
> those of the user using make install, not those of the user who ran the
> build. This would not be the case when a user explicitly runs:
>
> "make && sudo make install"
>
> Fix this by changing "cp -a", which preserves all attributes, to
> "cp -dR --preserve=timestamp", and by adding the flags
> "--no-same-owner --no-same-permissions" to the calls to tar.
>
> Fixes: 1fa0fd9d6b42 ("mk: allow to specify DESTDIR in build rule")
> Fixes: 6b62a72a70d0 ("mk: install a standard cutomizable tree")
> Fixes: 576de42b83e5 ("doc: render and install man pages")
>
> CC: stable@dpdk.org
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Applied to stable/17.11.
Thanks,
Yongseok
prev parent reply other threads:[~2018-08-09 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 15:22 Bruce Richardson
2018-08-09 16:16 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-08-09 17:10 ` Ferruh Yigit
2018-08-09 17:38 ` Yongseok Koh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661CFF7D-1DA5-48E0-B18F-6A5B8EDE04C1@mellanox.com \
--to=yskoh@mellanox.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).