From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73D2DA0C41; Thu, 16 Sep 2021 11:00:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED1304069E; Thu, 16 Sep 2021 11:00:21 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00066.outbound.protection.outlook.com [40.107.0.66]) by mails.dpdk.org (Postfix) with ESMTP id C6D074003F for ; Thu, 16 Sep 2021 11:00:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9R97XA/7vFxQaJXUMw8sDhxkPALGz4erdXCzPv5xjThU+5mirGlDNZw6UywIc5oje4V8OWU3yWquzyD5MT7cl4A0VAdvv4JFiqUDG8TB4NtJARI4s0pdCy0uXGsu8FmOljHuHUawHEHeNTIQy4XqsKHsi7b5jw861BMaptKAO1LnhRVmBgQA+psNcnPUS9FXq9jWNKoiGxdcj/wlL0YeFERJD5eVb25nNwKq7mFjesqx0CAbsHjACUwDIYVMO3RUb2+pdrTDjpIIVOIxFFd0JOeFA8BEnSjUhp4GVMerBfBkCgQoWQ8u9IROVZBjh5B3ZRN52GN/PN8fhuSu6Mv+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EA5d8BFPMXE8iJ2vQ/7kAzqovRUNjHLF1g7m5YOEjGk=; b=WQd82vcWlzY4UjAvR3REwOksbUpsR3s3HuahHHFqWrRjKpBVMO7w9EX/2sC3lGmwbsxZiTsPNMS2mHapoQaeWWpUre+AjhNE/W5sK1Q/JO4/MolkH1X858aJuFeObz597O+mBRNN0y58zt3oSlwNz6HQW5C3Fng9aQ9oyJSGJ8fi8jl0UuTMlBXav0oq+T5Uh44s2gEq8ou4Ny43HqpWXXlaRunGxuEETokukjJq/Av728eYgAq445kc3MVlb8JSPMuzJPK4TEAIjLxWEa+6qGrhPsETMt/D962TL0mVn1AJx7nOdvbm0qxU6nx7ITR/fPZ32AUKrGPjyEgVXTm3dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EA5d8BFPMXE8iJ2vQ/7kAzqovRUNjHLF1g7m5YOEjGk=; b=btgQ6AwaDhj/pXCei+ONHsKiMVLpPSvHspXCO9RZW7E/ZxZZQYCvHV7+Gz+xU3FEEWSoEzOlFkEMqfhmDO8sMVIMqLZynxZVs1nH2ogoESy+UgwANKmjXDUVnyatOtbKtcatmnGWqOuftx2oWtJZ20AhuYo527dvS20TvMbtvWo= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB8630.eurprd04.prod.outlook.com (2603:10a6:10:2dd::15) by DU2PR04MB8887.eurprd04.prod.outlook.com (2603:10a6:10:2e2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Thu, 16 Sep 2021 09:00:18 +0000 Received: from DU2PR04MB8630.eurprd04.prod.outlook.com ([fe80::945d:e362:712d:1b80]) by DU2PR04MB8630.eurprd04.prod.outlook.com ([fe80::945d:e362:712d:1b80%3]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 09:00:17 +0000 To: Ferruh Yigit , Hemant Agrawal Cc: Jiawen Wu , dev@dpdk.org, Bruce Richardson , Thomas Monjalon , David Marchand , Akhil Goyal References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-29-jiawenwu@trustnetic.com> From: Hemant Agrawal Message-ID: <6624b581-e094-f704-be3d-745a04f9a771@oss.nxp.com> Date: Thu, 16 Sep 2021 14:30:08 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: MA1PR01CA0183.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:d::6) To DU2PR04MB8630.eurprd04.prod.outlook.com (2603:10a6:10:2dd::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.5] (122.161.79.209) by MA1PR01CA0183.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 09:00:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d890cdc6-0207-46d0-7cca-08d978f0678a X-MS-TrafficTypeDiagnostic: DU2PR04MB8887: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hPG+pxJdoWvjiu+N3mSzgLELpE7f/dbKxkbZrJRrLhQOVqoOHd7SJJGoIGYdp/gpHE/LLW982tci2YCDmhq2V5VaFHUL4LjTPO244wVFMjSW761Kf1GKIvPZYsI9mzG3T0y+v5y+oq7hNeYUxLB/7fGY7SUEimx94hcl7gi2UDOb+ldmY7ledkCM64O0nkzB/M5yaE41B9or3TKm1p/7ilEJPr69gwKffUA/IjghEdriiDueMk811NxgAXbJHO4uOXLJNcWktUwoANa38Ur/thc2gAzNDrNOpLxOdzljgt/B9pwQ7DFLHvd+ZCqclhNaB+N+Ei9IcQ/p/pU/FtEKZw8ug4cDK4nWVxFEYb/v/S6TStFZFB8dShScPSIFdS5SeOU1EBCBp83xSiigspsWbJHmOiQtGHyOzb1S37bvTkG+ofYTY8MDPJXbkW+MtZqWvPn1Dvf0+D39CZBowtjHrAyhMXuKewOnsGCLpRPgyDtqkAIzs8UeBIhav1yS5hmorH1eJPTEFxz5JWc8XsK2K4UpU5Ti+5BwOV8YoGSRitLy9wGI4MKGdRUxPhODPxFs0gblQaXMA5RrPfcwhxuHyjDMZouGjyrP8+Q+ECmsjb+iCUNBEh+GKHT8c8eXFtfHheKhF1DbfsT8Pikh3sGcAjQ1xlYjaeriR1Hluh04/Shkk3tfpBdFRqbMDjuVsAzStdu42RxmUHcP2QYakAy4qnh0zB2nORtaEG9y68IPDXvYTMrczY9TGVrdgr+0qjrAr6pc43bBxsAFZ/KaNHfl7Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8630.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(316002)(86362001)(6666004)(5660300002)(31696002)(4326008)(186003)(83380400001)(52116002)(31686004)(44832011)(6486002)(55236004)(8936002)(66476007)(956004)(66556008)(508600001)(110136005)(53546011)(2906002)(66946007)(2616005)(54906003)(16576012)(38350700002)(26005)(38100700002)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWpIUEdmcmxpRExWblNpMXYzN2dlVG1vWXZqNnhrdEpLUG1kOGhiK1ZwUFdh?= =?utf-8?B?b1BKNFZyK2RmRXRHQnZkeDBXWC9XTDhoYUtEeDEvb2o5WFBJVHoxbHB0L3VC?= =?utf-8?B?ZzdKSExBUHAvb1A4c3lSMzhJYlJIRFJyYXQ2OVhlOGwwOEg3WjIyakdFSXBq?= =?utf-8?B?RUFzanI5MDZXbHJLMXlURnpTR3lkNXkwSmI0dUtlMzZaYXZlUmIzTHU3QW9k?= =?utf-8?B?VCtwdTdsTHJHTWFka0t1bVpyOFVTNFdhY2RtRE5FNHUvdk40Zmg2SFd2T2Q5?= =?utf-8?B?VTIyTnRsUHZzQ2JLWVVJeXRCYUlzMmYzNncrMjY2cFQwYjUvS1NvNVIzb2hH?= =?utf-8?B?aTdrR2JhUmo3citJMS93TGgrZHJVS09VN3k4N044QThwRUVxSmIwOWxpd2U2?= =?utf-8?B?bkJaVGlkUFNJeGNkWEQ1YkRsR1pJR2FRcWFlMFBsTUI0V0VJUGhaQnBHSlhl?= =?utf-8?B?Q0tEanZ5NnZISUZiSVlWTGlpRjFNNS9EVlBHSUFQRFVlMnFFMjFwZko3UEdL?= =?utf-8?B?M3JCcFUwMWd2RlBGdzgrSDlHQkU4Y2lQaUt4NnZSSEl4U2NOdTlING15YlZn?= =?utf-8?B?dTJ3QklMZHBCeExvbWVGcEJmaWVhSVFyQVBSVW9TSjRZeHlvMVBiRk9oUUxR?= =?utf-8?B?c25ZNmxiU09yaDM2UVpLUTRYc1Y0UDljTFZFOHY0UWd3WkhxV1VhTFI5a0Z4?= =?utf-8?B?ODBEMWpaUGxXeEh5NWNiMThPeTFJc3JWeThCNEJDR040UXBIQjRjZmRwcHI1?= =?utf-8?B?akgvMGpLajFJbHV5dFFNdGNtejdEYlVCRU5NeXQwaTVVVVNnN29SSHhwM0tC?= =?utf-8?B?Z0w2bzFKdEZROEs3QU5idUhQbVovSkNKVGdvTGlHQjBPYzdvcnFORU9wK2hQ?= =?utf-8?B?MUh6aStmTk91bFRhcXRIckR2VFloSVdqeUFvMEE2NnVnNjRpdGdScG5ZVWNU?= =?utf-8?B?MWZmLytRdHF0bno4WTJMdUxOOGtJVUlOTHI5VGpobEwzQTRlbDNNQmd3MWZo?= =?utf-8?B?cVdmTHRvRFJiQ2ZYMXZ0QThNdW5ObHZhQWN2b0RYZUoxRUdYdGZ4VGtlZ3Y5?= =?utf-8?B?TUlzWExWenMwa2pRS1lnS0VsNDFvT2E1aVYwcEpNSEZuN0dHd1pXMm1rci9F?= =?utf-8?B?QVFnaXNwcGlOWUY0b2VxQ0VEZkxLRkx0M2x3RUhSNTJmMkhuOFVMdFduQmVi?= =?utf-8?B?MUJCQlJmOWlJZjlBOFoxOGExV2pEQU82dmdKa2RoNE43N2FETUlvQno3OC9P?= =?utf-8?B?NjduVnVNbVgvTmlxTU5qSUlkSUJsdnY2dlhQRHJNc0FXRFFYOVNDSDlZdzJl?= =?utf-8?B?cFROdGtIRWN4dW4vYTlhOTYvMjNSV1NDSWozUk5VTXJIQ2kzQVlnckplMEs0?= =?utf-8?B?aE9KK0pSaWRuajhPRjhJNWp3MEJvWHBvVDRxaTRtLzRzVlhDTDFwUElHbTFI?= =?utf-8?B?K25wYnc1eUV1bmMwei9WaU12ZUNCdEFvZmM0dGJBQ2RLSGFCaTR1VjZOTDZw?= =?utf-8?B?cXN5cHpORlZVRXNvdFFiTTVtOWhVdmNzaTY1WFZtTitHMjllbUU4VkltT0RH?= =?utf-8?B?OW9sUDV2RXB6aG1pNkN4aG9aYkpnbDZFdXJ4bDNoMjdGYXMyUi80b3g1YlQ3?= =?utf-8?B?SW1zTFVSV2Q1V3Q0bi81aUlkMWtxcU43cjRKcGNnNksvbUR4Z00xU25WYTZs?= =?utf-8?B?MzFLcWhScXRld1pPYXRMMGpXaWIydThGb2RxMFdJeTdoVUgvS1hXRFQ0MlZN?= =?utf-8?Q?ZSvw5IhmpbhxXVvlPS52Js1Af5Y0F15rwd8JEPO?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d890cdc6-0207-46d0-7cca-08d978f0678a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8630.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 09:00:17.8908 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c1SEfLmuy78sQCoxsuWdUYWrqV1KxEzlf5CCsM0q0X28rbXNZ5Lo76nut/+gW/2osWN7k085dEzATRTqh6b5cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8887 Subject: Re: [dpdk-dev] [PATCH 28/32] net/ngbe: add IPsec context creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hemant.agrawal@nxp.com Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/15/2021 10:28 PM, Ferruh Yigit wrote: > On 9/8/2021 9:37 AM, Jiawen Wu wrote: >> Initialize securiry context, and support to get security >> capabilities. >> >> Signed-off-by: Jiawen Wu > <...> > >> --- a/drivers/net/ngbe/ngbe_ethdev.c >> +++ b/drivers/net/ngbe/ngbe_ethdev.c >> @@ -430,6 +430,12 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) >> /* Unlock any pending hardware semaphore */ >> ngbe_swfw_lock_reset(hw); >> >> +#ifdef RTE_LIB_SECURITY >> + /* Initialize security_ctx only for primary process*/ >> + if (ngbe_ipsec_ctx_create(eth_dev)) >> + return -ENOMEM; >> +#endif > Hi Hemant, > > I see 'RTE_LIB_SECURITY' is still used in some PMDs, as this new PMD also uses it? > Previously I assume this macro was to mark that security library is enabled, is > this macro still valid? Who should set this macro now? > > Also can you please help reviewing this and next a few patches since they are > related to the security? Hi Ferruh,      It indicate if the driver is using SECURITY library functions. In Ethernet driver, it typically means the inline security offload. Ok, I will try to review. regards, Hemant >