From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D838BA0542; Tue, 4 Oct 2022 19:49:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C579240DFB; Tue, 4 Oct 2022 19:49:07 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2049.outbound.protection.outlook.com [40.107.223.49]) by mails.dpdk.org (Postfix) with ESMTP id BA5ED40DDC for ; Tue, 4 Oct 2022 19:49:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AtZrKewraryzA+fITIxPPY49u6CIlGqt3FRDciN6r6SvJ/gvacE0xY5uWyZWbOhbfxloERymCFlqKMUMnhVar10cGPf8fQCeErKGjc6ze0EuwQ/BzbpJpdB1lHjYGoQ8g9uMtbOlpm/hG3oSbJJRLeAoDPkC1VjwPEnOOC9Z+MPyfU2gevQJRnv+0y5t/MhVgLvzdigpfcM1JSIx3pnNd8BWjLMVEuE4hAaBtxMa7qu9PwBlQgTU5VB7Eizy+FgUR4wLg7KgS1jX+RmnzoaYKtfLkUPFz3lzjymmHT5PvS8YVLfs/3PNDSr9cjgf4rMO5uZaB7Av+ehS8TxleYJKhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5j8UI6WCwmL4QN3iBr3FqsZHCTvU9tIOfI6awZleQ6o=; b=aGhlWOMgJ62kgBcMBR7BunAamDQmNnErU98c5CZFFF7EQ9l3k7clKhhE4n+o8pYQoZID5AdkNvE+nqc0A4EDrzju3qjBEyun6gRGUIJFmJvWRUfGVV5HsvUqM5CpdQCoCsfS5eMLfe8KKDNCha4xzd7KjFgDu+klR/7TIDF+oaQE/L74l7GDre9d3wZbAaZQL2zCL48kQicVkmFXkJj0H3PB002A3tBC5EEe5OMIxA5WioAAQAesSs5lDWWGuXCsoNezzcu/qN8fsEAL037BOO4MtpeOt+J17EkJB2fQ+0i679DFEnbkeQuVfA4BqGrkGtvE+H8FsHEjWhapPXiWMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5j8UI6WCwmL4QN3iBr3FqsZHCTvU9tIOfI6awZleQ6o=; b=T0UzZLbZH8LS79v2iQ1HE7wa9jl3DN5/ZwCIWKKi2sc3yvLmtk4DsfUkkLDmcpVQa5QVNO35e/6ZqyfTBJR71PCH07ZqfT242I0GMjQlIU2RMRdMCBgLoL37IbP/1z3qlryVkVN3xEU+ZZgMujdoLR7WEx/+AezAGYHnY/0RWhk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4468.namprd12.prod.outlook.com (2603:10b6:5:2ac::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct 2022 17:49:04 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022 17:49:04 +0000 Message-ID: <66305e2a-0099-a1c2-f168-fc850f8a9bbb@amd.com> Date: Tue, 4 Oct 2022 18:48:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [Patch v9 11/18] net/mana: implement the hardware layer operations Content-Language: en-US To: longli@microsoft.com Cc: dev@dpdk.org, Ajay Sharma , Stephen Hemminger References: <1662674189-29524-1-git-send-email-longli@linuxonhyperv.com> <1663987546-15982-1-git-send-email-longli@linuxonhyperv.com> <1663987546-15982-12-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit In-Reply-To: <1663987546-15982-12-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0180.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4468:EE_ X-MS-Office365-Filtering-Correlation-Id: 84e6b885-a357-4c5d-925f-08daa630ba3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GU0FTbwyR26rocPCviXjKOn6HhooHnbA2W1mGsC7tjoLRjEYmrv2gRdawXe7TYEJMpb4+rID+jkxsXcn1AyHi1SpM4qpUzQQItSoJ0yR79Vxu5do6/2Qas0WQ1S6AjX9hX3c5IrMoOeRTmfGaCfrjHiaWJBweerUr6wHk0Dnc7bcFOaTy7PFEGcgDLUB02l56tSPQv4nW/rhLb1SDDGVjYgVQ0gn4TYxl1fChdbCRD0Xuh/AI6/TXS9g6jYB97PkiZbRMxiYeSD4G/j6hYHbqXrLY4vF9sZNTdLyCo7BIItFQaYlaamcll4K3ufHeG7GdL3wgT/RI7CN0mfJTw5SMoQvVUojAouSOBnDlK0DYWX7f/Q13OmnAMq0kM7KVp9tbZ899nu+Bae3vuZftPi7zODGzHPqln1ahBlOoBl5S+IvXdzR6qKD8TXYCL6iVqS9bG4LuZCWhjQNnSgiibwEaztebIcGyO6kWXeH0s7mBUg/oQMT3WPZA8Yn3ojtLg9zlSa+Tu0Nz0yvG3+FKXOpFCDb3eX90om3zicBfVHRFrqBuhGaPEzvCYp8Vh2zDvhR0Vw1SNgKqNUaPazf59NaNtc6kWiduL3vr8podEdVq+ttIIpMJFz7CT5wQ8t95xeqRxlNN6l+AV1uzZcLcXnqJ1kiq+AWNICXTh6FCRtp1/0y57stV7Xkl71QGlHFx1ctkUMds+iPNZekYffPWd0R+2lLkr7nXAhzNh8tP5T+PN+k84atH/uXCCwigDDihfL4vKiCxOCNLqO/EZyNQLG4Qtpu/q01+xxe53+BCsLj7us= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(376002)(366004)(396003)(136003)(451199015)(66556008)(31686004)(66476007)(8676002)(36756003)(66946007)(2616005)(54906003)(186003)(6666004)(6512007)(38100700002)(26005)(53546011)(6506007)(478600001)(44832011)(316002)(6916009)(6486002)(8936002)(45080400002)(4326008)(5660300002)(41300700001)(2906002)(4744005)(86362001)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1Y2NGN6NksyWXpsb1U4UjNKOGVjMnBLb0pVc0Z6cEFLanJudVI5ano3czEw?= =?utf-8?B?Nmw0Uktpb29scHZSS2FEVXFrUyt2ZmIyOFFjNU8ybEdTTmtRSllnOXQ1Y0Zx?= =?utf-8?B?MUlXdDlVMjRCSHMyU0FIS3BsaDN1cDNpc2ZJdkxjS1VhbzcwNzRqUVhITStY?= =?utf-8?B?M2JnU0VYZjI5SElPZnVtSWZSMkFqaTVOb0p1bysyM0l0OE1kVVc2UUlrRnRz?= =?utf-8?B?dWY1ck41cEZEUnN0Rmp2RDV3K1ZnLzVRRGhjWmRLZmNHUmVzTWFKdUg0TG8v?= =?utf-8?B?YVRLb1dNRVlFYTBnRGpZT0V2enI5TTAxL0FQSm5CaEs3S2Z3LzJsRHk2bFRO?= =?utf-8?B?ZkJqbkZRd2xJK29ySDQrVm9xMEhDcnlkSU80bjhwbk93bDFubS9GZVlzZG9y?= =?utf-8?B?VHdMZitLcFVYUXlYMFZxOS96Rk1TVDlxVGJ3bjhHdUxQM0xyWVpEMHpGK3oz?= =?utf-8?B?T1U5TEVtM09DOWNDa2pyTzczcE9UZHNsNDRIdFpLMTZoUldsS1VET2l0bEN4?= =?utf-8?B?Mk1TUkd2N0dGNWVITlg2NGs1bmwyTHBEekZOK2RRcGZicnF1VHI0cGcxV3BL?= =?utf-8?B?K1VsRnhvcGZwZFpIRFFhMjU3UjZlVWZ2ZUVxRXhhOUI3YVZjandEdndlVGpI?= =?utf-8?B?MDgzSU16L2lGRldFZTVDaWVzTitvSjNZL0VVTmVSV2FHczJ3YkJ1cXp6RWRZ?= =?utf-8?B?RDdLM0h4clNndXVrc0VDL1pQNmlOZ2FJa2d0bUpxYUE3L0QxVlF5YmhObTRD?= =?utf-8?B?d0M0cVNLOUkrR0U2a3YrNUg4dGJSQ3JyWG94V3JacUhKMkVqN1cwTTVjcHZO?= =?utf-8?B?TUt3dlBiMTJ6UEZzaXo4L2wxOFIrNTBEU1pWSlNTTTRSRDA1aDM5Tm1yd1B4?= =?utf-8?B?eVI0VXFCVlR3OHlvaXR3dUR6TWUrWENZdWJkTi9Bcis4REJaajE0UW1kUVhp?= =?utf-8?B?ZCtjVkpJK2RrVzFFOGo0U2pzZXB0NU9qa053ZGVvUmppL3VBQUk2UGFtY0FX?= =?utf-8?B?azBaV2tweEFrTTd1Y2JMWHd1VjBWcDBOdVZSZG1jN3o2V0xpbStCS0I2a3pT?= =?utf-8?B?OVg1bEZWU09aTkpYTmptTlAyR0gwR1dYQ0d2NEFlZktrKzNYR1hhY3VHeWRn?= =?utf-8?B?NlpJQkd2S0JTeE15SE16VWVvOUpnU2EyaUZDMjNnTytnOVoyaWtaTU5xN1p2?= =?utf-8?B?S09HRlVaOGllVHlUSTNaTGRzS0FhTWdZSVkxYitFemExcW5zT01YMGJOc1pC?= =?utf-8?B?K2IzSXRlb3JZQWtCVkZVYjlDY1dLYmV3cC8wMGpEeHVJVTZtYlkrUWlSejV5?= =?utf-8?B?RHQzN2d1LzM5TldaaXhVanR5clRvcGduOFhxZVZRYjdpZ3A1Wk5ubHdKWUE2?= =?utf-8?B?SExvOTZ0dnh0aEFWdzBuQ3dtM01WREpORTVwbWFqL01VQk9tVTVCaE1FdVNW?= =?utf-8?B?Y2oxNW5HN3YrRmw5ZDFmNzNUekpabUtVWHJaSTNzU2xERVAzUlM1c0cvVEJT?= =?utf-8?B?dk9DVFMwZXA2Vk5vZDBtdUxyc0p3NHBnVEdMVFhpUFJIc1JyNE1aeUsyR1JU?= =?utf-8?B?STNRWVIyZmdEeVFxVUdmUlNGS0hZL0VBb0YrQTZXNUltRGtPcFZiajI2NjZ4?= =?utf-8?B?OUJVelpPUVZxOUhEUk9oVnl6YzVpVzQ5ZS9UbW9RN3NleDdRQXVwcU1RbFll?= =?utf-8?B?V0FUVFFQbzlCQm1yZVZqTHFld1RWS0pmMS9lWGsyVUU0d1kyaUkxZURmRHhi?= =?utf-8?B?akNIK3EzZlJwVzAvbTVCanVWaUFHSWJZUlVuZDNLQ3VpYVBoS0JJaDZqNjhH?= =?utf-8?B?TkM2REx6WlZNK0tnYU43RUJ0Q0N1Mms1cklkdGRjN3gyQTlnWDZndE1GTXNV?= =?utf-8?B?WnR4NjZSMkdBd3pFZ2k1c25abGF5bm85OThNQm91R1RIaU5BNDZCMTZDM3Zx?= =?utf-8?B?VFRQZTBoMTAxMGVIWGdaUnE4d09KejR6bW9xRnRReVBCRHFFd1dua2twRVhL?= =?utf-8?B?c2wxWkJRcWJjd1QrZ08zbVF1Z3BVTG5vdmRtS1VWWnRZZFA0TERyaHFOL1Vu?= =?utf-8?B?clJpNmJMeGpOaDdvVU1OaCtwb1BCc3c3bXhaeG9KKytMdXFRSnQxdDJtREdk?= =?utf-8?Q?AKsTPosv6QzF/mGTEjbPxohjR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84e6b885-a357-4c5d-925f-08daa630ba3a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 17:49:04.1731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6YQRs85LjQ1gNEi+8XWBr5vFthEtKuDwhYO7DYYngz05h4fx24V8wak0go8bdWkT X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4468 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/24/2022 3:45 AM, longli@linuxonhyperv.com wrote: > > From: Long Li > > The hardware layer of MANA understands the device queue and doorbell > formats. Those functions are implemented for use by packet RX/TX code. > > Signed-off-by: Long Li <...> > + > +#define DOORBELL_OFFSET_SQ 0x0 > +#define DOORBELL_OFFSET_RQ 0x400 > +#define DOORBELL_OFFSET_CQ 0x800 > +#define DOORBELL_OFFSET_EQ 0xFF8 Instead above can be enums if you prefer. This is only to reference previous comment on making PCI IDs enum.