* [dpdk-dev] [PATCH] net/iavf: fix performance drop after port reset
@ 2020-11-12 5:51 Leyi Rong
2020-11-12 11:47 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Leyi Rong @ 2020-11-12 5:51 UTC (permalink / raw)
To: qi.z.zhang, wenzhuo.lu, jingjing.wu, beilei.xing; +Cc: dev, Leyi Rong
Needs to reset rxq->rxrearm_start to 0 when reset_rx_queue(),
otherwise, the random value of rxrearm_start will cause performance drop
due to L3 contested accesses.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
drivers/net/iavf/iavf_rxtx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 8f43208c80..21d508b3f4 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -195,6 +195,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq)
rxq->pkt_first_seg = NULL;
rxq->pkt_last_seg = NULL;
rxq->rxrearm_nb = 0;
+ rxq->rxrearm_start = 0;
}
static inline void
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop after port reset
2020-11-12 5:51 [dpdk-dev] [PATCH] net/iavf: fix performance drop after port reset Leyi Rong
@ 2020-11-12 11:47 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2020-11-12 11:47 UTC (permalink / raw)
To: Rong, Leyi, Lu, Wenzhuo, Wu, Jingjing, Xing, Beilei; +Cc: dev
> -----Original Message-----
> From: Rong, Leyi <leyi.rong@intel.com>
> Sent: Thursday, November 12, 2020 1:52 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
> Subject: [PATCH] net/iavf: fix performance drop after port reset
>
> Needs to reset rxq->rxrearm_start to 0 when reset_rx_queue(), otherwise, the
> random value of rxrearm_start will cause performance drop due to L3
> contested accesses.
>
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
>
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 5:51 [dpdk-dev] [PATCH] net/iavf: fix performance drop after port reset Leyi Rong
2020-11-12 11:47 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).