From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id D7D419208 for ; Fri, 30 Oct 2015 17:16:11 +0100 (CET) Received: by wmff134 with SMTP id f134so15632572wmf.0 for ; Fri, 30 Oct 2015 09:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=1DwUkPSD0iRYzPKzTMjXHhDNC3osU0wRgBPAqqg8VIc=; b=dW3GFAyJWmHooWA+qIsBYAZ4yfPk1+DrVYbvfCKQtxuSctbvW75gENt47KqSD3YFam dKr8xDlP2nAWzs9YEqH1QkHLTkTCG1TnVQga5ZOrsJzqk+2XZjNUQSDkPUGEaimksA3p LibU3g6WIjBwGJwKQ9OmlwUcfg5chLasQ9fO4Q0G5tZ/3y/B8YyP7N66899Hd4P71+Xf 9IAzb1vF4/pNAGkQQ17AIFGGatYOqxdysnigPxUu0+QThQBoOlJVkhxVUKa4RMyPSBme P3DaE+BsuCh+TqotElbfFNDV6NHDXXu9hUh6Q6vJwRywBsUSAtNhnSgSeEXeVkI8M4aY IYww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=1DwUkPSD0iRYzPKzTMjXHhDNC3osU0wRgBPAqqg8VIc=; b=mDstFGjZdlm12qTC6d6kiKNykfhKhQrC2xYaoVig4ZVqe0eYPigaHJEjthcA+rKx+8 SDQj3QupJw6nm9Kml5LX9C4U18LFytC2Ba9/XW5GWgS90/cItEs+Uf1n6CMDvmrXdusR mxEVb74vsqIlb7hKrvqkm3ZmjsvSEUP4Pg9hloABWUoPi6kR+ck6MxeLPzpqMJJjZ68E Dlse+i6JHSEZ7KuL1MHOo0fmoXBeY59/gXZgqALuXLhQtSG2V3tUnjBt09VkHEJGrwLW sm2gd2FF28gyUTxZcM0A4oqX70oReeKgewDIpv/qNdp4mE7pq1ubLBiy7mz5QYziJ33A NMwA== X-Gm-Message-State: ALoCoQk3N2EpXFatrQm36AK+aHzuE3L7cLrLp0R1oDO0EEfLsKIUuPJjLU8ztqNm8QnwTwLd6yX0 X-Received: by 10.28.9.201 with SMTP id 192mr4754273wmj.5.1446221771733; Fri, 30 Oct 2015 09:16:11 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id r13sm3601112wmg.12.2015.10.30.09.16.11 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Oct 2015 09:16:11 -0700 (PDT) Date: Fri, 30 Oct 2015 09:16:11 -0700 (PDT) X-Google-Original-Date: Fri, 30 Oct 2015 17:15 +0100 From: Thomas Monjalon To: Jan Viktorin Message-ID: <6645369.r3ghAFd0W5@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151030161106.4657232.16920.465@rehivetech.com> References: <1446212826-19425-7-git-send-email-david.hunt@intel.com> <5633798B.2050708@intel.com> <20151030161106.4657232.16920.465@rehivetech.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 6/6] test: add checks for cpu flags on armv8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 16:16:12 -0000 2015-10-30 17:11, Jan Viktorin: > Anyway, it is not clear, what has changed in the v3. Just the rte_cycles? > You should explain that at least in the 0000 patch. > Better to keep some history in each single commit (are there any rules in > dpdk for this? Just look how they do in kernel). The rule is to help reviewers ;) History in the cover letter is good. If there are also some history in each patch, it's better.