From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44AC9A052B; Tue, 28 Jul 2020 17:28:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C8F11BFFD; Tue, 28 Jul 2020 17:28:02 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 9C3792B9C for ; Tue, 28 Jul 2020 17:28:00 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3025B885; Tue, 28 Jul 2020 11:27:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 28 Jul 2020 11:27:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 9rBYcr41TiS3BqAYHPON79T/8ji14sJWWiD6VAPOprw=; b=vmYgi4YKGN0G9KsK xc3DkzZxmROCAduq4La1/UUaEl3nQZLSc58OR+QFP7/rUmmybyp+J9xkUeMOiJk7 Gq8lTQ4PLRwhjXWAPTE1Qe4jJ5/2CdmIZwnOGu2DKr+GQ8SGie5rdDksIfTXf49c 2RIeJdsr3s3gHbl3YSP+EVy78ALoyQlul/n4H8/ge3oFpJpCv7UWiRMkJ/i2dBbP V+JIbUv/HfwXF5AbTNJGAdg5WTvSKhyhz/cQb+zH1xEY62ZPe8510vBPCwauWs14 hMDgHiIf+PTPkXU1wTFspjddviLKjxSsMi7I5yozWJdxj+l7uDNThj0W0ZyBXCIC 5yBmoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=9rBYcr41TiS3BqAYHPON79T/8ji14sJWWiD6VAPOp rw=; b=q0xb8Dm0+4dQ4F8bDD307a7T2XKWOiOjEWORyYaBI9e+cjLwjkPgxwcGw Rj4GjxbgKYOTPYtmqqTFx56pea2o+tpxstAXO2m4BWUCqEPvOuddRFOvCciInscy qE8wcGoAVbupdBsB70gkYfjU0+cgBt5cI56V+nDI5KS8aVQpR0YMjn71avBwgpMw EGoPHhI6TtSCmnFGvaIBXpM1wwbnk0wJNmvx8oz2XVMsNOXJ/qEFdek/DQUnfjHy Nz5Q2Z9AEUIe+ToW/eySyV2Jq7VEtmrkNKc/KXHLmENhRjC+oW2pfBCmLANzE07W yNNKlp2gbFgEAG2OCUJIiT42WjR8Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedriedvgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeetkeffuddvtdekffekveehteekgfeutdegjeefudeuheduieegieel leduhfehfeenucffohhmrghinhepughpughkrdhorhhgpdhhuhgrfigvihdrtghomhenuc fkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 69D6D3280059; Tue, 28 Jul 2020 11:27:57 -0400 (EDT) From: Thomas Monjalon To: Chengchang Tang Cc: Ferruh Yigit , dev@dpdk.org, linuxarm@huawei.com, arybchenko@solarflare.com Date: Tue, 28 Jul 2020 17:27:56 +0200 Message-ID: <6655202.xMAYDfDikD@thomas> In-Reply-To: References: <1592894934-57856-1-git-send-email-tangchengchang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC v2 0/3] add rx buffer size for rte_eth_rxq_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" You're right pinging for reviews. That's the right time to look at next features for those who have completed their 20.08 tasks. Feel free to review other pending patches in the meantime. Some of the next features are classified as "Deferred" in patchwork: https://patches.dpdk.org/project/dpdk/list/?state=10 28/07/2020 13:39, Chengchang Tang: > Hi Ferruh, > > Thank you for your reply. I'm sorry to bother you while you are busy with > the release. I know this change may only be accepted in the next release. > I'd like to know what the community thinks about it. If there is no > objection, I will send the patch after current release out. > > On 2020/7/28 17:30, Ferruh Yigit wrote: > > On 7/28/2020 7:29 AM, Chengchang Tang wrote: > >> Friendly ping > > > > Hi Tang, > > > > Sorry for not making it clear, since it is a library change, the change is > > already late for this release (20.08), and it will be considered for next > > release. As current release out, we can continue the discussions. > > > >> > >> On 2020/7/22 14:38, Chengchang Tang wrote: > >>> In common practice, PMD configure the rx buffer size which indicate the > >>> buffer length could be used for hw in receiving packts according to the > >>> data room size of the object in mempool. But in fact the final value is > >>> related to the specifications of hw, and its values will affect the number > >>> of fragments in recieving pkts when scatter is enabled. By the way, some > >>> PMDs may force to enable scatter when the MTU is bigger than the hw rx > >>> buffer size. > >>> > >>> At present, we seem to have no way to expose relevant information to upper > >>> layer users. > >>> > >>> So, add a field named rx_buf_size in rte_eth_rxq_info to indicate the > >>> buffer size used in recieving pkts for hw. And this patchset also add hns3 > >>> PMD implementation and update the testpmd to clarify intention. > >>> > >>> v2: > >>> Add hns3 implementation and update testpmd. > >>> > >>> Chengchang Tang (2): > >>> ethdev: add a field for rte_eth_rxq_info > >>> app/testpmd: Add RX buffer size dispaly in queue info querry > >>> > >>> Huisong Li (1): > >>> net/hns3: add support for query of rx/tx queue info > >>> > >>> app/test-pmd/config.c | 1 + > >>> drivers/net/hns3/hns3_ethdev.c | 2 ++ > >>> drivers/net/hns3/hns3_ethdev_vf.c | 2 ++ > >>> drivers/net/hns3/hns3_rxtx.c | 48 +++++++++++++++++++++++++++++++++++++++ > >>> drivers/net/hns3/hns3_rxtx.h | 4 ++++ > >>> lib/librte_ethdev/rte_ethdev.h | 2 ++ > >>> 6 files changed, 59 insertions(+) > >>> > >>> -- > >>> 2.7.4 > >>> > >>> _______________________________________________ > >>> Linuxarm mailing list > >>> Linuxarm@huawei.com > >>> http://hulk.huawei.com/mailman/listinfo/linuxarm > >>> > >>> . > >>> > >> > > > > > > . > > > >