From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 0693B4CA5 for ; Tue, 8 May 2018 13:22:55 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 401664C005C; Tue, 8 May 2018 11:22:53 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 8 May 2018 12:22:29 +0100 To: Ferruh Yigit , Wei Dai , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: References: <1525442529-12723-1-git-send-email-wei.dai@intel.com> <1525773917-62792-1-git-send-email-wei.dai@intel.com> <60bdea5d-2b90-0986-9f0f-c952bc722ce7@solarflare.com> <284eda96-2db4-6c64-f17f-7c3bd88ac019@intel.com> From: Andrew Rybchenko Message-ID: <665564df-c0c6-335c-c8e1-c08b61f78e11@solarflare.com> Date: Tue, 8 May 2018 14:22:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <284eda96-2db4-6c64-f17f-7c3bd88ac019@intel.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23830.003 X-TM-AS-Result: No--18.207600-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1525778574-oDYrIYYYtVxx X-Mailman-Approved-At: Tue, 08 May 2018 14:13:42 +0200 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 11:22:56 -0000 On 05/08/2018 02:02 PM, Ferruh Yigit wrote: > On 5/8/2018 11:41 AM, Andrew Rybchenko wrote: >> On 05/08/2018 01:05 PM, Wei Dai wrote: >> >> [...] >> >>> In the beginning of [rt]x_queue_setup( ) of underlying PMD, >>> add offloads = [rt]xconf->offloads | >>> dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API >>> defined in 17.11 to avoid upper application broken due to offload >>> API change. >>> PMD can use the info that input [rt]xconf->offloads only carry >>> the new added per-queue offloads to do some optimization or some >>> code change on base of this patch. >> It looks like I've missed why PMDs should be updated to >> add device offloads to per-queue offloads. >> Cannot it be done on ethdev layer? PMD still can find out >> which offloads were enabled on device level by >> checking [rt]xmode->offlaods. > The stripping [rt]xconf->offloads part added into ethdev layer. This changed the > input set to the PMDs. > > Above coded added to keep the input same for the PMDs. Expectation is later PMD > update its code to use new input and remove this update. Thanks Ferruh. I read code too fast and lost it from my view. I'll provide more review notes related to net/sfc. >>> Signed-off-by: Wei Dai >>> Signed-off-by: Ferruh Yigit >>> Signed-off-by: Qi Zhang >> [...]