From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"motih@mellanox.com" <motih@mellanox.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: enable CRC strip without capability check
Date: Thu, 8 Feb 2018 14:29:33 +0000 [thread overview]
Message-ID: <666cfb3a-87df-1662-3cfb-b13a728a8f3b@intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725890570935@irsmsx105.ger.corp.intel.com>
On 2/8/2018 12:13 PM, Ananyev, Konstantin wrote:
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Thursday, February 8, 2018 12:08 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>; motih@mellanox.com; shahafs@mellanox.com
>> Subject: [PATCH] app/testpmd: enable CRC strip without capability check
>>
>> Some hardware doesn't support disabling CRC strip. In techboard it has
>> been decided to enable CRC strip always.
>>
>> The testpmd update in commit 8b9bd0efe0b6, enables CRC strip only if
>> PMD reports CRC strip capability. Not all PMDs updated to report CRC
>> strip.
>>
>> For the PMDs not reporting CRC strip testpmd behavior changed and
>> disabling CRC strip for them. And this may generate error for PMDs that
>> doesn't support disabling CRC strip.
>>
>> Removing capability check for this release. In long term there can be
>> option to remove CRC strip flag completely or adding a new flag to let
>> PMD say disabling is not supported.
>>
>> Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by default")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-02-08 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 12:08 Ferruh Yigit
2018-02-08 12:13 ` Ananyev, Konstantin
2018-02-08 14:29 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666cfb3a-87df-1662-3cfb-b13a728a8f3b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=motih@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).