From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6281B1B77F for ; Thu, 8 Feb 2018 15:29:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 06:29:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,479,1511856000"; d="scan'208";a="25868715" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by FMSMGA003.fm.intel.com with ESMTP; 08 Feb 2018 06:29:33 -0800 To: "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Wu, Jingjing" Cc: "dev@dpdk.org" , Thomas Monjalon , "motih@mellanox.com" , "shahafs@mellanox.com" References: <20180208120803.95060-1-ferruh.yigit@intel.com> <2601191342CEEE43887BDE71AB97725890570935@irsmsx105.ger.corp.intel.com> From: Ferruh Yigit Message-ID: <666cfb3a-87df-1662-3cfb-b13a728a8f3b@intel.com> Date: Thu, 8 Feb 2018 14:29:33 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB97725890570935@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: enable CRC strip without capability check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 14:29:36 -0000 On 2/8/2018 12:13 PM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Thursday, February 8, 2018 12:08 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> Cc: dev@dpdk.org; Yigit, Ferruh ; Thomas Monjalon ; Ananyev, Konstantin >> ; motih@mellanox.com; shahafs@mellanox.com >> Subject: [PATCH] app/testpmd: enable CRC strip without capability check >> >> Some hardware doesn't support disabling CRC strip. In techboard it has >> been decided to enable CRC strip always. >> >> The testpmd update in commit 8b9bd0efe0b6, enables CRC strip only if >> PMD reports CRC strip capability. Not all PMDs updated to report CRC >> strip. >> >> For the PMDs not reporting CRC strip testpmd behavior changed and >> disabling CRC strip for them. And this may generate error for PMDs that >> doesn't support disabling CRC strip. >> >> Removing capability check for this release. In long term there can be >> option to remove CRC strip flag completely or adding a new flag to let >> PMD say disabling is not supported. >> >> Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by default") >> >> Signed-off-by: Ferruh Yigit > > Acked-by: Konstantin Ananyev Applied to dpdk-next-net/master, thanks.