DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v2] devtools: ignore new warnings on reported-by tag
@ 2025-11-14 20:06 Dariusz Sosnowski
  2025-11-29 19:13 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Dariusz Sosnowski @ 2025-11-14 20:06 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Bruce Richardson

There were 2 changes introduced in checkpatch.pl script [1][2]
which verify if Reported-by tag is followed by Link or Closes tag.
Example of the warning output:

    WARNING:BAD_REPORTED_BY_LINK:
      Reported-by: should be immediately followed by Closes:
      with a URL to the report

Original purpose is to link the patch to the mailing list discussion
and/or a bug report.

Since Link and Closes tag are not mandated in commit messages
where Reported-by tag is used, the warning about lack of Link/Closes
tags can be suppressed.

[1]: https://github.com/torvalds/linux/commit/d7f1d71e5ef630ab9e15b5821d297a9e1a5fa1da
[2]: https://github.com/torvalds/linux/commit/44c31888098a590b8ec5ba37009e5a983f7c4b46

Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2:
- Rebased on top of latest commit in main branch.
- Reworded the commit message

 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 9fb8fd0a07..614cd7c32b 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,STRLCPY,\
 PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
 SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
-NEW_TYPEDEFS,COMPARISON_TO_NULL,AVOID_BUG,EXPORT_SYMBOL"
+NEW_TYPEDEFS,COMPARISON_TO_NULL,AVOID_BUG,EXPORT_SYMBOL,BAD_REPORTED_BY_LINK"
 options="$options $DPDK_CHECKPATCH_OPTIONS"

 print_usage () {
--
2.39.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] devtools: ignore new warnings on reported-by tag
  2025-11-14 20:06 [PATCH v2] devtools: ignore new warnings on reported-by tag Dariusz Sosnowski
@ 2025-11-29 19:13 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2025-11-29 19:13 UTC (permalink / raw)
  To: Dariusz Sosnowski; +Cc: dev, Bruce Richardson

14/11/2025 21:06, Dariusz Sosnowski:
> There were 2 changes introduced in checkpatch.pl script [1][2]
> which verify if Reported-by tag is followed by Link or Closes tag.
> Example of the warning output:
> 
>     WARNING:BAD_REPORTED_BY_LINK:
>       Reported-by: should be immediately followed by Closes:
>       with a URL to the report
> 
> Original purpose is to link the patch to the mailing list discussion
> and/or a bug report.
> 
> Since Link and Closes tag are not mandated in commit messages
> where Reported-by tag is used, the warning about lack of Link/Closes
> tags can be suppressed.
> 
> [1]: https://github.com/torvalds/linux/commit/d7f1d71e5ef630ab9e15b5821d297a9e1a5fa1da
> [2]: https://github.com/torvalds/linux/commit/44c31888098a590b8ec5ba37009e5a983f7c4b46
> 
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-29 19:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-14 20:06 [PATCH v2] devtools: ignore new warnings on reported-by tag Dariusz Sosnowski
2025-11-29 19:13 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).