From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D500A00C5; Tue, 15 Feb 2022 19:51:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07A90410F3; Tue, 15 Feb 2022 19:51:36 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 890D840041 for ; Tue, 15 Feb 2022 19:51:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644951094; x=1676487094; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=d11AzY5jdfismX71fQFd0r6+EUnihqkpLX/O1SneCBA=; b=E0uoNzPGBU8Lx+Ml6tm5WuOudDpGz56YYyxm4lWE87L1G3ZQNJzBiUfZ rsfMgIWWjbVP9TsgYFSA1yDMti4Ndvjh5eJVeOmTqG3NaCMj9leZRpzdW MbP82T5QQ5O53mz0Ba3RyIGrMS5+oDxaeSpVboomFJKSbjci7gnisp925 GxVevskD3YloL74Rl0V3wOzPaeoTPE3hBAek2o+YikluYQA1Kv87Aqx/V sGy53sGl2+AfnPWv6/lqk+uT5c/EkZMVjeAJcxzGltOfo7b3OfdB/hyVR gi7iUbd1/47e9SGSyPpXZRBfti6H+ccHGayT5gkt1LewBTGS8xG5jiarL A==; X-IronPort-AV: E=McAfee;i="6200,9189,10259"; a="250374359" X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208,217";a="250374359" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 10:51:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208,217";a="570960201" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 15 Feb 2022 10:51:33 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 10:51:32 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 10:51:32 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 10:51:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fO3cppnjySl0k8Rhmg9SpS+ynSYIj+bQxbrlYFRlRtJ2Jaxqxp1FuGyglSHeDXyDFxg1R1mjFmgoZKHKbk80CdmUACd6PNiHBhdiXaFdpKYJkVfWI1Rv+2b0Lh6VZ7aWc7aqbutHilc/tmu/TgyKPit75mNWf28JMjyKgDIEXszghIYq6ZbWNTGkJqxlfzoyDNjKJRQNKXoqm+VSS9IegJjvbyJ0IKbOV58GvNFvPJAoV7vDqZmu3mmhCunbb9bNZ4uOlm4+qUnLq0DH14v6vdHldj6D3bMEOrT94hO2BGc0WY8qmUyMQ2hLucBR3s5TAaWs4px4zhC389LTW15qAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=43R/+2RtMVZEtTQs4R1HPKoTG/sEnQtyUJmEIXAyGOs=; b=EIjMN9FRDyajWkvHXtdgsuWJpebQi3T1GXS4vPi++WSP5v482KU8fbkEQCBOJvD2VTILHFlmpPsvsPf5o4lfeyLilWKlrzB7XtTwamH1p6aOFctA7cGsYfV3fXhr1TzT5JUiYdDMMHS45Bok7Nb8k18YjFn2y7sonE+A561FlCUWoOkczllgBOzdEF/UlbPxsKHNKtMd8UnpIkINkFY5pOzel0a5Kqrf8UO/QwLqmgBWEYMLERXfZaYfLwG0fzntJcsQPpHOfqy8S1ID8uMHWIzjWwvou2DhAlajCwhua/8AXPfWQ8M16VSHUOG8Vx48vwyelJwRNDbeIu2eU4V7kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by DM6PR11MB4009.namprd11.prod.outlook.com (2603:10b6:5:193::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Tue, 15 Feb 2022 18:51:31 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::417b:7df4:d3fb:2b0a]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::417b:7df4:d3fb:2b0a%3]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 18:51:31 +0000 Content-Type: multipart/alternative; boundary="------------E2PqU2fu7RmbIvpMwK0k5x7Z" Message-ID: <6677029b-2f32-4183-86fb-c947c6ca1134@intel.com> Date: Wed, 16 Feb 2022 00:21:23 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace Content-Language: en-US To: Thomas Monjalon CC: , References: <20220123172046.1296964-1-aman.deep.singh@intel.com> <1843605.IobQ9Gjlxr@thomas> <2756826.yaVYbkx8dN@thomas> From: "Singh, Aman Deep" In-Reply-To: <2756826.yaVYbkx8dN@thomas> X-ClientProxiedBy: BM1PR0101CA0039.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::25) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: abeea284-e5fa-4085-f597-08d9f0b42e2e X-MS-TrafficTypeDiagnostic: DM6PR11MB4009:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qaDFjz2FCFM/25v5vOoRqzjrffxUJKxUdKNebo7C5+0aMzE39UYl8/7ZhjEoCCZVCdLdzqWPa6caeo3x9MnLAGDrz17jFL0Mu1H0ojVRzQCdH3d/poPuSTS7S90FZrox9nZ4UFEME7wC6csvtv9V084GkcXcCHHdE0uZh9T+H1/Jh0ec0dnEAtOVm8WizUA/NlFzEY6jplGEhZ6G4tWjtFF95yx5jYNAeRQ8dOl3ib/knf6vaClj6gSQdRi/AwwVkeuHo2j/1YCJRSi+wvHABN/S2Tol3i+u4Ia1HDsZ00p0TwTxnRohmJBqHg8jBSpF1NbgTz6kG/rM+dxR2B/Z7aAG/3qIYWfDzYzjb+Kho3E/5DEt+cOOVbU7G2YDJKnX2RtIs7vTFzISlRW+9cVvOuGMGtDV7SxCpm50E1CI4YMWOQi/lfbCT8x3uj3DMA5o1nLoSJAKcgapEM8/rvnKTYg7jq9pH6v56Logz6xAMP2WIPhPDHzWszBCCfKHQIFKftC8G/IEvT/kwJaR4WF2qGzkUxyOpWAtLbSYU2cu4YkqVKl3e7JjecCtSVWPbm/8sEcb8haLfsfF4EA+BVIECwFjbQWZ1h5fatf2tKRZnJzqvNVdTR0wf4W5mjjOXYpIP4PD07aVlcLdg65R91VmTA86tpmpxbfC5uCc1rMaZ2KKwTIkLePl8cyxtW/LIKp3hvBTuzK58n9ZzkEoNIaUqmuZC6oGU6gWYTrs5OI3ntV8DOuW8DL3lkglzH+/S/EYqiBOiRVbQ1cIX6pY8kqHbw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(66476007)(6916009)(53546011)(82960400001)(36756003)(38100700002)(6512007)(4326008)(8676002)(2616005)(6486002)(33964004)(66556008)(508600001)(6506007)(316002)(2906002)(31696002)(107886003)(6666004)(26005)(86362001)(83380400001)(5660300002)(186003)(8936002)(31686004)(21314003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWZPZDBBS2N1VkxQeFd3RWdOcnFrdXhOdzR1ck9wZ3AxK0tlejZsYi82cnQy?= =?utf-8?B?dmpDQU1WZXo1NmxXd2NrYmw3ODBYQkZnOE9BbTF6c0pZMjFDeDJNSjRPbnhG?= =?utf-8?B?NVBRZWkyUnVsNmFoTm9pZEp4UjU1T3NjdFY3WmlvdTNvYlNRQlRwQkxxdW1n?= =?utf-8?B?cjl4YVR1cGp2UlF2Ny90NTNjY1VwRWNtQWhRWVhaeGVoN3dpcVd5VDY1NFJ0?= =?utf-8?B?Z1BaOXZ2ckVDVFNEMGFiTVlKWWJ6c25IRTB0SVBUNkV0OGJzQTZXNitQUkgr?= =?utf-8?B?MENSWEN2NURubk1RVXpySHc2Qm9vM0w3bnNpVVZTTlRwMGJxT2plR2hpVzY0?= =?utf-8?B?QmZyL1pVUXVpNzhZYnE5SDNEcU1xeGlPZ3lrWHUvUHlub2x2V1JKWndYZ0lJ?= =?utf-8?B?bnp0aWRNRFFpeUkrbmMxb2pIajk3SXRPYmM4cFJEOXN5MzhyeW9DTy9vVXBI?= =?utf-8?B?RTkyMUFkbm5HUWxWaTNYT0VwWDNIVG5BN2VBNExBTENucm9tRHo1ckY0ZEZj?= =?utf-8?B?TGE1SUpYUHU1RjlDUDFnbVdXdXAzVXdjbXNCVzFNZlNQeGdpdWE1ZnZlSVZt?= =?utf-8?B?TmRlQ29qSDhrTDQ5NDVDeVBObjA2VUQ2VDBqTkhJdzIybERVaS9HSmlpNTh5?= =?utf-8?B?L1JXRGs3OE01OUYzWDdyMzZFRGM0Qy9UVG1pUlpJTUZFQTdHcTdFRkoxSGZR?= =?utf-8?B?alMyOVRDdWJEYjZJc0oxM0h2akxLd0dOVFU5Vlcya095ZFlvSTZBUTRIUlFN?= =?utf-8?B?anR6YkFic3ZUVVBQWC90UFlqME1GVkszWlcxUzlmVmFBRk9pZXlvWFNpT2Mr?= =?utf-8?B?VFBQdDg5QnJ5ajltWGRJSk90dGxEKzRISE54NC9zRWtQSmNFaGJTK2RsRGFy?= =?utf-8?B?bG1VZllsVVJzQmhKYk9QeXI2ckNaOHlEOHZTMHZSUGU3SlJ6dm04TVhoZTdJ?= =?utf-8?B?K0xyYkxPTWtDZ1NiUGkxQzM2MktCY0JhL3krM1VYVS80YW5LaEFaeXRSaWFr?= =?utf-8?B?OThjMTJSeVYwQ3VpSENuaDFEN04yYTJkVGszNmd2SWQ1L3ZzRmM0d3RIZWF3?= =?utf-8?B?OTNIVjVpVHNjYVlEVHl6ZkgxTTNXOWZLcWV6Y2ZiMkdIYlRCa0tyZG8waDZR?= =?utf-8?B?cVo5ZGN6OTBmcDAra0RDallWTmlXTlRPMU92YmF3RFlnRWd5TytiT1JnM1VZ?= =?utf-8?B?bVEzYURyYk5XT2U5ZkNrMFRwa1VwT2orcDFMQVNtS2VncStwUTl1RFdqWVMr?= =?utf-8?B?Ujhtc0VOVzBGMmRTQjFvdXhvUWk1ZW91QUhjYUxPR1JzRC9BMWNPZ3MxR01E?= =?utf-8?B?bE5Wb01TVlhkSUJwN0UwMURQdXBIci9BNXpaekRSS01Da2lTRnVIUDRHK084?= =?utf-8?B?OTJTbDRmc3I1Z3VlemtEc3RtS1F6bFZWSHEwK0lUdWhuaGxsdDJSK1BvN1Q0?= =?utf-8?B?cmcwV1ZqZjUrS1JGcDhQaXJhVkpIb1NTMjFCVDQvcXZrNmFaT2d5QS9CWVpE?= =?utf-8?B?Z2o4ODZ2R2VuZmhDaHJqaEpQUkx3U1ZEWE9Lc01RL3ZvTTFFZUtrV09tZzZ5?= =?utf-8?B?cWZLb3ZmSlB1cUdQazhNTkJmSUpwamRTRmJ0T2w4aFEyd1hTQjNqTEQxK2FN?= =?utf-8?B?MEpYVlh3NzFsK1VjVytNc1ZZL3MraE1lNEVsNDJnS0VEU0dXdk9KWllPK0Vi?= =?utf-8?B?VnBDZHhRaEtqalM1RVBpbHh2U1pXemdlRHRlSlR0VGhYcnd2Y2ZLaDMzeGxY?= =?utf-8?B?QUZnN1B4WncxWEsvUXZzREpYRmFXdzk1T0JaWjVLanRKZk1ianpiRXlBc2tZ?= =?utf-8?B?bTdCZ211ekVoN3JSbUF5T2w4SkQ0SnNLK0V2UGczaDRBVHE0V2NDdEg5VmNO?= =?utf-8?B?WEZPdittUFErQmJ6SU1QUWw3OHdzaWNRZTl1aU5GSHFmMzdhUUErYVEwalV1?= =?utf-8?B?VW1sdXNTdTZ0WmlIL2NYcFhBSTZvK0FTWXhYb3dZend1eVJKVUFNMmQveFc4?= =?utf-8?B?enJ3OE9WNW51NTBLSXpLd094MmVnSGpRS2Z1VEtRWFlEbWw4NnRReExMdlpI?= =?utf-8?B?MzFHTkFLaTM1eHU4VXY5Tk9XMk1vTGc4Y2VqMFJ4L3ZkV2VJckhHYmplU1Vw?= =?utf-8?B?OTNUY3lGcndENU1SdG5XcldWRlY3TnA0SE5ZWjJjcDRkNS9kM0NFc0U2Rkx1?= =?utf-8?B?ZnVrcURZMmZEVmJwdTRnM2JpZ0tVUldVNDFlR0lmVlFCdk95eDhWYnBzQkFa?= =?utf-8?Q?Qg3dprMfcQVn2hbJty/j1CJksHZOCaXUL93guR8h+8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: abeea284-e5fa-4085-f597-08d9f0b42e2e X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 18:51:31.2838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vX5kWsh2z76+YeE/K0o9SBlvqGjGGIbL+OmWGuTqFjvg/Dm/xymMFwLvpQjcNZ65B9bpZJOPGRLw5bLIKAqLzmefPKzfQnpeZ6SH9i5krfM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4009 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------E2PqU2fu7RmbIvpMwK0k5x7Z Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 2/11/2022 10:58 PM, Thomas Monjalon wrote: > 11/02/2022 09:07, Singh, Aman Deep: >> On 2/10/2022 9:00 PM, Thomas Monjalon wrote: >>> 10/02/2022 14:26, Singh, Aman Deep: >>>> On 2/4/2022 1:17 PM, Thomas Monjalon wrote: >>>>> 04/02/2022 07:13, Singh, Aman Deep: >>>>>> Hi Thomas >>>>>> >>>>>> On 2/3/2022 2:31 AM, Thomas Monjalon wrote: >>>>>>> 23/01/2022 18:20, Aman Singh: >>>>>>>> Added two specific exceptions for ETH_SPEED_10G >>>>>>>> and ETH_SPEED_25G to avoid there name change. >>>>>>>> Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA >>>>>>> Please could you explain why? >>>>>> These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga >>>>>> driver and script should no change these. >>>>>> There are multiple ETH_SPEED_NUM_xxx macro that need to be changed >>>>>> to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions. >>>>> Why doing this exception? What is special with ifpga? >>>> These two macro's are defined in 'ifpga/base/opae_eth_group.h' >>>> we don't intend to change these. Target is ethdev namespace only. >>> So we will miss future use of a deprecated macro >>> because ifpga is redefining it? >>> I think it is a wrong approach. >>> We should not make any exception in the check. >>> Instead we can just ignore the warning for ifpga. >> Actually ifpga is not redefining these two macro's ETH_SPEED_10G & ETH_SPEED_25G, >> they are unique to it. Only there prefix, matches with ethdev macro's >> ETH_SPEED_NUM_xxx, which caused coccinelle script to modify these to >> RTE_ETH_SPEED_10G & RTE_ETH_SPEED_25G. So just avoiding it by this change. > Would it work to restrict the match to ETH_SPEED_NUM? The script will change ETH_SPEED_NUM_xxx macros to RTE_ETH_SPEED_NUM_xxx as per the requirement. > > > --------------E2PqU2fu7RmbIvpMwK0k5x7Z Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 2/11/2022 10:58 PM, Thomas Monjalon wrote:
11/02/2022 09:07, Singh, Aman Deep:

On 2/10/2022 9:00 PM, Thomas Monjalon wrote:

10/02/2022 14:26, Singh, Aman Deep:

On 2/4/2022 1:17 PM, Thomas Monjalon wrote:

04/02/2022 07:13, Singh, Aman Deep:

Hi Thomas

On 2/3/2022 2:31 AM, Thomas Monjalon wrote:

23/01/2022 18:20, Aman Singh:

Added two specific exceptions for ETH_SPEED_10G
and ETH_SPEED_25G to avoid there name change.
Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA

Please could you explain why?

These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga
driver and script should no change these.
There are multiple ETH_SPEED_NUM_xxx macro that need to be changed
to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions.

Why doing this exception? What is special with ifpga?

These two macro's are defined in 'ifpga/base/opae_eth_group.h'
we don't intend to change these. Target is ethdev namespace only.

So we will miss future use of a deprecated macro
because ifpga is redefining it?
I think it is a wrong approach.
We should not make any exception in the check.
Instead we can just ignore the warning for ifpga.

Actually ifpga is not redefining these two macro's ETH_SPEED_10G & ETH_SPEED_25G,
they are unique to it. Only there prefix, matches with ethdev macro's
ETH_SPEED_NUM_xxx, which caused coccinelle script to modify these to
RTE_ETH_SPEED_10G & RTE_ETH_SPEED_25G. So just avoiding it by this change.

Would it work to restrict the match to ETH_SPEED_NUM?
The script will change ETH_SPEED_NUM_xxx macros to RTE_ETH_SPEED_NUM_xxx
as per the requirement.
--------------E2PqU2fu7RmbIvpMwK0k5x7Z--