From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 956032BCE for ; Mon, 8 Apr 2019 15:54:10 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id E8058680081; Mon, 8 Apr 2019 13:54:05 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 8 Apr 2019 14:53:58 +0100 To: Dekel Peled , Adrien Mazarguil , Ori Kam CC: "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , Yongseok Koh , "Shahaf Shuler" , "dev@dpdk.org" References: <1553177917-43297-1-git-send-email-dekelp@mellanox.com> <1554218001-62012-2-git-send-email-dekelp@mellanox.com> <20190403091432.GP4889@6wind.com> <20190403124921.GR4889@6wind.com> <20190404132556.GS4889@6wind.com> From: Andrew Rybchenko Message-ID: <66c690e9-8261-78b9-3287-50b444869bb5@solarflare.com> Date: Mon, 8 Apr 2019 16:53:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24538.003 X-TM-AS-Result: No-5.579200-8.000000-10 X-TMASE-MatchedRID: fgYTp5XatxYOwH4pD14DsPHkpkyUphL9HnCRYlUUdYJKb99LaADG+qjP l/Dla8YJwzUM/ufCp3miGIyoN2T/kDBTj9KDVuZ75gCHftmwEMJ9LQinZ4QefL6qvLNjDYTwIq9 5DjCZh0zCLNfu05PakAtuKBGekqUpI/NGWt0UYPAPlouDiwnSdNSgKHeZsSbyebUjh5jBOwsYxd JyrQhP0PA4vF8dRk2+ X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.579200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24538.003 X-MDID: 1554731647-IID2CUhfBeXb Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 13:54:10 -0000 On 4/8/19 4:36 PM, Dekel Peled wrote: > Regarding Andrew's suggestion: "Shouldn't these action be RTE_FLOW_ACTION_TYPE_MOD_TCP_{ACK,SEQ} with singed 32-bit integer parameter (negative to decrement, positive to increment)?" > I will leave the actions as is, the action names indicate the operation they perform. I think it is an overkill to have two actions for the purpose: DEC (value) == INC ((uint32_t)-value) If it is really important to have DEC and INC, please, make it clear from actions documentation why. Thanks, Andrew. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 030ECA0096 for ; Mon, 8 Apr 2019 15:54:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 94C3B2C24; Mon, 8 Apr 2019 15:54:12 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 956032BCE for ; Mon, 8 Apr 2019 15:54:10 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id E8058680081; Mon, 8 Apr 2019 13:54:05 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 8 Apr 2019 14:53:58 +0100 To: Dekel Peled , Adrien Mazarguil , Ori Kam CC: "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , Yongseok Koh , "Shahaf Shuler" , "dev@dpdk.org" References: <1553177917-43297-1-git-send-email-dekelp@mellanox.com> <1554218001-62012-2-git-send-email-dekelp@mellanox.com> <20190403091432.GP4889@6wind.com> <20190403124921.GR4889@6wind.com> <20190404132556.GS4889@6wind.com> From: Andrew Rybchenko Message-ID: <66c690e9-8261-78b9-3287-50b444869bb5@solarflare.com> Date: Mon, 8 Apr 2019 16:53:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24538.003 X-TM-AS-Result: No-5.579200-8.000000-10 X-TMASE-MatchedRID: fgYTp5XatxYOwH4pD14DsPHkpkyUphL9HnCRYlUUdYJKb99LaADG+qjP l/Dla8YJwzUM/ufCp3miGIyoN2T/kDBTj9KDVuZ75gCHftmwEMJ9LQinZ4QefL6qvLNjDYTwIq9 5DjCZh0zCLNfu05PakAtuKBGekqUpI/NGWt0UYPAPlouDiwnSdNSgKHeZsSbyebUjh5jBOwsYxd JyrQhP0PA4vF8dRk2+ X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.579200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24538.003 X-MDID: 1554731647-IID2CUhfBeXb Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408135354.Df1tteepdVUvftw83J-9ec8rNU_46P4Oj_Bo8c6rqZA@z> On 4/8/19 4:36 PM, Dekel Peled wrote: > Regarding Andrew's suggestion: "Shouldn't these action be RTE_FLOW_ACTION_TYPE_MOD_TCP_{ACK,SEQ} with singed 32-bit integer parameter (negative to decrement, positive to increment)?" > I will leave the actions as is, the action names indicate the operation they perform. I think it is an overkill to have two actions for the purpose: DEC (value) == INC ((uint32_t)-value) If it is really important to have DEC and INC, please, make it clear from actions documentation why. Thanks, Andrew.