From: Ivan Malov <ivan.malov@arknetworks.am>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
dev@dpdk.org, "Thomas Monjalon" <thomas@monjalon.net>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Konstantin Ananyev" <konstantin.ananyev@huawei.com>
Subject: Re: [PATCH] ethdev: Reject conflicting TX offloads configuration
Date: Sun, 3 Aug 2025 01:33:43 +0400 (+04) [thread overview]
Message-ID: <66e365f2-8398-43b2-58a6-cda29bae08e1@arknetworks.am> (raw)
In-Reply-To: <20250802135354.158d8561@hermes.local>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
Hi,
On Sat, 2 Aug 2025, Stephen Hemminger wrote:
> On Thu, 31 Jul 2025 09:07:31 +0000
> Morten Brørup <mb@smartsharesystems.com> wrote:
>
>> + RTE_ETHDEV_LOG_LINE(DEBUG,
>> + "Ethdev port_id=%d tx_queue_id=%d, Tx offload %s potential conflict with per-port Tx offload %s, "
>> + "runtime support depends on the driver",
>
> Shorten the message, and get it on one line.
> When a message is so long it won't fit on one line, it is too verbose.
I am not an expert in naming, but on the premise that 'ethdev' is already
printed by 'RTE_ETHDEV_LOG_LINE', perhaps consider this variant:
"id=%d txq=%d offload clash %s vs dev %s: PMD to decide"
Thank you.
>
next prev parent reply other threads:[~2025-08-02 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 9:07 Morten Brørup
2025-07-31 9:24 ` Bruce Richardson
2025-07-31 10:07 ` Andrew Rybchenko
2025-07-31 9:27 ` Ivan Malov
2025-07-31 9:34 ` Morten Brørup
2025-07-31 11:32 ` Konstantin Ananyev
2025-07-31 12:56 ` [PATCH v2 1/3] testpmd: Do not enable mbuf fast release TX offload by default Morten Brørup
2025-07-31 12:56 ` [PATCH v2 2/3] ethdev: Improve descriptions of RX and TX offloads Morten Brørup
2025-07-31 12:56 ` [PATCH v2 3/3] ethdev: Reject conflicting TX offloads configuration Morten Brørup
2025-08-01 1:09 ` zhoumin
2025-08-02 20:53 ` [PATCH] " Stephen Hemminger
2025-08-02 21:33 ` Ivan Malov [this message]
2025-08-03 10:51 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66e365f2-8398-43b2-58a6-cda29bae08e1@arknetworks.am \
--to=ivan.malov@arknetworks.am \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).