DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
	Davide Caratti <dcaratti@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx: support IOVA VA mode
Date: Thu, 2 May 2019 07:31:38 +0000	[thread overview]
Message-ID: <670CAD35-EFB3-4977-B66E-E19FD0431C94@mellanox.com> (raw)
In-Reply-To: <20190502014436.40545-1-yskoh@mellanox.com>



> On May 1, 2019, at 6:44 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
> 
> Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU takes
> virtual address.
> 
> Cc: stable@dpdk.org
> Cc: Davide Caratti <dcaratti@redhat.com>
> 
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---

Self nack.
pci_one_device_has_iova_va() checks RTE_KDRV_VFIO.
Will send out v2 with adding RTE_KDRV_NIC_MLX.

> drivers/net/mlx4/mlx4.c | 4 ++--
> drivers/net/mlx5/mlx5.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> index fe559c0407..eccb77b410 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -1133,8 +1133,8 @@ static struct rte_pci_driver mlx4_driver = {
> 	},
> 	.id_table = mlx4_pci_id_map,
> 	.probe = mlx4_pci_probe,
> -	.drv_flags = RTE_PCI_DRV_INTR_LSC |
> -		     RTE_PCI_DRV_INTR_RMV,
> +	.drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
> +		     RTE_PCI_DRV_IOVA_AS_VA,
> };
> 
> #ifdef RTE_IBVERBS_LINK_DLOPEN
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index de85e85300..ecab7f899f 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -2101,8 +2101,8 @@ static struct rte_pci_driver mlx5_driver = {
> 	.remove = mlx5_pci_remove,
> 	.dma_map = mlx5_dma_map,
> 	.dma_unmap = mlx5_dma_unmap,
> -	.drv_flags = (RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
> -		      RTE_PCI_DRV_PROBE_AGAIN),
> +	.drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
> +		     RTE_PCI_DRV_PROBE_AGAIN | RTE_PCI_DRV_IOVA_AS_VA,
> };
> 
> #ifdef RTE_IBVERBS_LINK_DLOPEN
> -- 
> 2.11.0
> 

  parent reply	other threads:[~2019-05-02  7:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02  1:44 Yongseok Koh
2019-05-02  1:44 ` Yongseok Koh
2019-05-02  7:31 ` Yongseok Koh [this message]
2019-05-02  7:31   ` Yongseok Koh
2019-05-02  7:43 ` [dpdk-dev] [PATCH v2 1/2] bus/pci: add Mellanox kernel driver type Yongseok Koh
2019-05-02  7:43   ` Yongseok Koh
2019-05-02  7:43   ` [dpdk-dev] [PATCH v2 2/2] net/mlx: support IOVA VA mode Yongseok Koh
2019-05-02  7:43     ` Yongseok Koh
2019-05-02  8:10   ` [dpdk-dev] [PATCH v2 1/2] bus/pci: add Mellanox kernel driver type Thomas Monjalon
2019-05-02  8:10     ` Thomas Monjalon
2019-05-02  9:07 ` [dpdk-dev] [PATCH v3 " Yongseok Koh
2019-05-02  9:07   ` Yongseok Koh
2019-05-02  9:07   ` [dpdk-dev] [PATCH v3 2/2] net/mlx: support IOVA VA mode Yongseok Koh
2019-05-02  9:07     ` Yongseok Koh
2019-05-02 13:06     ` Shahaf Shuler
2019-05-02 13:06       ` Shahaf Shuler
2019-06-03 22:39   ` [dpdk-dev] [PATCH v3 1/2] bus/pci: add Mellanox kernel driver type Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=670CAD35-EFB3-4977-B66E-E19FD0431C94@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=dcaratti@redhat.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).