From: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [PATCH v3 7/7] ip_frag: fix whitespace
Date: Sun, 22 Jan 2023 16:00:50 +0000 [thread overview]
Message-ID: <671b92fe-e2cc-0437-e65e-93f33f88024f@yandex.ru> (raw)
In-Reply-To: <20230117001453.94082-8-stephen@networkplumber.org>
17/01/2023 00:14, Stephen Hemminger пишет:
> The style standard is to use blank after keywords.
> I.e "if (" not "if("
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/ip_frag/rte_ipv4_reassembly.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c
> index 4a89a5f5365a..88ee0aa63f62 100644
> --- a/lib/ip_frag/rte_ipv4_reassembly.c
> +++ b/lib/ip_frag/rte_ipv4_reassembly.c
> @@ -34,7 +34,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp)
> for (i = n; i != IP_FIRST_FRAG_IDX && ofs != first_len; i--) {
>
> /* previous fragment found. */
> - if(fp->frags[i].ofs + fp->frags[i].len == ofs) {
> + if (fp->frags[i].ofs + fp->frags[i].len == ofs) {
>
> RTE_ASSERT(curr_idx != i);
>
Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
next prev parent reply other threads:[~2023-01-22 16:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 17:27 [PATCH 0/7] space after keyword cleanups Stephen Hemminger
2023-01-16 17:27 ` [PATCH 1/7] test: fix whitespace Stephen Hemminger
2023-01-16 17:27 ` [PATCH 2/7] testpmd: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 3/7] net/e1000: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 4/7] i40e: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 5/7] examples: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 6/7] cmdline: " Stephen Hemminger
2023-01-16 17:27 ` [PATCH 7/7] ip_frag: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 0/7] space after keyword cleanups Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 1/7] test: fix whitespace Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 2/7] testpmd: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 3/7] net/e1000: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 4/7] i40e: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 5/7] examples: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 6/7] cmdline: " Stephen Hemminger
2023-01-16 17:51 ` [PATCH v2 7/7] ip_frag: " Stephen Hemminger
2023-01-17 0:14 ` [PATCH v3 0/7] add space after keywords Stephen Hemminger
2023-01-17 0:14 ` [PATCH v3 1/7] test: fix whitespace Stephen Hemminger
2023-01-17 0:14 ` [PATCH v3 2/7] testpmd: " Stephen Hemminger
2023-01-31 8:21 ` Singh, Aman Deep
2023-01-17 0:14 ` [PATCH v3 3/7] net/e1000: " Stephen Hemminger
2023-01-17 1:21 ` Wu, Wenjun1
2023-01-17 1:26 ` Su, Simei
2023-01-17 0:14 ` [PATCH v3 4/7] i40e: " Stephen Hemminger
2023-01-17 0:26 ` Xing, Beilei
2023-01-17 0:14 ` [PATCH v3 5/7] examples: " Stephen Hemminger
2023-01-17 0:14 ` [PATCH v3 6/7] cmdline: " Stephen Hemminger
2023-01-17 0:14 ` [PATCH v3 7/7] ip_frag: " Stephen Hemminger
2023-01-22 16:00 ` Konstantin Ananyev [this message]
2023-03-12 11:28 ` [PATCH v3 0/7] add space after keywords Thomas Monjalon
2023-03-14 18:06 ` Stephen Hemminger
2023-03-14 18:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=671b92fe-e2cc-0437-e65e-93f33f88024f@yandex.ru \
--to=konstantin.v.ananyev@yandex.ru \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).