From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09CF142454; Sun, 22 Jan 2023 17:00:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A62C340223; Sun, 22 Jan 2023 17:00:54 +0100 (CET) Received: from forward502b.mail.yandex.net (forward502b.mail.yandex.net [178.154.239.146]) by mails.dpdk.org (Postfix) with ESMTP id 961EE40150 for ; Sun, 22 Jan 2023 17:00:53 +0100 (CET) Received: from myt6-c71a3c79aac0.qloud-c.yandex.net (myt6-c71a3c79aac0.qloud-c.yandex.net [IPv6:2a02:6b8:c12:422d:0:640:c71a:3c79]) by forward502b.mail.yandex.net (Yandex) with ESMTP id B693E5E8D8; Sun, 22 Jan 2023 19:00:52 +0300 (MSK) Received: by myt6-c71a3c79aac0.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id o0seO3teOqM1-97BtmWip; Sun, 22 Jan 2023 19:00:52 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1674403252; bh=N9AEq6OIArieQTIZ4yGHPD8lco0BdySyHkXqociizzU=; h=In-Reply-To:From:Date:References:To:Subject:Message-ID; b=JogUMgBye6RtPMdbyvyDEGgiaabriSTG5sDoE1w64Co9oZRZRT7pndNDkwlJ7Qfgg zoZCQzsArl5srTcLUoAfKfHPx+G1ByOAxq8xjJSUvk30+btP9lzBpbD0TFSi1aKlzo Ba8QNDScdJ+sNcqTYU19QGSMgJgDkHwnm+32sh4M= Authentication-Results: myt6-c71a3c79aac0.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <671b92fe-e2cc-0437-e65e-93f33f88024f@yandex.ru> Date: Sun, 22 Jan 2023 16:00:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 7/7] ip_frag: fix whitespace To: Stephen Hemminger , dev@dpdk.org References: <20230116172732.84976-1-stephen@networkplumber.org> <20230117001453.94082-1-stephen@networkplumber.org> <20230117001453.94082-8-stephen@networkplumber.org> Content-Language: en-US From: Konstantin Ananyev In-Reply-To: <20230117001453.94082-8-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/01/2023 00:14, Stephen Hemminger пишет: > The style standard is to use blank after keywords. > I.e "if (" not "if(" > > Signed-off-by: Stephen Hemminger > --- > lib/ip_frag/rte_ipv4_reassembly.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c > index 4a89a5f5365a..88ee0aa63f62 100644 > --- a/lib/ip_frag/rte_ipv4_reassembly.c > +++ b/lib/ip_frag/rte_ipv4_reassembly.c > @@ -34,7 +34,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp) > for (i = n; i != IP_FIRST_FRAG_IDX && ofs != first_len; i--) { > > /* previous fragment found. */ > - if(fp->frags[i].ofs + fp->frags[i].len == ofs) { > + if (fp->frags[i].ofs + fp->frags[i].len == ofs) { > > RTE_ASSERT(curr_idx != i); > Acked-by: Konstantin Ananyev