From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 788717CE4 for ; Mon, 29 May 2017 14:42:21 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2017 05:42:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,414,1491289200"; d="scan'208";a="92568555" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 29 May 2017 05:42:19 -0700 To: Matej Vido , dev@dpdk.org References: <1495821956-5050-1-git-send-email-vido@cesnet.cz> <1495821956-5050-5-git-send-email-vido@cesnet.cz> From: Ferruh Yigit Message-ID: <671d38c4-1c27-c7f0-5aa7-678f6731b6ca@intel.com> Date: Mon, 29 May 2017 13:42:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1495821956-5050-5-git-send-email-vido@cesnet.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 5/5] net/szedata2: add more supported firmwares X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2017 12:42:22 -0000 On 5/26/2017 7:05 PM, Matej Vido wrote: > Add IBUF and OBUF offsets definitions for new firmwares. just to double check, is it required to add new pci device ids to support these new cards? Is dpdk supported nics (http://dpdk.org/doc/nics) needs to be updated? Can you please update release notes to announce new cards support? > > Signed-off-by: Matej Vido <...> > +#elif RTE_LIBRTE_PMD_SZEDATA2_AS == 5 > + > +const uint32_t szedata2_ibuf_base_table[] = { > + 0x8000, > + 0x8200, > + 0x8400, > + 0x8600, > + 0x8800 > +}; > +const uint32_t szedata2_obuf_base_table[] = { > + 0x9000, > + 0x9200, > + 0x9400, > + 0x9600, > + 0x9800 > +}; AS = 5 is not documented in both documentation and source code comment, can you please add this one too? > + > #else > #error "RTE_LIBRTE_PMD_SZEDATA2_AS has wrong value, see comments in config file" > #endif >