From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 444C3A0C41; Wed, 17 Nov 2021 11:10:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2D74410E4; Wed, 17 Nov 2021 11:10:08 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 938F040040 for ; Wed, 17 Nov 2021 11:10:07 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10170"; a="220804565" X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="220804565" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2021 02:10:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="454816179" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 17 Nov 2021 02:10:06 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 02:10:06 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 02:10:05 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 17 Nov 2021 02:10:05 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 17 Nov 2021 02:10:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j9l5DSM6T7LM9gPzRXkNZm+XF4SKuK8gRthYTMZVxu/8ojT7b+uV75G2ockeV+AyEfUnvMnyBOdcYdhVtnnmYtrF5+0NsZ/2Uynuq0hnNCU9XqVqCSZmVacOHfygAdRkelYG9T8PNIGrjnvwkvg71bf6aLSJg7RZIpiEKcEP+kxFQfkOB5jcb3EoO5kXCWl5r0krMFCADMFIa/YDyMkm1P4mJAKfY0ru2DEs6jwtFWKSo07CpDl6OAJDqjXPdo563rY75J6v5J659n0xZVCCyG2wjXTpQG2t9lYx05R4TvRaSryNAWiM24s1rpo5Dk+6ilgr5ZPQfkQd2bAEUsDInw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bOlUucvSxPgBml8dE3qV48TDG8SBXZ8W+1I+z1y8jeM=; b=OhQALAfypbAaRtfXksFBAbuCIyhknLyc/oUFx3JnogNv8Fwfr/j+Oeoonkn4r6IPSCzFACVodJ1BbR/E82RsWazPnQ6C+Y0KYnXP7T+Md0mbh8ulP8vYbQjjWTynkR4rONk+Np6qeBaNzCHXT4ZIcVADPaKeuy+tw104MeZ2FHU7g5heOMi9W85CAiFiRJP4Q+sD4a+i2FhEGOf7hrDqv6pmqqlih/W/A0Sv/TAtaQYE5JUkp8Iyo/tuQvAEigJPqZmi6YhsxKvkNgyTu+JpLabPDknCuyyttv025aM59nqFVx2G5o1YIRD6kE/E1K9dPBx5IYnsYedIp4JXtXN//g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bOlUucvSxPgBml8dE3qV48TDG8SBXZ8W+1I+z1y8jeM=; b=B1FIBtOfBOUYQ4baH0nfojlwiTtnvE38J5Lrd4xvR7qmKn+d9a6UleHUJlyDBTPQjQMHfAcPGkL8DvVhrcPW+9SNeRp3MlSVku0Cm6sKt9qfjHKrehPa057HIc80HVyroagxYSYs04n9Tsx7EueQZHSKqKESPtOGVrbaGfA8ZBc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4821.namprd11.prod.outlook.com (2603:10b6:510:34::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Wed, 17 Nov 2021 10:09:59 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.028; Wed, 17 Nov 2021 10:09:59 +0000 Message-ID: <6725b879-c2fd-3902-eee0-2b5ea284562b@intel.com> Date: Wed, 17 Nov 2021 10:09:53 +0000 Content-Language: en-US To: Gregory Etelson , "dev@dpdk.org" , "Ori Kam" , Viacheslav Ovsiienko CC: Matan Azrad , Raslan Darawsheh , NBU-Contact-Thomas Monjalon References: <20211102122421.4190-1-getelson@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH] app/testpmd: fix tunnel offload validation X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR03CA0018.eurprd03.prod.outlook.com (2603:10a6:10:be::31) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR03CA0018.eurprd03.prod.outlook.com (2603:10a6:10:be::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Wed, 17 Nov 2021 10:09:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 346aefe0-a856-43a4-94a5-08d9a9b269bf X-MS-TrafficTypeDiagnostic: PH0PR11MB4821: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F4XWEp9gzMuR0iMCY/8ZbBAfSV42EOm/QmXvMNEAguzg8YGuKG6wSP+RjvqVwlvnAAzC1fUyP5cP+mShE/ZnleMpZsVGyEA/yNSGgtYekocXdzzYkcslMbW4SxGy42FjlS1LPf2l9zxwIEfqEKYhm1RcWM2vN8aJ9NDlUbMkaX3UQt1au1JvmRJgixgvQ6gwmSvvqe0lTbLs7s5usGvm6W/Uxy0GIAjruutomu161PoR5bno4JXO0fQXY5oT1bdxWPbroZ15P6ONKWg9o4kBvFVqMe42ZNHgQLW9BLR84BpNQlUd4BOTBAFuBEg5EUm+oSsmGB6nj16jKvZnBkFvLHg+rK8UKX1Wxz9LiZl+ysdrcrm1svELzRVfzrjruPYNeXydfdaSyBITyvTG8qOioz59kERhZtMCL3MzIs28xR4oJLFGmj0m6Es713oqGuTQbi0muyWT62wPI1TSjCqyKT24jBi0MTl7gPLlMq+ZE1gdESlT+docLdUagdAdgl+UY7t32CjOadKOZrGP7Vc0btnqQzQ4WmfJrt0VJ6UYBAcuGjxBYuQD2lpbytfKUcQbZ1NhP9B/gHwfwTUX/+6WsKHJgFPSsL076gIrIOLVFA59tYxlA+S/Y+deWDhWS3s+bpn55/8PdrLFirDgb15rUegWIyAoP7CZ2QCG7uCyPLmRZNFKbxAHX2cvGxqL5gOlP92jgKIMDsBMwJCzQjIFUg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6666004)(508600001)(6486002)(31686004)(956004)(2616005)(44832011)(316002)(110136005)(54906003)(16576012)(8936002)(5660300002)(86362001)(186003)(8676002)(26005)(4326008)(83380400001)(66476007)(31696002)(53546011)(66946007)(66556008)(36756003)(2906002)(82960400001)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHJWYXJVTmU1MW9KV3NWTEh0QTBsajdlNlkxR0IxRFRscmNxTEkrQ294SEpx?= =?utf-8?B?SzdKcXozWUtSSWlkQTZvUHZCVU5RaVU1RkRpWmRveWIxMWpmMysxVU16YjdP?= =?utf-8?B?bzdXRXl0eTdXcy9uMGVFL2gzZmxlR2hoVnJYQWhodElGeGkxMFRGdU5TV3Nq?= =?utf-8?B?TUcwempkNldNSk9OWElKcy8rUS91Q3B1TFVlWmx3d3BZUG1IcXZHTzhUM0E1?= =?utf-8?B?K3BRcXc4eGNPakpnNkw4WWx3OEcvZWVGdGlVZ2pSSHIveWR3K1hMMWRXL0lC?= =?utf-8?B?emtvNTFNZTNFR3hUdVIwYk5sUFhTbGozSVROVEdpM3g1ZStORVZ4cWwvQjRX?= =?utf-8?B?MW80eUNoaVlEZXBiOWMyU0VmV2U5d3EwbUEyd2lwQXVHUTdWeWkvaDBYakFO?= =?utf-8?B?VG5rQzI0d1NWb1lyOUhQOEFjT1pKS29HWVIwSFlPakVqYlJBT09VSlJCYXFu?= =?utf-8?B?bWNVcWhmem9XRXlHbm5MbkVtRHNxSU1yU2k3SlVVNlF5Qk9KZ3crQnVGcGVN?= =?utf-8?B?NnFpc1VINDlKNjA1WHYvajhUWXBpNGFTczg5VkpCV0M3U2dZdGNRM01BcHZJ?= =?utf-8?B?VFdtZEpRZk5zS2s5eERQb1JOc0VSUVM2bUxRcjIwZ3NGdkZPVXVXV3NUcUhr?= =?utf-8?B?MVFEVk9TVnl5SGQ2Wjk0czJrUXVZdTlER2ZrTkx0WDhLMUNqSFFoQk9XTnFN?= =?utf-8?B?Y0hIY2MwUVArc25NNmFiLzM2cnM5TzVBbzcrcFhoY09DOW1zL2txL0paa2kx?= =?utf-8?B?YVI4RWhkR0doM1U1T3c4cEh3UE9DS3BsMjI4RWhkcjVRZEFDUUViTDZUdlFV?= =?utf-8?B?dERzUUxwdVIvbjRBb3VzZ2Z1Y1I3ek1ZYTNjbVFSMVZoSkNnYjhDOXB6RWFO?= =?utf-8?B?Z2JpTDdwR3R6MEZiL3o0Y2RKOFhxV3gzM3ErUVhWZ3A4c3RrNUlkWnA1MTU0?= =?utf-8?B?c2JEOGpuR0hGZzlmWC9FMEhFMEhmRjBnVVd5Y1FsL2VTdHVBN1pNVG5JdExK?= =?utf-8?B?dzN0a0hzMEFBUDlRNytaNVBMTkd1NWo1OG9UdmpzMkVZejR1c2gxdWJxYzJY?= =?utf-8?B?YTB6UitaL2ZCTUxBcEFMcWRReTZXTGIzYzZBNThLUmREejU5Y09VQVVaWUVZ?= =?utf-8?B?aElwWDFJYmZaSHhPRXZRUUJDdDFyUzljWkJEVzgveXN4b0pkSUN0bDlPVjMr?= =?utf-8?B?TTJzc3hiSzhOTGU5TVBoZlp3NlJOODFWTjhYeEZhVFRkUmxDZjZFOTRLeTJT?= =?utf-8?B?WDA5cWo4Z1JmUlY2bUVGMGlEM0srNktLQ3JsNFN1T1U2di9lMGI2bjhJMkN0?= =?utf-8?B?Tm4xQkUyRys4MW5lZjArVGxybXRHQ0kwM0cveXowRUlHWmtWR3NFTXplWlRs?= =?utf-8?B?UVVYWDc2UE81QmYySzdZNDExdGtCYW54V3NrQ0xEYlhFdnpEUGhYa3JncGJW?= =?utf-8?B?Nk1xM0RFK2RuWkVEd1VVV3hHRzJQUDRnZGN4STAvSlZPRXEza3NxUG5yMlhk?= =?utf-8?B?U3RuVzhSczV4ZDJydnN1STZNR0NBUHVZc2gzVnlLeXZMK0UxUHpPcnJGRGZh?= =?utf-8?B?clFLQjlTR1EzMTZIRW5kTUt0ZVR6eFNqWnRqZU85cVl0dTIrTWxjSzVkT0hp?= =?utf-8?B?MUtHUTB6cENHNjAvbXlCMm5xYVNLZEVzaHMvSEc2MGV5eFl3ZHNVRU9oSlhE?= =?utf-8?B?L1NZcHBveG1MVDNvUW9XTzlJdkNZS1FjUEtvMTNySmRHUkpFa1haaU9EcHUx?= =?utf-8?B?QjlzMGFCcExtdU4vYkpRMmEvZVBkSlhjK0NRWjhhRVZMMG5xTjZ4MlMxVTQv?= =?utf-8?B?Ym4zdjVsblp0dXorK2owNW9sQjBONGRlcTQ4VHlQR2NXdEhVUnB5OS9xSXpT?= =?utf-8?B?c3k0VTNOK2VINnNjZHhjSzNGL24vby9WejJpaE1ud2NnaWhZMkhBTFZKaWtH?= =?utf-8?B?NzFHNCs5d2Mzd3FBSGhkQ2N6ZEtyTGJ5MnptWmIyUnowVmpmOWR4NkJlQ0do?= =?utf-8?B?OUJEYW43MEY1S010UEF5Qk0xTW9ZRGl1VkRXT1ZaSlR4L3h0SGNyMGFUTGEy?= =?utf-8?B?Y0dTckxxZk1Dci8zbTRSVmYrY1hHc3I4SWwrdWFjZTNoak5wejFqekQ3N2FM?= =?utf-8?B?WmlMOWJXWUlLM1pMQXF2YTlkbWZGbXZibkpzN2RDUlpiL0VCOWkvNkRyMXdY?= =?utf-8?Q?5JGLq9mAaqlN3czEFfswHlc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 346aefe0-a856-43a4-94a5-08d9a9b269bf X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 10:09:59.5182 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vv8NOczkM0Lautbtt5R1Leq9z0cGTLc5nYGAOi2g4/ni/qSrtkt4d7YDnsv3RePhkWpeX8KPkEwWJXKa/bhyGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4821 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/17/2021 8:57 AM, Gregory Etelson wrote: > Hello Ferruh, > > Can you estimate when this patch will be merged into 21.11 ? > Hi Gregory, It is not merged because it is missing review. Ori, Slava, can you please help with the review? > Thank you. > > Regards, > Gregory > >> -----Original Message----- >> From: Gregory Etelson >> Sent: Tuesday, November 2, 2021 14:24 >> To: dev@dpdk.org; Gregory Etelson >> >> Cc: Matan Azrad ; Raslan >> Darawsheh ; >> stable@dpdk.org; Xiaoyun Li >> >> Subject: [PATCH] app/testpmd: fix tunnel offload >> validation >> >> Tunnel offload API allows application to restore >> packet to >> its original form if chain of flows missed after >> DECAP action. >> The main idea of the tunnel offload API was to >> query port PMD >> to provide flow elements - actions or items. >> Flow elements supplied by PMD are merged with >> original flow rule >> elements provided by testpmd operator to >> create a new flow rule, >> optimal for PMD, to implement the tunnel >> offload API. >> That flow rule transformation is hidden form >> testpmd operator and uses >> internal testpmd resources. >> >> Current testpmd did not release tunnel offload >> resources if flow rule >> validation failed. >> >> The patch always releases tunnel offload >> resources after flow rule >> validation returns. >> >> Cc: stable@dpdk.org >> >> Fixes: 1b9f274623b8 ("app/testpmd: add >> commands for tunnel offload") >> >> Signed-off-by: Gregory Etelson >> >> --- >> app/test-pmd/config.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/app/test-pmd/config.c b/app/test- >> pmd/config.c >> index a18871d461..4870aaeba6 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -2011,6 +2011,7 @@ >> port_flow_validate(portid_t port_id, >> struct rte_flow_error error; >> struct port_flow_tunnel *pft = NULL; >> struct rte_port *port; >> + int ret; >> >> if (port_id_is_invalid(port_id, >> ENABLED_WARN) || >> port_id == (portid_t)RTE_PORT_ALL) >> @@ -2037,10 +2038,11 @@ >> port_flow_validate(portid_t port_id, >> if (pft->actions) >> actions = pft->actions; >> } >> - if (rte_flow_validate(port_id, attr, >> pattern, actions, &error)) >> - return >> port_flow_complain(&error); >> + ret = rte_flow_validate(port_id, attr, >> pattern, actions, &error); >> if (tunnel_ops->enabled) >> >> port_flow_tunnel_offload_cmd_release( >> port_id, tunnel_ops, pft); >> + if (ret) >> + return >> port_flow_complain(&error); >> printf("Flow rule validated\n"); >> return 0; >> } >> -- >> 2.33.1 >