From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9614A04F3; Tue, 7 Jan 2020 17:15:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FADF1D9F9; Tue, 7 Jan 2020 17:15:50 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E54531D9F2; Tue, 7 Jan 2020 17:15:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2020 08:15:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,406,1571727600"; d="scan'208";a="233242359" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.107]) ([10.237.220.107]) by orsmga002.jf.intel.com with ESMTP; 07 Jan 2020 08:15:46 -0800 To: Stephen Hemminger , dev@dpdk.org Cc: stable@dpdk.org References: <20200106205553.3696-1-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: <673dc1db-d238-6fcb-32a7-f7100d624b18@intel.com> Date: Tue, 7 Jan 2020 16:15:46 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20200106205553.3696-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mem: fix incorrect munmap in error unwind X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06-Jan-20 8:55 PM, Stephen Hemminger wrote: > The loop to unwind existing mmaps was only unmapping the > first segment. > > Also, remove obvious redundant assignment. > > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > Signed-off-by: Stephen Hemminger > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly