From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C99FA00C5; Fri, 14 Jan 2022 20:17:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 803FC4277A; Fri, 14 Jan 2022 20:17:00 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id C5E0440042 for ; Fri, 14 Jan 2022 20:16:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642187818; x=1673723818; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=6v8aC3KG6+YczRnyCsjIFkvPtlyz0A6UYnWY2D0G36E=; b=PVyVAbL/PkR94bo7syZx2Hu1Ts14/pXtd3HiM7bIwH6NqH+UDeJE/YHY eWmueofnHJQs8vEqjkJvmYYuQ6tMp7PIWcpAQGijbKsSwA9eJenDxbizp FDqo1zzTtVh63wxLMgCNXLoUKbCy5gkGQRbkPLTwBaWLtTgMCZekRMWZ/ BN2iLggxp2y232Pijs6o9HCw/L4ymSjeQpt+mdCzwVSDbMQ5GZEHpiiGB vFob+B2lrPO0tFbTvUKrebzlCTPnpzY8KEUMOXN/5fVYNOv/vSuzhecI1 kYqvHYCzO33YbMsMFjJEvxDc26CHYITzF31lga6IVVspNb02XvhUTIyAV w==; X-IronPort-AV: E=McAfee;i="6200,9189,10227"; a="244267850" X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="244267850" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 11:16:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="529439017" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 14 Jan 2022 11:16:57 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 14 Jan 2022 11:16:56 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 14 Jan 2022 11:16:56 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 14 Jan 2022 11:16:56 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 14 Jan 2022 11:16:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CF7jKEadTUjgOeHBmnbFXxX39Xx5yExDvIT1lrDzxxi90ew5QHjKwDp2ZmXssq/BHF/PNXHheGSa9ZVkOq+aenot0rLB8aMvPCl2RwNssc/o8QcXjyK4sswefLtC3u6R5STtrYoH77MuDk9ZBnea/Ieqq1dRkNr2U0lzNaO7B85OnOHr6fu3Bgic4HyXS4lY1E6xjrYXBdeuBBzad6WB6sSUCX2mhi2u7rvn7HFhah19MPVGIwRTONvhLZaQxK/11W894exFONquki9W+XSFhCWUEPtq1LHJpr1A1kYaVgR0rxkjkRBdUGIN+XYy+wQPiiVMSGZqwFUXmNk/8nIxJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RLvQahXZamXn2f5msdiVNGVIBfVFtvZzzlLwviMFzr0=; b=JHLGLlZsvFiTwZVRCbddCGmv3HwTZckpepYluhb6tMDh+0qPrzB2UfLOZ7MTUnFGAMnpOGGJ/WCCrEtpls3EGnqbYxwt8vv+klKA5rqdVf3cw3ZMgxJyrResPrU87leCX2N3wVNqEM9vPavXFL1tMFW1UmkKpVQrtcpcZfQ+lRQnNyHahCu/LZsdm+guTuuoFqjCh/8O9c6zBKaNcKDxWMVX7eBm3HeBmI4fWN7Rim+JvEqjtFGkvKzIwko5lDmruj6rpYwJQ1XTZ5jYjEnRlzwnWcv8YJd3kL9IWhAY00blnpP8ueW1IqTwGumnLbQljADY9UaDKwsGkbDp0GdQxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5768.namprd11.prod.outlook.com (2603:10b6:510:131::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Fri, 14 Jan 2022 19:16:55 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4888.012; Fri, 14 Jan 2022 19:16:55 +0000 Message-ID: <6745907c-5324-1cef-1848-dbff2b507456@intel.com> Date: Fri, 14 Jan 2022 19:16:49 +0000 Subject: Re: [PATCH] net/mlx5: fix RSS expansion compilation Content-Language: en-US To: Gregory Etelson , CC: , Viacheslav Ovsiienko , Matan Azrad References: <20220114151606.25617-1-getelson@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220114151606.25617-1-getelson@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0147.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b085bff9-7830-4abc-7d9b-08d9d7926d98 X-MS-TrafficTypeDiagnostic: PH7PR11MB5768:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1388; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LiIYwTPf9OHOcpgQQw7Qa2NjUP9IlkMsKN7KundzE5nPLvh/i+UXmU4UngFwsZ15roa5llMCn0m1SWm4QOvj5YZWyAuX2cd7l7NqGy6wPUTdoM9U5TVjezHzi0lq2ryQ+zgjZTZUs2g67IHTDX5xAJpfC+BriULn21Zs/0UCLb2yhoAby5nxiYGLhomDX5mwbTYhX5xJEoszK0WzIhkAiFU9C/MvIU+tyVcPaLODmzX42I23Tluead6dKgAUnCXGmvWKK0I8C3UgyO88kc6MQ5kau6MNo3pDsnozIZgq1BKaWB6ZgzAOGnr72f+Ab++q49pgqA+hEgMQM0P+FaLKKSW8tEh01Zn01NKksoT6CVbICdUob2pxtb3urI2YtiQZOMgh1vIDDuWNYyivbhekGUOTS0vlK8mu6bbWcOxXcNhR/WUQmTwQQ8dVKMHkBBbfratY1jb4o0cQ9S0w9AGju5O/7UZT5qvgIMm13gVut75eehiBdlCssqrxk+xWj3CJDt83iTElY6+siEgASsBVIXTfxvLEQMoApD6eSkW6HV3MBBj3aqQapNOffJHhPII8XGv4WsySeQBMKz1Ax0Ue2af0XViXPm8t6CNx3u4AORVTUM3EaD73Ak0ar3EqXMd54rVEBfRsKuCtmNGUq1wkM+DYRcD7WKdLH0y14lHJ1HTCU4pCgo1H1ti6X6EJiGSDuylLRhEHINAJEIpJKIm/eg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4744005)(8936002)(82960400001)(26005)(86362001)(6666004)(54906003)(186003)(66946007)(36756003)(4326008)(6506007)(53546011)(2616005)(31686004)(44832011)(31696002)(5660300002)(8676002)(2906002)(38100700002)(6486002)(508600001)(316002)(6512007)(66556008)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmNycFVsdHdBdmFCQnY2QlQ2bUZGNVorV29yTmFkOXVjSExTbWpSQzlWVUc1?= =?utf-8?B?Vko3RlNSSk4rNCtPSk9DNVJrVHJoSDJLa0FVK1FDbXZxQXU4MisvbWdMT29E?= =?utf-8?B?S2prV1JQU3grdjFiL2RKVkJydlNuRmYrYjFzbWlJVnpGTzhzclhLOFFHL20w?= =?utf-8?B?eVdzWFdZcDYzNGlZY3ZoME1oTjRrQlNoQjYzSzRpWjM1cjU5VUtxTDRJOGZT?= =?utf-8?B?OFpQM3RwZ3RYWVJJTHNWd0R1YW5tRUdRZWVJL2t5SFovUnVmMERhKzBMUHU2?= =?utf-8?B?REprVm53NVphVk1NaUVJeG1pSmEySmVldUN6YWg2Z0lEeVRFbGEyWEg5UVNT?= =?utf-8?B?UWI4aEhzNDQyR282dllOSTNJR1NMYU9LVXRVcXMyMXJ4SjIxc3JSbi9DNlNC?= =?utf-8?B?T3NrWHVRanByYWI5U1ZrelJJakZ0WnpDcE8rbHRXczZyRGQ0OUxhR2VLZHBm?= =?utf-8?B?V2F5RGlCT0N2TlBabThCTm5LbnZwSnRTbXlyRk5MWkFIQ2VZQUpobGRxZnFM?= =?utf-8?B?a2lFN3lld0VPc1pmVnFBaVhmNGFySE0zOHU5eEZ5aUVWcWM5Wjh3cnRmT0wx?= =?utf-8?B?cW4zNHk3ekhnalFvRGdsejZ6bFowcXcyRWNoUmNMMkVsV3hZQk03ekQydFlw?= =?utf-8?B?bTVGTG5iS1lSaWxoczkvQ21aU1hMbTB0S0NQbFlkSlZQM0pvR1JYbXVMRFNF?= =?utf-8?B?dWRjTDV1KzlJRkFMNzBWbFk3MlFDRmFMd1dRRGUyZTNRcW02UnlLeGZiRWRn?= =?utf-8?B?Wk55QkxMMWpxZ0ZpQjJubnB3Q0NIVnVoQUpmdkFtL2pYWFZMNzN0VHRrMDA5?= =?utf-8?B?d3FuZXljYmRwOGwzVkpYTk1ra3lySjBwTWEvMDArWEVMODMyZ1FXU3NkaWpU?= =?utf-8?B?WEdqWkY1RDhQS21ia2Y3b0xCRkVxL1IzMk9aL3V3a2tDMTZESDNpTzl4VFlY?= =?utf-8?B?Nkt3UWlWOEFua0FrdmpDU3UzbThUWjdTSVNjUzBDOGJHeWFkcGZ1a1pvbHpP?= =?utf-8?B?dHJ4MngyTzN0WHJrSWpFTFZuMmNoOG5sVWJlcEg1VG9jTmwwSU5yMFZXcXpK?= =?utf-8?B?Ry9ZMWhyK055cHZTN1VuTHdsRit1UVJXckwzeUkxcm5jL1owaUNPL2V4bWRh?= =?utf-8?B?MG5JSHJIQkVzcHRFWTUyTytMYVRwWVdqaUhja2QzMTdZZldEY1BSRDFWSWhX?= =?utf-8?B?U2g3R1lFRVdGcnFxVEhMbHdNRUxySWlSMlIyT2owOWR3cGZJSTExV0RRSEs5?= =?utf-8?B?YWZKMVR3UVdKbWI1VXdxYUlOM2dYNmN3b2JIY0pyUmxhbGJIcURjbUNsWmFU?= =?utf-8?B?MDB4Y0N1NG01bjdFSkwvMGJPTTZGYk9nVkg1V3I4aE4wUkQ0MUFvL0s5WW12?= =?utf-8?B?cE4zRnlDZlYzYURNKzRsOGhOUjIzQzRvR0FFMUFmMkh6dllBcFAxaFJHSTdK?= =?utf-8?B?ekt3TWNCTlhSZXk4Z01RRGVCeExUT29ZN0NNUHFxemgrUXZ1cmtVUS9nS3g2?= =?utf-8?B?ME81dHVOQWI3Y0JKbHBkZnB6WDJzN0dJTlhBUlVOc2h5UC9ZWTdDZkJMOUhq?= =?utf-8?B?SnRjUERPWGJ6d0R5cE1MQ1dEcUxsYkdEeTVDNGxydm1hbjY0YWsrbXppRVBl?= =?utf-8?B?S3dzL3pFR2pOZlFuMERwVHNrb0ZGNHF1eHBMM0IyUllLZnFHRDdVN05yeDRx?= =?utf-8?B?UFFpL3hxSVdJZTR0M2dxLzlxN0lHZ3MwWmY4dDFzeG52K2FBOFBNUEZBWk9a?= =?utf-8?B?OEZjQW5DUzZqd0ZJTEZuQWVXWDlNZlBKRGNpRVZhSCt4WGhKTjkwUzlBZGNB?= =?utf-8?B?MjBYV2xxd1NyL3BZM3JGdCszN0t5cEYyczl2bWEzV1dUSXJCL3ZQdUtncHZK?= =?utf-8?B?NXA3dnV6cFNIUE9JZWIwQmFpTGtVWml0STFwNWtCbnVEY1J5cjVodXo0eVFJ?= =?utf-8?B?Rm1WbjJuOE8yQ2I5M0V1NEFyR0prU3VtSnVMbStHaFpMMTdvNkYzMUlYMFFM?= =?utf-8?B?ODFkS2xJNzRjZnBmcitvZFVod0xPQVhGbWJKYURiMVl1M1RIMkdKTSswMEFW?= =?utf-8?B?bnJUbG85eE50QUI3anltVHpreDZHMW8vTFpDMkQ2VHZ2RktmQ3dVSE5VbkFz?= =?utf-8?B?Q0dqOVgxSndlZkc2VDdRQlM2NndrVGJ2ZlFweGFESzBDaVJ6T21SRUJaMncx?= =?utf-8?Q?d847hb2k2PoHpK/BlICJOKw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b085bff9-7830-4abc-7d9b-08d9d7926d98 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 19:16:55.6979 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4YYzvq4D3KYi5bkwxJe2AnndItQpEoTzdHpxRjgEBf8am2R0+OOLfKJ4rajn3wv4sM198ow6A3vvAu7bkmHwYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5768 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/14/2022 3:16 PM, Gregory Etelson wrote: > For each item in flow rule pattern that can be expanded, RSS expansion > scheme returns ether specific next item flow item type or > RTE_FLOW_ITEM_TYPE_VOID or RTE_FLOW_ITEM_TYPE_END. > RTE_FLOW_ITEM_TYPE_END means that expansion has completed. > RTE_FLOW_ITEM_TYPE_VOID means that next flow item was not located yet > and the procedure will continue. > > Current expansion scheme assigns RTE_FLOW_ITEM_TYPE_END for L2, L3 and > L4 rule items that set next protocol value to 0 in flow item mask. > The correct value in that case is RTE_FLOW_ITEM_TYPE_VOID. > > Fixes: 342a22ef3928 ("net/mlx5: fix RSS expansion with explicit next protocol") > Squashed into relevant commit in next-net, thanks. Please double check the code in next-net. > Signed-off-by: Gregory Etelson > Acked-by: Viacheslav Ovsiienko <...>