From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2008D42401; Tue, 17 Jan 2023 22:10:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2CF44067E; Tue, 17 Jan 2023 22:10:54 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id E5C9840151 for ; Tue, 17 Jan 2023 22:10:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5CECB5C01A6; Tue, 17 Jan 2023 16:10:51 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 17 Jan 2023 16:10:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1673989851; x= 1674076251; bh=VOEUqtUQrLLTxAhubNBSq/L42phYlMLaIGGhubOD+vI=; b=K XCklZLOVIJduAlIbbJ9ptLrvs4yCnzQcfqw9goXF1HEW5TjLc4lz/5AtDotRGxhT Remxo4j+o+0jqNWsildttbKdWNMatn0AvqENxyJkL6Rqhj+CRFXrbmqfBky+8jO9 Horrac5Sf5cdqA1K2eHwbQ/4U6CWGaQCnAjqlZpJR6By34phhTQh029OIHxk8Nh3 CLdzXddvpEdOeYs2M36XVdVeX616UpYY5cqufwS4MB5AzaxoWdhXCBzyDrP4o1ly shYD0mhzVdwJpMzpU5DPIiRwpVxiOm6+3rGtOlXyB+GcAICgFCU0Ze1GfhQqQajo 9Zxcrxcfs+Ie54dudOGGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673989851; x= 1674076251; bh=VOEUqtUQrLLTxAhubNBSq/L42phYlMLaIGGhubOD+vI=; b=V zoaJfZMj1DbuUtJ9vwdwuFGxEt2Tdjb4SqEPKy65VW0NKg6MDJSwLGerTb1NH87F HnClCuzbGsHtatLFTczL7sjVpNmYv17rjEEZwwj3ENEkuqayrE0TZ2WGw8xwqVp7 sGv+EyndeRSwchnJN5L8Pfe5NYk3t7144m1ISuzNPZ+4bngFSmLWjR0byjLrDOMz q3BPVyor42PYV2iY02XibysndDP6VHIWMs0acyLd1BHzfPofl0SifUzeLfvQGrnL qA5KmcVlQqiNmrNPT26wFK+SX27AUFzdymOb3ps+o+wV6FDFYsvLxJPhO6cTys+3 zIEHA7qdjCt20zeewzYrQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtiedgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Jan 2023 16:10:49 -0500 (EST) From: Thomas Monjalon To: "Zhang, Fan" , Jerin Jacob Cc: David Marchand , Volodymyr Fialko , dev@dpdk.org, Jerin Jacob , Akhil Goyal , anoobj@marvell.com Subject: Re: [PATCH] build: fix missing crypto vec limits in version Date: Tue, 17 Jan 2023 22:10:47 +0100 Message-ID: <6754457.tM3a2QDmDi@thomas> In-Reply-To: References: <20221206092329.2250774-1-vfialko@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/01/2023 17:25, Jerin Jacob: > On Tue, Dec 6, 2022 at 2:58 PM Zhang, Fan wrote: > > > > On 12/6/2022 9:23 AM, Volodymyr Fialko wrote: > > > Add missing function `rte_event_crypto_adapter_vector_limits_get` to > > > version.map. > > > > > > Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type") > > > > > > Signed-off-by: Volodymyr Fialko > > > --- > > > lib/eventdev/version.map | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map > > > index dd63ec6f68..1a7fffd17f 100644 > > > --- a/lib/eventdev/version.map > > > +++ b/lib/eventdev/version.map > > > @@ -20,6 +20,7 @@ DPDK_23 { > > > rte_event_crypto_adapter_stats_get; > > > rte_event_crypto_adapter_stats_reset; > > > rte_event_crypto_adapter_stop; > > > + rte_event_crypto_adapter_vector_limits_get; > > > rte_event_dequeue_timeout_ticks; > > > rte_event_dev_attr_get; > > > rte_event_dev_close; > > Acked-by: Fan Zhang > > + @Thomas Monjalon @David Marchand > > 1) Sanity is failing as follows > ### [PATCH] build: fix missing crypto vec limits in version > > ERROR: symbol rte_event_crypto_adapter_vector_limits_get is added in > the DPDK_23 section, but is expected to be added in the EXPERIMENTAL > section of the version map > > This patch is added in 22.07. New patches should be experimental. > Right? If so, Please change to __rte_experimental and move > EXPERIMENTAL section. If I am not missing anything. Yes new functions should be experimental. You need to add a comment in the .h and the attribute __rte_experimental. Such issue would have been seen earlier if the new function was used in a unit test or a test application.