From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99030A0C43; Tue, 11 May 2021 22:49:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B44A4003F; Tue, 11 May 2021 22:49:53 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id B8D634003E for ; Tue, 11 May 2021 22:49:51 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id DDCDF5C00D6; Tue, 11 May 2021 16:49:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 11 May 2021 16:49:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= IHHQ81l49jUghAe+/DAppPZbejT5b8QkSbCcvrXAiZE=; b=eSEEr0NLtvBdJBO1 1yePGPRlT+0X9o58BzMK2wUs/q1G5BzS3KOyiYejJhVjEuekAxo05Ydxtx2zKjUP PUwmRgxEUzqxZutn7h1DRpa5RO+tyQZSo4z9brWEWNOJpVgbAFflBz1W2asSyzQM Yg3u9fLz7cc7at4RPL5RLUaJbGx/hvNr6rugktzEI6SGh6aG1GhvglV1IxgYTcdi EaCgvYRW5HV35++Y8X5ci4XyRthsNv/oOMANlqSaUES1eJ1UFdVcFsEtrgTB7QUP WuX6wiLubf5BvUT3zncXnsSyjzpUsKSX1oNRP5cYPbj3WC5+uhn1KPX/pSc+NY3a DjgpoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=IHHQ81l49jUghAe+/DAppPZbejT5b8QkSbCcvrXAi ZE=; b=nfqQZOdPpW8Z43Bhv+gwrvxwIZ3nGs1BVzTgO4CCokUt/vi88/qH6w3fW lhk6V8E5APE1qPzupLXWZcWHY4zpD9zIPCH6Cw9sgO0EG/4066Dtb2bq2/12a5Dn 4PH7MtkViGOm7a90T/4qj4AxniDNejW+EUtjfIIE9NiYBEIulH13joVO8+acKukz 0HAaukUpsc4eSsr/kyVahEQ69eL9oUGBzvfrFZpsraP0B31dUNHvdTLDSP7eRLAB adjH2YhEXLLf/aHVYaLCHVTQO0mnQPMJ2n+vODc2o0X+6SjIeRjWj5jQW6duvZcq DQuM5TkcDF8iU7xP6mdYF8oUWdxMw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehtddgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejgedtfffgudfgudeuueejtdfgfeffgeduheegvdefgedvtdej vedthefhkefhhfenucffohhmrghinhepohiilhgrsghsrdhorhhgnecukfhppeejjedrud efgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 May 2021 16:49:49 -0400 (EDT) From: Thomas Monjalon To: Kevin Laatz , Sunil Pai G Cc: David Marchand , dev@dpdk.org, dev , Bruce Richardson Date: Tue, 11 May 2021 22:49:47 +0200 Message-ID: <6755478.LoOD6Ik12Y@thomas> In-Reply-To: References: <20210507172025.181720-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] raw/ioat: fix parameter shadow warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/05/2021 16:48, Bruce Richardson: > On Mon, May 10, 2021 at 04:06:00PM +0200, David Marchand wrote: > > On Mon, May 10, 2021 at 2:55 PM Kevin Laatz wrote: > > > > > > In the function __idxd_completed_ops() we have a parameter shadow warning > > > due to a local variable having the same name as one of the function > > > parameters. This issue is fixed by simply renaming the local variable. > > > > > > This warning was discovered during an OVS build with DPDK 21.05-rc2. The > > > OVS build passes the -Wshadow flag by default, allowing the warning to be > > > seen. > > > > A bit confusing. > > -Wshadow only affects OVS code and there is no code calling this in > > the OVS master branch. > > > > I did not see this issue while updating my dpdk-latest OVS branch and > > running builds in GHA. > > So I guess Sunil caught it with his patch: > > https://patchwork.ozlabs.org/project/openvswitch/patch/20201023094845.35652-2-sunil.pai.g@intel.com/ > > > Yes, it was caught by Sunil in the course of his work. So the commit message should be fixed please.