DPDK patches and discussions
 help / color / mirror / Atom feed
From: Eelco Chaudron <echaudro@redhat.com>
To: beilei.xing@intel.com, qi.z.zhang@intel.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset
Date: Tue, 17 Sep 2019 03:40:28 -0400	[thread overview]
Message-ID: <675a204e3f5630d66cfa79b933da25a6c9227069.1568705792.git.echaudro@redhat.com> (raw)

Even though the device reset is successful, disabling promiscuous mode
might not always succeed, causing enabling it after reset to
fail. This would happen when the kernel driver requires a reset of the
VF.

This patch resets the internal state, so next time promiscuous mode is
configured it will be enabled.

Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 551f6fa..e0f99a4 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2276,11 +2276,21 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev)
 i40evf_dev_reset(struct rte_eth_dev *dev)
 {
 	int ret;
+	struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
 	ret = i40evf_dev_uninit(dev);
 	if (ret)
 		return ret;
 
+	/*
+	 * Even though the device reset is successful disabling promiscuous
+	 * mode might not always succeed, causing enabling it after reset to
+	 * fail. This would happen when the kernel driver requires a reset
+	 * of the VF.
+	 */
+	if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+		vf->promisc_unicast_enabled = FALSE;
+
 	ret = i40evf_dev_init(dev);
 
 	return ret;
-- 
1.8.3.1


             reply	other threads:[~2019-09-17  7:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17  7:40 Eelco Chaudron [this message]
2019-10-15 10:31 ` Eelco Chaudron
2019-10-17  6:34   ` Xing, Beilei
2019-10-25  9:23     ` Eelco Chaudron
2019-10-29  7:39       ` Zhang, Xiao
2019-10-29  7:47         ` Eelco Chaudron
2019-11-01  2:38           ` Xing, Beilei
2019-11-01  8:12             ` Eelco Chaudron
2019-11-06  4:58               ` Zhang, Xiao
2019-11-12  0:52                 ` Zhang, Xiao
2019-11-12 11:09                   ` Eelco Chaudron
2019-11-13  1:14                     ` Zhang, Xiao
2019-11-19 13:55                       ` Eelco Chaudron
2019-11-11 13:59               ` Eelco Chaudron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=675a204e3f5630d66cfa79b933da25a6c9227069.1568705792.git.echaudro@redhat.com \
    --to=echaudro@redhat.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).