From: "Liu, Yong" <yong.liu@intel.com>
To: David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>, dev <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86
Date: Fri, 13 Nov 2020 12:21:52 +0000 [thread overview]
Message-ID: <675c78af209e46a39db6294a8b5af16c@intel.com> (raw)
In-Reply-To: <CAJFAV8z3fFZLVfY-6Fg57YhZJTOtjKAnRgkcZy0D1MiuOMSxVQ@mail.gmail.com>
+ more people into this conversation. IMHO, restore to previous state is the best choice by now.
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, November 13, 2020 3:27 PM
> To: Liu, Yong <yong.liu@intel.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> <chenbo.xia@intel.com>; dev <dev@dpdk.org>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on
> x86
>
> On Fri, Nov 13, 2020 at 2:20 AM Liu, Yong <yong.liu@intel.com> wrote:
> > > Yes and this will also solve https://patchwork.dpdk.org/patch/83468/.
> > > Thanks.
> > >
> >
> > Agreed, original patch was intended to recover prefetch configuration in
> meson build.
> > Please check http://patchwork.dpdk.org/patch/78451/.
> > And it leaded a discussion about how to utilize prefetch function
> optimally.
> > Due to no conclusion for current position is best for other platforms
> except x86, now only enable prefetch in virtio + x86.
>
> I disagree.
> No conclusion means the best is to restore the previous state, i.e.
> enable this option for all platforms.
>
> If later other architectures want to change this, this can revisit.
>
>
> --
> David Marchand
prev parent reply other threads:[~2020-11-13 12:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 15:40 Marvin Liu
2020-11-11 15:45 ` David Marchand
2020-11-11 15:53 ` Bruce Richardson
2020-11-11 15:56 ` David Marchand
2020-11-12 8:48 ` Maxime Coquelin
2020-11-12 8:57 ` David Marchand
2020-11-13 1:20 ` Liu, Yong
2020-11-13 7:27 ` David Marchand
2020-11-13 12:21 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=675c78af209e46a39db6294a8b5af16c@intel.com \
--to=yong.liu@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).