From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00C1842653; Wed, 27 Sep 2023 18:37:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8714540271; Wed, 27 Sep 2023 18:37:59 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2043.outbound.protection.outlook.com [40.107.244.43]) by mails.dpdk.org (Postfix) with ESMTP id EDDCE4026B; Wed, 27 Sep 2023 18:37:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RLvifNIDXKVE1A1Vn0jA075xNuRppoPhirBiEVIKhKrKTkSfOexiJNblzU5hUSyL+3yNuYjePVyYGLnCI6iHyfyELpvHAYu3ts1pYnR1a5wyerikFEQU7BIPn40gkrFXd3+kr9Km44065cXs5PUNowyQIDN9hhn0cbjj3Oq3O/6CH7tOzIBcjSfqxY05M0wC82pmgbHJShpR/swmQjb9FPCJqZrvBdDItSy40UiIvCANS3D2/UW6Lm5e+UorQ1/ZV1t221/Zt8YQ4A05iNxbz1/aRhXX9N7WHTyICqEec8cyITakLBW5KodQWh/L3kvA2MFz/L82jHnAwwhf7XbVMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jxZ7XJtGzqRvJMf1684DJqdIxqYd2w7xKmNBb3nxwQA=; b=d9zowffeHlz8eUGK8aQpNpEunj73ED/92SxFT1qOeP9xi9JVO932u+LzAp7qMj+e89nUaiC4vXbL47hsaR84hCZ7W2YLwbKVcgwUz17YZiWjD8IPmPRJes0fsHbfsenVw0FhWK9tZQnO7TDoAOz7GBtoZV8oxQc6QFtDoxDU3UB1uzP8t1sV2mi3Sw+sHsDnQmMXvIBwUi/sWOEQf+8ezT2YEA3VFqei0UaklOr5WDLChOp/zPHeQ755L6Nlzt9TlGTWAttXLyLsNT+5fm1++ZA8CcT7dMlAxKE1dtBZ9HgLPavePiqfLIP2ND1y7Vd4RsoJ6YXbEliamAL1CSP6Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jxZ7XJtGzqRvJMf1684DJqdIxqYd2w7xKmNBb3nxwQA=; b=kSQDSYXfgvrBhXcn7E27S0qPLxaw+f35fwNcT8lN94hD5x4zGzFReXPWl4sLCELFgAG7ZMm3wx0iEsXOsPWVslkXZaTTv0Z6ZphaSjtjb1iexMIpXqbND/2t57ub/gDNBlZomUujeMsGDWykeE4JPyn2G1UAFnY7dDZoqiMqUQY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB6964.namprd12.prod.outlook.com (2603:10b6:510:1bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Wed, 27 Sep 2023 16:37:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6838.016; Wed, 27 Sep 2023 16:37:55 +0000 Message-ID: <67602903-563a-440c-87fa-182b056a177b@amd.com> Date: Wed, 27 Sep 2023 17:37:49 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] net/memif: fix segfault with large burst size Content-Language: en-US To: Joyce Kong , Jakub Grajciar , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Ruifeng Wang Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org, Feifei Wang References: <20230904071041.3403495-1-joyce.kong@arm.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230904071041.3403495-1-joyce.kong@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0597.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB6964:EE_ X-MS-Office365-Filtering-Correlation-Id: 427739eb-d157-40c8-b83f-08dbbf7819b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sXQKll8aIkikf2Eefz7TPY/BoFMSPxoyH3jdRNcDjm3f+Uj6Y1gxHDPGe9e3IuRLKU7ty30HLXnhrdWiXyliIHbsb2W9XoHqM+H4JNQHExFwFCXH+gN2kIYB3N3Wechpz885D07zl/XYtNFtbNKiGdZ68zxZ/SbYDsQrhY1mfCCVLOnX6m7+gLQPI+S8Jwr4DRmC2ouh5yBVjlGThiljnXsUgBEz5xh2HSbRvOLsAxQYMcRle9m7go7ci8v360Aww77F3onFtZcuA3qchMzzFnj5V7llJ04fAG4+cPThPLRQS3pLUrkJ+kMekL8ibsXJ1ZkvKC2QrVHIdScMOJYic8FduIfHHxIz5FE+LkH7f956U+l5RQlQ0mWk6moOCNJg9Lf6WZvOkHZEwRopIcU7fadT9bxjifpx+KCcQ7YVvYgHVmKb/K56dDTJR9dIUSqyEqmqB2kdrs1NoMB+yN9IO+nVT7b7+6pjZ2kq5eapappOCNjVlm1YKTSaR87UrI4ROQju12ahuaUUwfmjxdBNJG7sNTPPLRAUAij7GXRuRoJq+7uCOYUKuRdhrRZ16IuoGDKvaAeDhuO/JRVpHhcNClbGdTlQ4AoDurVoVqSrnSeFjWp1oi9CUT89qsjItXj98vBSyzD2FVom4lQ2kl7XCw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(366004)(396003)(39860400002)(346002)(230922051799003)(451199024)(186009)(1800799009)(6506007)(53546011)(6486002)(6512007)(6666004)(31696002)(38100700002)(86362001)(83380400001)(36756003)(2616005)(316002)(66946007)(26005)(110136005)(41300700001)(66556008)(5660300002)(44832011)(2906002)(66476007)(31686004)(4326008)(8676002)(8936002)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjNzb1VGb01qOGJCRjZ1YlRodU9PODZyWndMc21BR2d2TlAzTjArVnh1UDEw?= =?utf-8?B?bEVrUHo4c1crZmF0eFJtdlJ4VmtwcTlTRVFjSU1oMDN6OE9FbzV3ZHkzV05F?= =?utf-8?B?NGlaOTVMMjdJMTBIaVZvZjlUb0R4VnVFMmZBNzVyMHlDTzJvdEFxYnQ5eDJi?= =?utf-8?B?Y3lsMW0wSFBoaEZBbkMzTWxhTzV1eGQ1UGxKbWpaeXBRNkJtNTNMWVRlaXAy?= =?utf-8?B?RC9WL1FYSWNXYmcrUTlQdWN2c3BoVzBvcUpONFVsVkNUOS9FQzFpbm5jSnY3?= =?utf-8?B?czNWZWVpS2hmRjB1SG1TTnpERGR1ZVJqbnZTc1JKeDRBdklpMiticWFocTha?= =?utf-8?B?eTR3TkNhZ3QyWFpiMVA5cWZWYmw0V3RmZVZMNXlIVjVqdHkvZW40L1BKaTRX?= =?utf-8?B?YitRWHFxV2NZM3p1SnNtRVB2dVFhRHNjalJ1UWZIam0vSzJ0YnJqS0dQaG9D?= =?utf-8?B?elZ5cFJ2RG53OS9RRldHTEhHSFRBc21KVDMxMW1OT0xuQWR3Y0lwaTB5Wm5l?= =?utf-8?B?azFwRTZZc2xCYXdkSGF2MTJuVG5vbEdydU5kdlZoVXZ5TzR1eTFtakdFMzd5?= =?utf-8?B?SDJHZjBlN0FOaHl1UEovZTJuaXgrcW1LN29aakRNc0xmdGFiNFZuK0tJTkhy?= =?utf-8?B?dkJwZjhrNkNZT050dUpDMHJjaHVZY3VzT1BLREwwZDBuTmNJcm52QlFVT2E5?= =?utf-8?B?MzdybWlMRDhBUmw0b2VPdWo1djRBOXBaL29CQkpIaFRxaVN0QlprenZRTG9N?= =?utf-8?B?bDBlMS9LMXR1SWNHT0FTckd3ZnNmU0RoY3d0L2pjRC9NcVZ5NDE1bmNLYzBo?= =?utf-8?B?ZU1wK2Ztd3dGVDhsMmwvaXNKN2VvNlVqUUFvZ3dVQ0dodUpSenZOSTdlL2Qx?= =?utf-8?B?OHRITHJwUWhFbVMvdytzVmpTd0ZUTDNJUkJPK0kvVnZpTEpXYzZEeWNtSTZX?= =?utf-8?B?Mk1TVUo1ZkNCOWMxWjArd05DOHpvK21lbllWbWFyWWp4cmJkQSs5dmJ0dTND?= =?utf-8?B?dnZFeElYemVrZGhXTHJ2eVFvN0xVdTQ0cnpSNGlQMWpJdjE3MXRFM05KbmNX?= =?utf-8?B?RVRlUnp4K3VGdFE3cnFyT3NZR3duQkdxVmw1RUhGOTdDK1ZBYXJLQkgwUmUv?= =?utf-8?B?TUpYNkNxUFFJbVloNjJLYWl0VkNuMlZTWEU1UC95L2xoUGt4em0rN0NEYmVi?= =?utf-8?B?Yy9kczdyT2FGNW1vM2k0bzV2cWUvbHpmK0RSbXl4NDlDWXRIQkZJOUVBa0RZ?= =?utf-8?B?QW1wdlpyVnNYV1FVNU9YN3BVRjZHNG5LN2RjdnZiMFlBRjFCRVB5NzVzdWM0?= =?utf-8?B?OTVycStjQW84eHNGRitHNXFETjc5NHV3Q1FSNVhwUTcvS1BDR2hNVkZ0VjlV?= =?utf-8?B?aG1ENWdrM3I4L0UvcWNaRzZvS1B0czVDak9jQWMrckVuRVRqSGhNOVNXUW1C?= =?utf-8?B?WlFPNzdMbHY2Y2lWMWZYcWdLWWlkZUJ6eVZObllKN0I4Q2hCaUdKa0ZUazBR?= =?utf-8?B?UlJjM2tiSGQ3b0ZBQ3pCdjhnODhMTTVqN2FKckhzdEp5Q3hUM0FZeVdveVpZ?= =?utf-8?B?Y0dDNWZreEN2WFVRcXhCZXhuWHZvNjM0SzFKbnpKdDZyYUxDdVFQUjBpa0s3?= =?utf-8?B?L3h0dTNEWStFRnAwdURoeXNhaHpXQ2dnOHQxUEFueUNkVEJFbXplcnpTSEx1?= =?utf-8?B?U2NmaHJONHVnN0lCdHUxQTdJeUZSSTY4K012MEYxZ09SYU1PVDFHR05XaHhU?= =?utf-8?B?VVZPN081OVJMeHIrWFlCWlJvTU9CUVViaFRlNUdvdlY3RmRVbERyNVVlT0dU?= =?utf-8?B?eWEvUzNCb0Q5YUt0VDlRV3h3ZTFRcWpURzN3K09JVmw0VUxMZWpHeG53MlpP?= =?utf-8?B?MzJvODgvMk5LbnovOUlNUklJWWlnWkdWZ2tNS0w1bGd5NWoyMms3d3V1WUha?= =?utf-8?B?ZkpUQlk4eU5ROFduQ1NhMWs2NmRpOUMwNVlUUjNnalZuL04zKzQvbmxvYjla?= =?utf-8?B?a2hwMTQvREpoNDZUckhheVZtT25sRWk0a0szRUJXVU0xeHoyUm4vajMrT3d4?= =?utf-8?B?R2wySXYxTk0wMXNjcHRUSUcvZ2d6RFUrRUsyNWZCQ0xhYjNwd1BnZ0ZNM3FL?= =?utf-8?Q?hcub0R2M83HnF2vu+qo+todl2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 427739eb-d157-40c8-b83f-08dbbf7819b6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 16:37:55.5660 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eDMmxqI3uWRIjp6z1/a4j6kO0RPJN+k1tO8ORdfEVB6iY2lErZYcIHF+S3w5uqob X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6964 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/4/2023 8:10 AM, Joyce Kong wrote: > There will be a segfault when Rx burst size is greater than > MAX_PKT_BURST of memif. Fix the issue by correcting the > wrong mbuf index in eth_memif_rx, which results in accessing > invalid memory address. > > Bugzilla ID: 1273 > Fixes: aa17df860891 ("net/memif: add a Rx fast path") > Cc: stable@dpdk.org > > Signed-off-by: Joyce Kong > Reviewed-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > drivers/net/memif/rte_eth_memif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c > index 6a8ff5b4eb..f595656af5 100644 > --- a/drivers/net/memif/rte_eth_memif.c > +++ b/drivers/net/memif/rte_eth_memif.c > @@ -356,7 +356,7 @@ eth_memif_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) > rx_pkts = 0; > pkts = nb_pkts < MAX_PKT_BURST ? nb_pkts : MAX_PKT_BURST; > while (n_slots && rx_pkts < pkts) { > - mbuf_head = mbufs[n_rx_pkts]; > + mbuf_head = mbufs[rx_pkts]; > mbuf = mbuf_head; > > next_slot1: Hi Jakub, Can you please look at this patch? Thanks, ferruh