From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number
Date: Wed, 13 Mar 2019 12:06:38 +0100 [thread overview]
Message-ID: <6766221.dD9Uvtf5Qj@xps> (raw)
In-Reply-To: <20190307133502.55321-2-bruce.richardson@intel.com>
07/03/2019 14:34, Bruce Richardson:
> Add a new file DPDK_VERSION to hold the current DPDK version number.
> Have meson use this file for it's project version, and have make use
> it for reporting out "showversion" and "showversionum".
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Luca Boccassi <bluca@debian.org>
[...]
> --- /dev/null
> +++ b/DPDK_VERSION
Why not VERSION ?
[...]
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
> showversion:
> - @set -- \
> - $$(sed -rne 's,^#define RTE_VER_[A-Z_]*[[:space:]]+([0-9]+).*,\1,p' \
> - -e 's,^#define RTE_VER_SUFFIX[[:space:]]+"(.*)",\1,p' \
> - $(RTE_SRCDIR)/lib/librte_eal/common/include/rte_version.h) ;\
> - printf '%d.%02d.%d' "$$1" "$$2" "$$3"; \
> - if [ -z "$$5" ]; then echo; \
> - else printf '%s' "$$4"; \
> - if [ $$5 -lt 16 ] ; then echo $$5; \
> - else echo $$(($$5 - 16)); fi; \
> - fi
> + @cat $(RTE_SRCDIR)/DPDK_VERSION
I'm a bit sad about removing this complex command ;)
next prev parent reply other threads:[~2019-03-13 11:06 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 11:54 [dpdk-dev] [RFC PATCH 0/4] One versionfile to rule them all Bruce Richardson
2019-03-07 11:54 ` [dpdk-dev] [PATCH 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-07 12:33 ` David Marchand
2019-03-07 11:54 ` [dpdk-dev] [PATCH 2/4] build: use version number from config file Bruce Richardson
2019-03-07 12:37 ` David Marchand
2019-03-07 12:42 ` David Marchand
2019-03-07 13:12 ` Bruce Richardson
2019-03-07 13:01 ` Bruce Richardson
2019-03-07 11:54 ` [dpdk-dev] [PATCH 3/4] build: move meson version handling to config directory Bruce Richardson
2019-03-07 11:54 ` [dpdk-dev] [PATCH 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-07 12:09 ` [dpdk-dev] [RFC PATCH 0/4] One versionfile to rule them all Luca Boccassi
2019-03-07 12:14 ` Bruce Richardson
2019-03-07 13:34 ` [dpdk-dev] [PATCH v2 " Bruce Richardson
2019-03-07 13:34 ` [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-13 11:06 ` Thomas Monjalon [this message]
2019-03-13 11:17 ` Bruce Richardson
2019-03-13 11:23 ` Thomas Monjalon
2019-03-13 11:27 ` Bruce Richardson
2019-03-07 13:35 ` [dpdk-dev] [PATCH v2 2/4] build: use version number from config file Bruce Richardson
2019-03-13 11:13 ` Thomas Monjalon
2019-03-13 11:20 ` Bruce Richardson
2019-03-13 11:24 ` Thomas Monjalon
2019-03-07 13:35 ` [dpdk-dev] [PATCH v2 3/4] build: move meson version handling to config directory Bruce Richardson
2019-03-07 13:35 ` [dpdk-dev] [PATCH v2 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 0/4] One versionfile to rule them all Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 1/4] build: add single source of DPDK version number Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-16 18:01 ` Rami Rosen
2019-03-16 18:01 ` Rami Rosen
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 2/4] build: move meson version handling to config directory Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 3/4] build: use version number from config file Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-27 0:27 ` Thomas Monjalon
2019-03-27 0:27 ` Thomas Monjalon
2019-03-15 18:20 ` [dpdk-dev] [PATCH v3 4/4] eal: remove unneeded version logic Bruce Richardson
2019-03-15 18:20 ` Bruce Richardson
2019-03-27 0:34 ` [dpdk-dev] [PATCH v3 0/4] One versionfile to rule them all Thomas Monjalon
2019-03-27 0:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6766221.dD9Uvtf5Qj@xps \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).