From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id B04744C95 for ; Wed, 13 Mar 2019 12:06:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id AFBB13837; Wed, 13 Mar 2019 07:06:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 13 Mar 2019 07:06:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=sksybWzaYY7f7PcFbVR/ESpabFm0gzD7y2LHGfZrk7E=; b=Z2ja8h23Aljh AzIuQjd51s8RxqFRTOJzxqFaXOeTgsTbVCJobw/lhCu5MQCzWlV5utnrPqiAsUdZ z0Ev5zqjhL1ZVERqiyX44rJ1XBXmmmwsyDOFsRZtPHP+Pf9JDq7GQjj+df77L4dU Aj73nospPnrX9vMrgz8xKZB6hrqotls= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=sksybWzaYY7f7PcFbVR/ESpabFm0gzD7y2LHGfZrk 7E=; b=qDRONQZePAC5uSqWN9pTg+8N+s1VZqLLB6t3IYB64mnZYsPMhLsYrGY8i O56fDrTP80c2K+vYWgA3NirY2uV4QJ9us5mUnLELnu/o1YIf3nzWJDNsjzVwjuvL GnnxFzJaYvBuSD/5nDTnYPQSxhPjocbjZEANVNmYPBhPQry38YoRN1Dy9jh/0Ls8 Eyncx5dKBolMC9jrVsp3DEBIJi83xxjRuReQDbEVQw6s5pw8mv4KexTg6mhkcyDX CHqeLgTFTgp67w9lV1Ip2YOtK2eX5CIpBzPNN3TxdoP9Ut5Pm2i8OmoWK1ESp8vA +R9cEc4bVXsf1zpxGJK9jQZIDH0UQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrhedtgddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepshgukhgtohhnfhhighdrmhhknecukfhppeejjedrudefgedrvddtfedrudek geenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E228710341; Wed, 13 Mar 2019 07:06:39 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, David Marchand , Luca Boccassi Date: Wed, 13 Mar 2019 12:06:38 +0100 Message-ID: <6766221.dD9Uvtf5Qj@xps> In-Reply-To: <20190307133502.55321-2-bruce.richardson@intel.com> References: <20190307115448.54041-1-bruce.richardson@intel.com> <20190307133502.55321-1-bruce.richardson@intel.com> <20190307133502.55321-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 11:06:43 -0000 07/03/2019 14:34, Bruce Richardson: > Add a new file DPDK_VERSION to hold the current DPDK version number. > Have meson use this file for it's project version, and have make use > it for reporting out "showversion" and "showversionum". > > Signed-off-by: Bruce Richardson > Acked-by: Luca Boccassi [...] > --- /dev/null > +++ b/DPDK_VERSION Why not VERSION ? [...] > --- a/mk/rte.sdkconfig.mk > +++ b/mk/rte.sdkconfig.mk > showversion: > - @set -- \ > - $$(sed -rne 's,^#define RTE_VER_[A-Z_]*[[:space:]]+([0-9]+).*,\1,p' \ > - -e 's,^#define RTE_VER_SUFFIX[[:space:]]+"(.*)",\1,p' \ > - $(RTE_SRCDIR)/lib/librte_eal/common/include/rte_version.h) ;\ > - printf '%d.%02d.%d' "$$1" "$$2" "$$3"; \ > - if [ -z "$$5" ]; then echo; \ > - else printf '%s' "$$4"; \ > - if [ $$5 -lt 16 ] ; then echo $$5; \ > - else echo $$(($$5 - 16)); fi; \ > - fi > + @cat $(RTE_SRCDIR)/DPDK_VERSION I'm a bit sad about removing this complex command ;)