From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C97045DD9; Fri, 6 Dec 2024 16:55:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C24ED4064F; Fri, 6 Dec 2024 16:55:36 +0100 (CET) Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) by mails.dpdk.org (Postfix) with ESMTP id 5B7FE4027D for ; Fri, 6 Dec 2024 16:55:35 +0100 (CET) Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id A47C011400BD; Fri, 6 Dec 2024 10:55:34 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Fri, 06 Dec 2024 10:55:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1733500534; x=1733586934; bh=zke7bc+0JUadiR9kaNnYUqnOfPIdH1tMijLgsyKTIMA=; b= QmrOz9bPA2ndGn5BqghpN9CkNvFOp5dUViGN8153AfFTBk9vfv56gxKWYGdo56FZ nfe8zesphGr3snse2j6Sv/oDQWp8l2cZotLxHYvzv4zsCWXYg2iqlVh3kzoU/HvT o1vp3bHpJJgljHKOSoFkO47k0W2zzT9mCIamjEwU38FwVp3C5lmdNvzyJDMMpBXt 3hXnkjisK0cnSG91stYO3b4w98MCqP76ey1ahbYyxJUiSnjRM/yYjuxi+K2oo993 mGzeXg82sM1cvGeqRx9DAbmWGeNMn/yYRpD/0jSgRm6ABZ9d5vt4ULfOAZVXq+TH O9P6MsjVhoBQfpjJBT8q2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733500534; x= 1733586934; bh=zke7bc+0JUadiR9kaNnYUqnOfPIdH1tMijLgsyKTIMA=; b=C NmV+mK5ELitUiyv4DDH7o+wOroEEJlild7skAeTj/bJyOw/zVdAhJt3MOBz501te vVVHvfC1+YNdBYLMyXVdZRVEe7kN/iCxujjNOSZzkFVB+CePBphYuxE7QVnGwmqi b17onB4dc7G5DV0nLCoZzY+XfLpQwe9b114/yTkYxPhAp5QWaWCKG1SalrHnTyZQ kmcmz/eiwGkC1QTPbtMMV7zltgG+NMbb5vJSpeDHJqX6OFsIQcxbyic5175scyuc CF5hjBcJVqR3p2R+74JY6OopV0EIFUbmD5zJIFOoB3rMogNw+8Wur12Rs2X5B+GV Y5M1Tlkil0fgt8d+y9b3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrieelgdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdeh vedtkeeivdeuuedvieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggrvhhiug drmhgrrhgthhgrnhgusehrvgguhhgrthdrtghomhdprhgtphhtthhopehhohhfohhrshes lhihshgrthhorhdrlhhiuhdrshgvpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpd hrtghpthhtohepfhhrohguvgdrnhhorhgurghhlhestggrnhhonhhitggrlhdrtghomhdp rhgtphhtthhopehmrghtthhirghsrdhrohhnnhgslhhomhesvghrihgtshhsohhnrdgtoh hm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Dec 2024 10:55:32 -0500 (EST) From: Thomas Monjalon To: David Marchand , Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: dev@dpdk.org, frode.nordahl@canonical.com, mattias.ronnblom@ericsson.com Subject: Re: [PATCH 0/3] Defer lcore variables allocation Date: Fri, 06 Dec 2024 16:55:30 +0100 Message-ID: <6775037.31r3eYUQgx@thomas> In-Reply-To: References: <20241205175754.1673888-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/12/2024 12:01, Mattias R=C3=B6nnblom: > On 2024-12-05 18:57, David Marchand wrote: > In retrospect, maybe the offset between lcore variable instances could=20 > have been encoded into the handle, and thus one could use=20 > different-sized offset for different variables. Yes it would allow to allocate a minimum size, instead of having a default which is also a maximum limit size of an object. It is not too late to change the behavior as the API is experimental. > > The general question on whether lcore variables in constructor should > > be forbidden, is left to a later discussion. >=20 > That discussion could be extended to cover the question if RTE_INIT()=20 > type constructors should be used at all. Intuitively, it seems better if= =20 > all DPDK initialization, or at least all EAL init, happens at the time=20 > of rte_eal_init(), in some ordered/organized fashion. Yes we may avoid constructors and instead have callbacks called in rte_eal_= init(). In order to not break the RTE_INIT API, we could define some new macros for registering such rte_eal_init callbacks.