From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2135A04C7; Wed, 16 Sep 2020 11:28:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 856711C215; Wed, 16 Sep 2020 11:28:34 +0200 (CEST) Received: from incedge.chinasoftinc.com (unknown [114.113.233.8]) by dpdk.org (Postfix) with ESMTP id 964BF1C20E for ; Wed, 16 Sep 2020 11:28:32 +0200 (CEST) X-ASG-Debug-ID: 1600248212-149d1141a41365f0001-TfluYd Received: from mail.chinasoftinc.com ([10.168.0.51]) by incedge.chinasoftinc.com with ESMTP id ycd3OA5qTfHnUGXN (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Sep 2020 17:23:32 +0800 (CST) X-Barracuda-Envelope-From: huwei013@chinasoftinc.com X-Barracuda-RBL-Trusted-Forwarder: 10.168.0.51 X-ASG-Whitelist: Client Received: from [192.168.1.199] (139.159.243.11) by INCCAS001.ito.icss (10.168.0.60) with Microsoft SMTP Server id 14.3.487.0; Wed, 16 Sep 2020 17:23:32 +0800 X-Barracuda-RBL-Trusted-Forwarder: 192.168.1.199 To: Ferruh Yigit X-ASG-Orig-Subj: Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information CC: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Shahaf Shuler , Qi Zhang , Andrew Rybchenko , Thomas Monjalon , , References: <20200818120254.72792-1-huwei013@chinasoftinc.com> <20200820014204.25035-1-huwei013@chinasoftinc.com> <20200820014204.25035-5-huwei013@chinasoftinc.com> <1f017605-c7cf-78c3-b1c1-0827a8e6f8b6@intel.com> From: "Wei Hu (Xavier)" Message-ID: <677a3cb4-cff0-56f3-bfee-422d4742ddd8@chinasoftinc.com> Date: Wed, 16 Sep 2020 17:23:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1f017605-c7cf-78c3-b1c1-0827a8e6f8b6@intel.com> Content-Language: en-US X-Originating-IP: [139.159.243.11] X-Barracuda-Connect: UNKNOWN[10.168.0.51] X-Barracuda-Start-Time: 1600248212 X-Barracuda-Encrypted: ECDHE-RSA-AES256-SHA X-Barracuda-URL: https://incspam.chinasofti.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at chinasoftinc.com X-Barracuda-Scan-Msg-Size: 4381 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh Yigit On 2020/9/15 0:31, Ferruh Yigit wrote: > On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: >> From: Huisong Li >> >> Currently, the information of Rx/Tx queues from PMD driver is not displayed >> exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" >> and "ports[pid].tx_conf" maintained in testpmd application may be not the >> value actually used by PMD driver. For instance, user does not set a field, >> but PMD driver has to use the default value. > Overall the question is why testpmd maintains the config values itself? > If this is testpmd implementation problem that is no big deal, but if > our APIs are forcing applications to maintain local copies that is > something to fix I think, which may lead the differences in application > copy and more troubles as you are fixing here. I think it is a minor problem about displaying some information about testpmd. And it has no impact on the usage of application. Thanks, Xavier >> This patch fixes rxtx_config_display so that the information of Rx/Tx >> queues can be really displayed for the PMD driver that implement >> .rxq_info_get and .txq_info_get ops callback function. >> >> Fixes: 75c530c1bd5351 ("app/testpmd: fix port configuration print") >> Fixes: d44f8a485f5d1f ("app/testpmd: enable per queue configure") >> Cc: stable@dpdk.org >> >> Signed-off-by: Huisong Li >> Signed-off-by: Wei Hu (Xavier) > Reviewed-by: Ferruh Yigit >