From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 2253CC426 for ; Sun, 26 Jul 2015 10:49:52 +0200 (CEST) Received: by wicgb10 with SMTP id gb10so74808934wic.1 for ; Sun, 26 Jul 2015 01:49:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3AQhQVJdVn8uH7RudxXbZu+xDik4QW/4yFocip69G1E=; b=VHyoEBvcIxmzXiJuqDcKuTt7qI40EGTd4agEixBX+ssf3Pk9v83mEXAejXtSL2FrlN rCRKVuLuufINpi8Ccl9pABXoN9zf7sVCRGZCLG5idHiD49nNaq1OdHkxeWt2Izy2xCqi aLIWk2Ft7UxLyCo0YqRoRj94RqJZyJE7B4BgtVj90ljW8JtYu6pyBU0yRwvsG76gMU+B /9x/AFCegMC1iqrvsgCs+vdiab+3bEIUaMceLf3e84J7I9Roh0484hh09EMNOaTjF1id BpKVu56dXiACjuV62BFgZOCD2Ce9uQ4PHWFDE3DMqOJNOluHWKFH+if53h6HMx3QyAJT miow== X-Gm-Message-State: ALoCoQlBQ6Gs/8Cia0EeB16bRiycIXA4+Np5kXWt5tBu9eOcgX782r42Xrv5l+JKb02v/0lUKtT+ X-Received: by 10.180.187.227 with SMTP id fv3mr5824706wic.43.1437900590873; Sun, 26 Jul 2015 01:49:50 -0700 (PDT) Received: from xps13.localnet (117.114.118.80.rev.sfr.net. [80.118.114.117]) by smtp.gmail.com with ESMTPSA id pf4sm21480638wjb.23.2015.07.26.01.49.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jul 2015 01:49:50 -0700 (PDT) From: Thomas Monjalon To: Konstantin Ananyev Date: Sun, 26 Jul 2015 10:48:34 +0200 Message-ID: <6786713.VzkSvV3k8n@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1437746295-12184-1-git-send-email-konstantin.ananyev@intel.com> References: <1437667506-3890-2-git-send-email-bruce.richardson@intel.com> <1437746295-12184-1-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCHv2 0/5] ixgbe: fix mbuf release on RX and TX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2015 08:49:52 -0000 2015-07-24 14:58, Konstantin Ananyev: > Konstantin has correctly pointed out that the previously applied fix: > b35d0d80f0a8 ("ixgbe: check mbuf refcnt when clearing a ring") > is not a proper fix for the reported issue at all. > Ref: http://permalink.gmane.org/gmane.comp.networking.dpdk.devel/21932 > > This patch set reverts the original fix, and applies a better fix for the > issue, as well as performing other cleanups in the code in question, to > try and avoid future issues. > > v2 chages: > - Make sure that rx_using_sse is reset to zero if scalar RX function was chosen. > - fix checkpatch.pl errors. > - fix remaining wrong typecast. Applied, thanks