From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D57EA00C4; Wed, 12 Oct 2022 15:09:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 013464309D; Wed, 12 Oct 2022 15:08:58 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 564DA43093 for ; Wed, 12 Oct 2022 15:08:56 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 9AA953200917; Wed, 12 Oct 2022 09:08:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 12 Oct 2022 09:08:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665580133; x= 1665666533; bh=OCd5jXyHlKIAhr15uxjIkn9vfharhyTJ9De6Jc4Jqro=; b=t rjtkvLxWSUGuXvVy7nwlLGhotmZkcxSbv3ZSfUroMM9OoJkkRyI3YUY7+0OyudXM 1OJbkKYlZmDWBjevGsYNIAkYkkkrV1w8ALt32xQ4F0oDjzOwBhP3UvoGS8//nkfc CzVDcMfNw+BZ8XAHI6CX69L6dDeEPAWo4IwnbSnRdaRdoYunOnK8IV/Wmo2cKNjX 1VVP8kE0RycBEJCEVtb04iHdUQ3uX5IneKJ6JpTf1zCAxHvMvxinY0oYhu863vnb jekuyknwMVtesZYovZuohLBZzh99lvsienUoRdir5yLbCZr5kXMPk7zpnEqia5Ac T8/e3OBH5dNvp3ax4IY/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665580133; x= 1665666533; bh=OCd5jXyHlKIAhr15uxjIkn9vfharhyTJ9De6Jc4Jqro=; b=f X6OiWofgAEsAX7jWm5pNYCiGFrh3v1vkXSxFMO5oe3PncR3ekIA3bhPzUpbbGolm Tw/zGfHW4+L0uqWB9yhfcdBaanhE+a0HHdoNTURh6SG8SMuNXFoYB04k7zBNeqb4 Yq7qxilVZ3plf3x2AKMXBr/IUXL810DnIt3mf7aoT1YRXkUaq2ydiiuoHBcPY8Gh gGV2ghx70Y8+FmIiufTCeOz5Xuhq/EDBzGNts2DgVaevXGB1ov95YG2sQcPzVS1i NuBqvdJ2/rzKcjiqmTBENrgqzCxOgzNMR23vwOKYKoDVB1Ox9SOGRZObErnAQMfW 1IZqo4SzY0jZRiPUXzemQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejkedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Oct 2022 09:08:52 -0400 (EDT) From: Thomas Monjalon To: Ankur Dwivedi Cc: dev@dpdk.org, gakhil@marvell.com, royzhang1980@gmail.com, amitprakashs@marvell.com, jerinj@marvell.com, Ankur Dwivedi , david.marchand@redhat.com Subject: Re: [PATCH v2] devtools: add tracepoint check in checkpatch Date: Wed, 12 Oct 2022 15:08:50 +0200 Message-ID: <6793875.kQq0lBPeGt@thomas> In-Reply-To: <20221012114525.12220-1-adwivedi@marvell.com> References: <20221012092337.5988-1-adwivedi@marvell.com> <20221012114525.12220-1-adwivedi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/10/2022 13:45, Ankur Dwivedi: > devtools/check-symbol-change.sh | 76 +------------------------------- > devtools/check-tracepoint.py | 52 ++++++++++++++++++++++ > devtools/check-tracepoint.sh | 66 ++++++++++++++++++++++++++++ > devtools/checkpatches.sh | 9 ++++ > devtools/common-func.sh | 77 +++++++++++++++++++++++++++++++++ > devtools/trace-skiplist.txt | 0 Before diving into this proposal, I would like a split of the patch for the rework (and move) of check-symbol-change.sh alone. In general I see too many files added: check-tracepoint.py and check-tracepoint.sh common-func.sh is probably a bad name.