From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
beilei.xing@intel.com, qi.z.zhang@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set
Date: Wed, 29 May 2019 11:11:58 +0200 [thread overview]
Message-ID: <67975a53-a95c-912a-02d0-f6507d1deb62@redhat.com> (raw)
In-Reply-To: <20190528194318.11641-1-stephen@networkplumber.org>
On 5/28/19 9:43 PM, Stephen Hemminger wrote:
> This driver was inserting its own stub for queue_stats_mapping which
> did nothing but cause this device to return a different errno
> than every other device driver. All devices that don't implement
> queue stats mapping should return the same error.
>
> Maybe the plan originally was to implement something, if that
> ever happens, just put in the right code.
>
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/i40e/i40e_ethdev.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
next prev parent reply other threads:[~2019-05-29 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 19:43 Stephen Hemminger
2019-05-29 9:11 ` Maxime Coquelin [this message]
2019-06-18 14:09 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67975a53-a95c-912a-02d0-f6507d1deb62@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).