From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 10F21A0465 for ; Wed, 29 May 2019 11:12:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DEEE337A2; Wed, 29 May 2019 11:12:02 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C28293576 for ; Wed, 29 May 2019 11:12:01 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2676861980; Wed, 29 May 2019 09:12:01 +0000 (UTC) Received: from [10.36.112.24] (ovpn-112-24.ams2.redhat.com [10.36.112.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 075561750C; Wed, 29 May 2019 09:11:59 +0000 (UTC) To: Stephen Hemminger , beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org References: <20190528194318.11641-1-stephen@networkplumber.org> From: Maxime Coquelin Message-ID: <67975a53-a95c-912a-02d0-f6507d1deb62@redhat.com> Date: Wed, 29 May 2019 11:11:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190528194318.11641-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 29 May 2019 09:12:01 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/28/19 9:43 PM, Stephen Hemminger wrote: > This driver was inserting its own stub for queue_stats_mapping which > did nothing but cause this device to return a different errno > than every other device driver. All devices that don't implement > queue stats mapping should return the same error. > > Maybe the plan originally was to implement something, if that > ever happens, just put in the right code. > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Signed-off-by: Stephen Hemminger > --- > drivers/net/i40e/i40e_ethdev.c | 16 ---------------- > 1 file changed, 16 deletions(-) > Acked-by: Maxime Coquelin