From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 579171E25 for ; Mon, 23 Apr 2018 12:13:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2018 03:13:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,317,1520924400"; d="scan'208";a="49132223" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.42]) ([10.237.221.42]) by fmsmga001.fm.intel.com with ESMTP; 23 Apr 2018 03:13:34 -0700 To: Ophir Munk , Thomas Monjalon , 'Pascal Mazon' , Mordechay Haimovsky Cc: "'dev@dpdk.org'" , Shahaf Shuler , Olga Shern , Raslan Darawsheh References: <20180322182843.105732-1-ferruh.yigit@intel.com> <2913888.DGWfva7bOG@xps> <33d0cd29-855e-58dd-683d-e540a7978515@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <67998c63-84fe-4c21-3ca5-df25d47929e6@intel.com> Date: Mon, 23 Apr 2018 11:13:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 10:13:39 -0000 On 4/23/2018 10:17 AM, Ophir Munk wrote: > Hi Ferruh, > A quick feedback to your patch on top of next-net/master: the IP and TCP offloaded checksums are turned incorrect. Hi Ophir, Thanks for testing. This patch removes queue specific offloads for tap but nothing touched on port offloads, and in below test you are already using single queue. This may mean something is wrong in tap for port offloading configuration. Tap does csum calculation in Tx path [1], which does not even checks the offloading flags, but mbuf->ol_flags. Any chance that mbuf->ol_flags is not set correct? Can you able to make exact same setup work without this patch? [1] if (txq->csum && ((mbuf->ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_IPV4) || (mbuf->ol_flags & PKT_TX_L4_MASK) == PKT_TX_UDP_CKSUM || (mbuf->ol_flags & PKT_TX_L4_MASK) == PKT_TX_TCP_CKSUM))) { /* Support only packets with all data in the same seg */ if (mbuf->nb_segs > 1) break; /* To change checksums, work on a copy of data. */ rte_memcpy(m_copy, rte_pktmbuf_mtod(mbuf, void *), rte_pktmbuf_data_len(mbuf)); tap_tx_offload(m_copy, mbuf->ol_flags, mbuf->l2_len, mbuf->l3_len); iovecs[1].iov_base = m_copy; } > > Detailed description > ================ > A traffic generator is sending to a dpdk device one TCP packet and expects to receive it back after the IP and TCP checksums have been calculated by TAP. > > Testpmd parameters > ================= > testpmd -c 0x0f -n 4 --vdev="net_tap0,iface=net_vsc0,remote=ens2" -w 0000:00:00.0 -- --burst=64 --mbcache=512 --portmask 0x1 -i --txd=256 --rxd=256 --rxq=1 --txq=1 --coremask 0x008 --forward-mode=csum --eth-peer=0,00:15:5d:10:66:02 > > Testpmd CLI commands > =================== > testpmd> port stop all > testpmd> csum set ip hw 0 > testpmd> csum set tcp hw 0 > testpmd> port start all > testpmd> start > > On Traffic generator side > ===================== > A traffic generator (scapy) is sending 1261 bytes of a TCP packet > > Monitoring the traffic: > > tcpdump -i -envvv & > > The tcpdump output shows the sent packet followed by the received packet. > Please note the received packet has incorrect IP & TCP checksums (both are 0) > > 11:51:03.058623 00:15:5d:10:66:02 > f4:52:14:7a:59:81, ethertype IPv4 (0x0800), length 1261: (tos 0x0, ttl 64, id 1, offset 0, flags [none], proto TCP (6), length 1247) > 127.0.0.1.1 > 127.0.0.1.1: Flags [S], cksum 0xdba5 (correct), seq 0:1207, win 8192, length 1207 > > 11:51:03.058836 f4:52:14:7a:59:81 > 00:15:5d:10:66:02, ethertype IPv4 (0x0800), length 1261: (tos 0x0, ttl 64, id 1, offset 0, flags [none], proto TCP (6), length 1247, bad cksum 0 (->7816)!) > 127.0.0.1.1 > 127.0.0.1.1: Flags [S], cksum 0x0000 (incorrect -> 0xdba5), seq 0:1207, win 8192, length 1207 > > Regards, > Ophir > >> -----Original Message----- >> From: Ophir Munk >> Sent: Monday, April 23, 2018 11:39 AM >> To: 'Ferruh Yigit' ; Thomas Monjalon >> ; Pascal Mazon ; >> Mordechay Haimovsky >> Cc: 'dev@dpdk.org' ; Shahaf Shuler >> ; Olga Shern ; Raslan >> Darawsheh >> Subject: RE: [dpdk-dev] [PATCH] net/tap: remove queue specific offload >> support >> >> Hi Ferruh, >> I was able to apply your patch with Thomas help: >> 1. git am --reject >> 2. >> 3. git am --continue >> >> Regards, >> Ophir >> >>> -----Original Message----- >>> From: Ophir Munk >>> Sent: Sunday, April 22, 2018 7:05 PM >>> To: Ferruh Yigit ; Thomas Monjalon >>> ; Pascal Mazon ; >>> Mordechay Haimovsky >>> Cc: dev@dpdk.org; Shahaf Shuler ; Olga Shern >>> ; Raslan Darawsheh >>> Subject: RE: [dpdk-dev] [PATCH] net/tap: remove queue specific offload >>> support >>> >>> Hi Ferruh, >>> I am not able to apply your patch on next-net/master branch. >>> I am failing to apply it both on latest commit or just before >>> 22-Mar-18 (commit's date). >>> >>> $ git am dpdk-dev-net-tap-remove-queue-specific-offload-support.patch >>> Applying: net/tap: remove queue specific offload support >>> error: patch failed: drivers/net/tap/rte_eth_tap.c:269 >>> error: drivers/net/tap/rte_eth_tap.c: patch does not apply Patch >>> failed at >>> 0001 net/tap: remove queue specific offload support >>> >>> Please advise. >>> >>> Once this error is fixed I can verify your patch with high priority >>> and send you my feedback. >>> >>> Regards, >>> Ophir >>> >>>> -----Original Message----- >>>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >>>> Sent: Wednesday, April 18, 2018 1:55 PM >>>> To: Ophir Munk ; Thomas Monjalon >>>> ; Pascal Mazon ; >>>> Mordechay Haimovsky >>>> Cc: dev@dpdk.org; Shahaf Shuler ; Olga Shern >>>> >>>> Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific >>>> offload support >>>> >>>> On 4/18/2018 10:40 AM, Ophir Munk wrote: >>>>> Hi Ferruh, >>>>> Sorry for the delayed response. >>>>> >>>>> I would like to verify the correctness of this patch by running >>>>> several >>>> internal tests. >>>>> Is a reply by Monday OK with you? >>>> >>>> Monday can be late to include patch into rc1, any chance to do earlier? >>>> >>>>> >>>>> Regards, >>>>> Ophir >>>>> >>>>>> -----Original Message----- >>>>>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] >>>>>> Sent: Wednesday, April 18, 2018 11:59 AM >>>>>> To: Thomas Monjalon ; Pascal Mazon >>>>>> ; Mordechay Haimovsky >>>> ; >>>>>> Ophir Munk >>>>>> Cc: dev@dpdk.org; Shahaf Shuler ; Olga >>>>>> Shern >>>>>> Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific >>>>>> offload support >>>>>> >>>>>> On 4/12/2018 5:23 PM, Ferruh Yigit wrote: >>>>>>> On 4/5/2018 6:49 PM, Thomas Monjalon wrote: >>>>>>>> Pascal, Moti, Ophir, >>>>>>>> please comment. >>>>>>> >>>>>>> Hi Moti, >>>>>>> >>>>>>> Any comment? This has been asked many times now. >>>>>> >>>>>> Hi Moti, Ophir, >>>>>> >>>>>> You have not responded why queue specific offload added in other >>>> thread. >>>>>> And you are not responding to this patch... >>>>>> >>>>>> Hi Pascal, >>>>>> >>>>>> If you also have no objection, this patch is going in. >>>>>> >>>>>> Thanks, >>>>>> ferruh >>>>>> >>>>>> >>>>>>> >>>>>>>> >>>>>>>> 22/03/2018 19:28, Ferruh Yigit: >>>>>>>>> It is not clear if tap PMD supports queue specific offloads, >>>>>>>>> removing the related code. >>>>>>>>> >>>>>>>>> Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") >>>>>>>>> Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") >>>>>>>>> Cc: motih@mellanox.com >>>>>>>>> >>>>>>>>> Signed-off-by: Ferruh Yigit >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>> >