From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 904715B30; Fri, 20 Jul 2018 05:21:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 20:21:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,377,1526367600"; d="scan'208";a="246787061" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 19 Jul 2018 20:20:54 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 19 Jul 2018 20:20:53 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.81]) with mapi id 14.03.0319.002; Fri, 20 Jul 2018 11:20:51 +0800 From: "Peng, Yuan" To: "Dai, Wei" , "Wu, Jingjing" , "Peng, Yuan" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix commands to config some offload Thread-Index: AQHUH9O4dQdWDiIjEUCTTLnJG4VanqSXbxpQ Date: Fri, 20 Jul 2018 03:20:51 +0000 Message-ID: <67D543A150B29E4CAAE53918F64EDAEA375D0EE7@SHSMSX103.ccr.corp.intel.com> References: <1532054553-21844-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1532054553-21844-1-git-send-email-wei.dai@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 03:21:57 -0000 Tested-by: Peng, Yuan - DPDK version: 18.08-rc1 commit c27dbc300eee78c2eb33e84181617fdd7cbaaae4 - OS: 4.5.5-300.fc24.x86_64 - Compiler: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - Hardware platform: BDE-EP - NIC Intel Corporation Device Fortville [8086:1583] - driver: i40e - version: 2.4.3 - firmware-version: 6.01 0x80003205 1.1691.0 - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - Default x86_64-native-linuxapp-gcc configuration - Prerequisites: - Total 2 cases, 2 passed, 0 failed Test1: ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 1../x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4 - -i --rxq=3D4 --txq= =3D4 testpmd> show port 0 rx_offload capabilities Rx Offloading Capabilities of port 0 : Per Queue : Per Port : VLAN_STRIP IPV4_CKSUM UDP_CKSUM TCP_CKSUM QINQ_STRIP OUTER_IPV4= _CKSUM VLAN_FILTER VLAN_EXTEND JUMBO_FRAME CRC_STRIP KEEP_CRC testpmd> show port 0 rx_offload configuration Rx Offloading Configuration of port 0 : Port :=20 Queue[ 0] : Queue[ 1] : Queue[ 2] : Queue[ 3] : Testpmd> port stop 0 testpmd> port config 0 rx_offload keep_crc on testpmd> port start 0 The port can be started normally. Test2: 1. Start testpmd and get the tx_offload capability and configuration:: ./testpmd -c f -n 4 -- -i --rxq=3D4 --txq=3D4 testpmd> show port 0 tx_offload capabilities Tx Offloading Capabilities of port 0 : Per Queue : MBUF_FAST_FREE Per Port : VLAN_INSERT IPV4_CKSUM UDP_CKSUM TCP_CKSUM SCTP_CKSUM TCP= _TSO OUTER_IPV4_CKSUM QINQ_INSERT VXLAN_TNL_TSO GRE_TNL_TSO IPIP_TNL_TSO GE= NEVE_TNL_TSO MULTI_SEGS testpmd> show port 0 tx_offload configuration Tx Offloading Configuration of port 0 : Port : MBUF_FAST_FREE Queue[ 0] : Queue[ 1] : Queue[ 2] : Queue[ 3] : 2. Disable mbuf_fast_free per_port:: testpmd> port stop 0 testpmd> port config 0 tx_offload mbuf_fast_free off testpmd> port start 0 testpmd> show port 0 tx_offload configuration Tx Offloading Configuration of port 0 : Port : Queue[ 0] : Queue[ 1] : Queue[ 2] : Queue[ 3] : 3. Enable mbuf_fast_free per_queue:: testpmd> port 0 txq 0 tx_offload mbuf_fast_free on testpmd> port 0 txq 1 tx_offload mbuf_fast_free on testpmd> port 0 txq 2 tx_offload mbuf_fast_free on testpmd> port 0 txq 3 tx_offload mbuf_fast_free on testpmd> port start 0 testpmd> show port 0 tx_offload configuration Tx Offloading Configuration of port 0 : Port : Queue[ 0] : MBUF_FAST_FREE Queue[ 1] : MBUF_FAST_FREE Queue[ 2] : MBUF_FAST_FREE Queue[ 3] : MBUF_FAST_FREE 4. Disable mbuf_fast_free per_queue:: testpmd> port 0 txq 0 tx_offload mbuf_fast_free off testpmd> port 0 txq 1 tx_offload mbuf_fast_free off testpmd> port 0 txq 2 tx_offload mbuf_fast_free off testpmd> port 0 txq 3 tx_offload mbuf_fast_free off testpmd> port start 0 testpmd> show port 0 tx_offload configuration Tx Offloading Configuration of port 0 : Port : Queue[ 0] : Queue[ 1] : Queue[ 2] : Queue[ 3] : The mbuf_fast_free per_queue can be set normally. -----Original Message----- From: Dai, Wei=20 Sent: Friday, July 20, 2018 10:43 AM To: Wu, Jingjing ; Peng, Yuan Cc: dev@dpdk.org; Dai, Wei ; stable@dpdk.org Subject: [PATCH] app/testpmd: fix commands to config some offload Without this patch, testpmd command to config Rx offload keep_crc would fai= l and report "Bad argument". This patch aslo fix the command to config the Tx offload mbuf_fast_free. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: stable@dpdk.org Signed-off-by: Wei Dai --- app/test-pmd/cmdline.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 5885289.= .a0ed3a0 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -16665,7 +16665,7 @@ struct cmd_config_per_port_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off = =3D TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_rx_offload_result, @@ -16744,7 +16744,7 @@ struct cmd_config_per_port_rx_offload_result { .help_str =3D "port config rx_offload vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens =3D { (void *)&cmd_config_per_port_rx_offload_result_port, @@ -16794,7 +16794,7 @@ struct cmd_config_per_queue_rx_offload_result { offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" "qinq_strip#outer_ipv4_cksum#macsec_strip#" "header_split#vlan_filter#vlan_extend#jumbo_frame#" - "crc_strip#scatter#timestamp#security"); + "crc_strip#scatter#timestamp#security#keep_crc"); cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off= =3D TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_rx_offload_result, @@ -16846,7 +16846,7 @@ struct cmd_config_per_queue_rx_offload_result { "vlan_strip|ipv4_cksum|" "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" "macsec_strip|header_split|vlan_filter|vlan_extend|" - "jumbo_frame|crc_strip|scatter|timestamp|security " + "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " "on|off", .tokens =3D { (void *)&cmd_config_per_queue_rx_offload_result_port, @@ -17063,7 +17063,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_port_tx_offload_result_on_off = =3D TOKEN_STRING_INITIALIZER (struct cmd_config_per_port_tx_offload_result, @@ -17144,7 +17144,7 @@ struct cmd_config_per_port_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens =3D { (void *)&cmd_config_per_port_tx_offload_result_port, @@ -17195,7 +17195,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" - "mt_lockfree#multi_segs#fast_free#security"); + "mt_lockfree#multi_segs#mbuf_fast_free#security"); cmdline_parse_token_string_t cmd_config_per_queue_tx_offload_result_on_off= =3D TOKEN_STRING_INITIALIZER (struct cmd_config_per_queue_tx_offload_result, @@ -17248,7 +17248,7 @@ struct cmd_config_per_queue_tx_offload_result { "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" - "mt_lockfree|multi_segs|fast_free|security " + "mt_lockfree|multi_segs|mbuf_fast_free|security " "on|off", .tokens =3D { (void *)&cmd_config_per_queue_tx_offload_result_port, -- 1.8.3.1