From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A66E31B43F for ; Thu, 2 Aug 2018 09:03:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2018 00:03:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,434,1526367600"; d="scan'208";a="61748391" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 02 Aug 2018 00:03:10 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 2 Aug 2018 00:03:09 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 2 Aug 2018 00:03:09 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.100]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.173]) with mapi id 14.03.0319.002; Thu, 2 Aug 2018 15:03:07 +0800 From: "Peng, Yuan" To: "Dumitrescu, Cristian" , "dev@dpdk.org" CC: "Peng, Yuan" Thread-Topic: [dpdk-dev] [PATCH] examples/ip_pipeline: fix RSS Thread-Index: AQHUKN3CFgsH9/RguUCCfR/QcbnL8KSsCsdw Date: Thu, 2 Aug 2018 07:03:07 +0000 Message-ID: <67D543A150B29E4CAAE53918F64EDAEA375D4855@SHSMSX103.ccr.corp.intel.com> References: <1533048565-216267-1-git-send-email-cristian.dumitrescu@intel.com> In-Reply-To: <1533048565-216267-1-git-send-email-cristian.dumitrescu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 07:03:13 -0000 Tested-by: Peng, Yuan - Tested Commit: 23888166d99682b1491a917277e4ff0ff01639b2 - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation Device Fortville [8086:1583] - Default x86_64-native-linuxapp-gcc configuration I have verified the ip_pipeline rss case with 18.08-rc2 applied your patch = 43469 * ./build/ip_pipeline -c 0x1F -n 4 -- -s ./examples/rss.cli * Start traffic on just one input port. * output traffic was seen (in equal amounts) for each of the 4x output port= s the bug is not represented. -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Cristian Dumitrescu Sent: Tuesday, July 31, 2018 10:49 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] examples/ip_pipeline: fix RSS Fix for RSS issue triggered by latest changes in ethdev layer. Signed-off-by: Cristian Dumitrescu --- examples/ip_pipeline/link.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/examples/ip_pipeline/link.c b/examples/ip_pipeline/link.c inde= x 2ccfea4..392a890 100644 --- a/examples/ip_pipeline/link.c +++ b/examples/ip_pipeline/link.c @@ -158,12 +158,9 @@ link_create(const char *name, struct link_params *para= ms) memcpy(&port_conf, &port_conf_default, sizeof(port_conf)); if (rss) { port_conf.rxmode.mq_mode =3D ETH_MQ_RX_RSS; - if (port_info.flow_type_rss_offloads & ETH_RSS_IPV4) - port_conf.rx_adv_conf.rss_conf.rss_hf |=3D - ETH_RSS_IPV4; - if (port_info.flow_type_rss_offloads & ETH_RSS_IPV6) - port_conf.rx_adv_conf.rss_conf.rss_hf |=3D - ETH_RSS_IPV6; + port_conf.rx_adv_conf.rss_conf.rss_hf =3D + (ETH_RSS_IP | ETH_RSS_TCP | ETH_RSS_UDP) & + port_info.flow_type_rss_offloads; } =20 cpu_id =3D (uint32_t) rte_eth_dev_socket_id(port_id); -- 2.7.4