From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A1BD82C5; Fri, 17 Aug 2018 11:41:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Aug 2018 02:41:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,250,1531810800"; d="scan'208";a="225404599" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 17 Aug 2018 02:41:54 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 17 Aug 2018 02:41:26 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 17 Aug 2018 02:41:23 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.185]) with mapi id 14.03.0319.002; Fri, 17 Aug 2018 17:39:21 +0800 From: "Peng, Yuan" To: "Chalupnik, KamilX" , "Mokhtar, Amr" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Chalupnik, KamilX" , "Peng, Yuan" Thread-Topic: [dpdk-dev] [PATCH] app/testbbdev: fix inputs mbuf creation issue Thread-Index: AQHUNfrMmJWzBQQyOEWGFHtQafbDm6TDrsyw Date: Fri, 17 Aug 2018 09:39:21 +0000 Message-ID: <67D543A150B29E4CAAE53918F64EDAEA375E4D28@SHSMSX103.ccr.corp.intel.com> References: <20180817071919.31500-1-kamilx.chalupnik@intel.com> In-Reply-To: <20180817071919.31500-1-kamilx.chalupnik@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testbbdev: fix inputs mbuf creation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 09:41:59 -0000 Tested-by: Peng, Yuan > NIC Fortville 4*10G > ethtool -i ens785f1 > driver: i40e > version: 2.4.10 > firmware-version: 6.01 0x80003205 1.1691.0 DPDK version: 18.11-rc0=20 > commit 76b9d9de5c7d747c381027156aac07735cb1bc0c > FlexRAN-1.6.0 > Os: 4.4.0-62-generic > ICC:parallel_studio_xe_2018_update1_professional_edition_for_cpp > Set ``CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW=3Dy`` > cat /proc/cmdline > BOOT_IMAGE=3D/boot/vmlinuz-4.4.0-62-generic root=3DUUID=3D673a4478-afa5-= =20 > 463a-afa2-40681423994e ro hugepagesz=3D1G hugepages=3D16=20 > default_hugepagesz=3D1G isolcpus=3D1-43 intel_iommu=3Don nohz_full=3D1-43 > rcu_nocbs=3D1-43 iommu=3Dpt >=20 > ./usertools/dpdk-devbind.py -b vfio-pci 05:00.0 05:00.1=20 > ./app/test-bbdev/test-bbdev.py -e=3D"--=20 > vdev=3Dbaseband_null,socket_id=3D0,max_nb_queues=3D8" >=20 > the case can passed. >=20 > Thanks. > Yuan. -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kamil Chalupnik Sent: Friday, August 17, 2018 3:19 PM To: Mokhtar, Amr ; De Lara Guarch, Pablo Cc: dev@dpdk.org; stable@dpdk.org; Chalupnik, KamilX Subject: [dpdk-dev] [PATCH] app/testbbdev: fix inputs mbuf creation issue Omitting inputs and outputs mbuf creation for BaseBand Null Device as input= s and outputs data do not exist for Null Device Fixes: b2a4654f082b ("mempool: check for zero size creation") Cc: pablo.de.lara.guarch@intel.com Signed-off-by: Kamil Chalupnik --- app/test-bbdev/test_bbdev_perf.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_p= erf.c index 6861edc..fbe6cc9 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -267,12 +267,13 @@ typedef int (test_case_function)(struct active_device= *ad, =20 static int create_mempools(struct active_device *ad, int socket_id, - enum rte_bbdev_op_type op_type, uint16_t num_ops) + enum rte_bbdev_op_type org_op_type, uint16_t num_ops) { struct rte_mempool *mp; unsigned int ops_pool_size, mbuf_pool_size =3D 0; char pool_name[RTE_MEMPOOL_NAMESIZE]; const char *op_type_str; + enum rte_bbdev_op_type op_type =3D org_op_type; =20 struct op_data_entries *in =3D &test_vector.entries[DATA_INPUT]; struct op_data_entries *hard_out =3D @@ -289,6 +290,9 @@ typedef int (test_case_function)(struct active_device *= ad, OPS_CACHE_SIZE + 1)), OPS_POOL_SIZE_MIN)); =20 + if (org_op_type =3D=3D RTE_BBDEV_OP_NONE) + op_type =3D RTE_BBDEV_OP_TURBO_ENC; + op_type_str =3D rte_bbdev_op_type_str(op_type); TEST_ASSERT_NOT_NULL(op_type_str, "Invalid op type: %u", op_type); =20 @@ -303,6 +307,10 @@ typedef int (test_case_function)(struct active_device = *ad, socket_id); ad->ops_mempool =3D mp; =20 + /* Do not create inputs and outputs mbufs for BaseBand Null Device */ + if (org_op_type =3D=3D RTE_BBDEV_OP_NONE) + return TEST_SUCCESS; + /* Inputs */ mbuf_pool_size =3D optimal_mempool_size(ops_pool_size * in->nb_segments); mp =3D create_mbuf_pool(in, ad->dev_id, socket_id, mbuf_pool_size, "in");= @@ -1058,14 +1066,14 @@ typedef int (test_case_function)(struct active_dev= ice *ad, rte_bbdev_info_get(ad->dev_id, &info); socket_id =3D GET_SOCKET(info.socket_id); =20 - if (op_type =3D=3D RTE_BBDEV_OP_NONE) - op_type =3D RTE_BBDEV_OP_TURBO_ENC; f_ret =3D create_mempools(ad, socket_id, op_type, get_num_ops()); if (f_ret !=3D TEST_SUCCESS) { printf("Couldn't create mempools"); goto fail; } + if (op_type =3D=3D RTE_BBDEV_OP_NONE) + op_type =3D RTE_BBDEV_OP_TURBO_ENC; =20 f_ret =3D init_test_op_params(op_params, test_vector.op_type, test_vector.expected_status, -- 1.8.3.1