From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3EA3E1B123; Tue, 23 Oct 2018 08:23:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2018 23:23:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,415,1534834800"; d="scan'208";a="84809316" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 22 Oct 2018 23:23:29 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 22 Oct 2018 23:23:29 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 22 Oct 2018 23:23:29 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.224]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.46]) with mapi id 14.03.0319.002; Tue, 23 Oct 2018 14:19:48 +0800 From: "Peng, Yuan" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "stable@dpdk.org" , "Peng, Yuan" Thread-Topic: [PATCH] net/ixgbe: fix RSS flow return error Thread-Index: AQHUaoU3iSEl6z5M40K3O0AOSKUx5qUsWD3Q Date: Tue, 23 Oct 2018 06:19:47 +0000 Message-ID: <67D543A150B29E4CAAE53918F64EDAEA37636BC5@SHSMSX103.ccr.corp.intel.com> References: <1540265890-40975-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1540265890-40975-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix RSS flow return error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 06:23:32 -0000 Tested-by: Peng, Yuan - Tested Branch: master - Tested Commit: 739e13bcc98f562d3301f808ec76507ebae82e63 - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection [80= 86:10fb] (rev 01) Intel Corporation Ethernet Controller X710 for 10GbE SFP+ [8086:1572] = (rev 01) - Default x86_64-native-linuxapp-gcc configuration - Prerequisites: - Total 1 cases, 1 passed, 0 failed - Case: ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 1. Start the testpmd:: ./testpmd -c 1ffff -n 4 -- -i --nb-cores=3D8 --rxq=3D4 --txq=3D4 --port= -topology=3Dchained testpmd> set fwd rxonly testpmd> set verbose 1 testpmd> start 2. Show port default RSS fuctions:: testpmd> show port 0 rss-hash RSS functions: ipv4-frag ipv4-other ipv6-frag ipv6-other ip Send the ipv4-other packets with different src/dst ip address. All the packets are distributed to all the four queues. 3. disable all RSS fuctions:: testpmd> flow create 0 ingress pattern end actions rss types none end /= end Flow rule #0 created testpmd> show port 0 rss-hash RSS disabled Send the ipv4-udp packets with different src/dst ip address. All the packets are distributed to queue 0. Notes: only i40e support the command, others don't support the command created. 4. enable RSS fuction with all RSS hash type:: testpmd> flow create 0 ingress pattern end actions rss types all end / = end Flow rule #1 created testpmd> show port 0 rss-hash RSS functions: all ipv4-frag ipv4-tcp ipv4-udp ipv4-sctp ipv4-other ipv6-frag ipv6-tc= p ipv6-udp ipv6-sctp ipv6-other l2-payload ip udp tcp sctp Send the ipv4-udp packets with different src/dst ip address. All the packets are distributed to all the four queues. -----Original Message----- From: Zhao1, Wei=20 Sent: Tuesday, October 23, 2018 11:38 AM To: dev@dpdk.org Cc: Zhang, Qi Z ; stable@dpdk.org; Peng, Yuan ; Zhao1, Wei Subject: [PATCH] net/ixgbe: fix RSS flow return error If hash function is 0, it should disable RSS then return 0. Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.= c index ae21f04..ad9c46d 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -5703,7 +5703,7 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev, */ if ((rss_conf.rss_hf & IXGBE_RSS_OFFLOAD_ALL) =3D=3D 0) { ixgbe_rss_disable(dev); - return -EINVAL; + return 0; } if (rss_conf.rss_key =3D=3D NULL) rss_conf.rss_key =3D rss_intel_key; /* Default hash key */ -- 2.7.5