DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ibtisam Tariq <ibtisam.tariq@emumba.com>, chenbo.xia@intel.com
Cc: dev@dpdk.org, roy.fan.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option
Date: Fri, 19 Mar 2021 10:18:10 +0100	[thread overview]
Message-ID: <67be15b5-97c6-9b49-e8e5-9f857e1b6a58@redhat.com> (raw)
In-Reply-To: <20210204080542.3812-1-ibtisam.tariq@emumba.com>



On 2/4/21 9:05 AM, Ibtisam Tariq wrote:
> Short option "s" was passed to getopt_long function, while there was
> no condition on this option.
> 
> Fixes: f5188211c7 ("examples/vhost_crypto: add sample application")
> Cc: roy.fan.zhang@intel.com
> 
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
>  examples/vhost_crypto/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 29c8f7228..66bde38c0 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -219,7 +219,7 @@ vhost_crypto_parse_args(int argc, char **argv)
>  
>  	argvopt = argv;
>  
> -	while ((opt = getopt_long(argc, argvopt, "s:",
> +	while ((opt = getopt_long(argc, argvopt, "",
>  				  lgopts, &option_index)) != EOF) {
>  
>  		switch (opt) {
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  parent reply	other threads:[~2021-03-19  9:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  8:05 Ibtisam Tariq
2021-02-04 13:07 ` Zhang, Roy Fan
2021-02-04 13:08 ` Zhang, Roy Fan
2021-03-19  9:18 ` Maxime Coquelin [this message]
2021-03-31  8:31 ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67be15b5-97c6-9b49-e8e5-9f857e1b6a58@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=ibtisam.tariq@emumba.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).