From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B5A84337E; Mon, 20 Nov 2023 12:03:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 378D442DE1; Mon, 20 Nov 2023 12:03:29 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 2D2FF402DE for ; Mon, 20 Nov 2023 12:03:28 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SYkz235lqzRj6f; Mon, 20 Nov 2023 18:59:10 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 20 Nov 2023 19:03:24 +0800 Message-ID: <67c2f085-957f-bcc0-df0b-66ec2a6329d8@huawei.com> Date: Mon, 20 Nov 2023 19:03:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 2/3] doc/hns3: update the features for hns3 To: Ferruh Yigit , , Jie Hai , Yisen Zhuang CC: References: <20231120075502.15844-1-lihuisong@huawei.com> <20231120075502.15844-3-lihuisong@huawei.com> <9eb0a2b1-8873-4bc1-98e7-7f89fdf4956e@amd.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/11/20 18:53, Ferruh Yigit 写道: > On 11/20/2023 10:48 AM, lihuisong (C) wrote: >> 在 2023/11/20 17:56, Ferruh Yigit 写道: >>> On 11/20/2023 7:55 AM, Huisong Li wrote: >>>> Update the features for hns3. >>>> >>>> Signed-off-by: Huisong Li >>>> --- >>>>   doc/guides/nics/hns3.rst | 10 +++++++++- >>>>   1 file changed, 9 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst >>>> index 7eac1b3c92..11d0c04884 100644 >>>> --- a/doc/guides/nics/hns3.rst >>>> +++ b/doc/guides/nics/hns3.rst >>>> @@ -30,7 +30,6 @@ Features of the HNS3 PMD are: >>>>   - DCB >>>>   - Scattered and gather for TX and RX >>>>   - Vector Poll mode driver >>>> -- Dump register >>>>   - SR-IOV VF >>>>   - Multi-process >>>>   - MAC/VLAN filter >>>> @@ -38,6 +37,15 @@ Features of the HNS3 PMD are: >>>>   - NUMA support >>>>   - Generic flow API >>>>   - IEEE1588/802.1AS timestamping >>>> +- Basic stats >>>> +- Extended stats >>>> +- Traffic Management API >>>> +- Speed capabilities >>>> +- Link Auto-negotiation >>>> +- Link flow control >>>> +- Dump register >>>> +- Dump private info from device >>>> +- FW version >>>> >>> Hi Huisong, >>> >>> Can you please add fixes tag for each feature, to let track the relevant >>> code commit with claimed feature support? >> Thanks for your advice. >> Put fixes tag of each feature commit in the commit log of this patch, >> right? >> > Like for "Basic stats", add commit that introduces basic stats as fixes > line, same for each feature added above. ok > > >> Do we need to Cc stable? >> > For this case, main purpose for above fixes tags is to provide back > trace from document to the code, > but adding 'stable' tag enables backporting this document patch to LTS > release, which doesn't hurt, so please add stable tag too. all right, many thanks for you. > .